#66 Ubuntu Unity global menu breaks bookmark menu

MComix_0.99
closed
nobody
None
5
2014-08-04
2013-07-12
No

If you use MComix with Ubuntu Unity's global menu, the bookmarks are missing from the bookmark menu. The bookmark menu itself is there just fine, as are the menu items for adding a new bookmark and for editing the existing bookmarks, respectively. But the existing bookmarks are not listed under those bookmarks.

If you use MComix without the global menu, the bookmarks are listed as they should. Probably the best way to reproduce the problem is to have Unity show both types of menu, the global and the application menu. You can do that by setting the variable APPMENU_DISPLAY_BOTH to 1:

APPMENU_DISPLAY_BOTH mcomix

This way, you get two menu bars with a bookmark menu each. One of those bookmark menus, the one in the application window, does list the existing bookmarks, the other doesn't.

A little poking around in the code gave me the impression that the function menu_shown from bookmark_menu.py isn't called, for whatever reason. But this is mostly guesswork, because my experience with Python is rather limited so far ;)

Discussion

  • Oddegamra
    Oddegamra
    2013-07-13

    • status: open --> pending
     
  • Oddegamra
    Oddegamra
    2013-07-13

    Normally, the bookmarks menu should be re-created every time it is shown (to make sure all displayed bookmarks are up-to-date). In GTK+, there is no event that triggers when a menu is activated, so the workaround here was to trigger menu_show when the first menu entry ("Add bookmark") was displayed. My best guess is that the Unity menu plays by different rules and does not trigger the necessary UI events for MComix.

    In any case, that approach was probably flawed to begin with, so I'll use internal event handling instead to only update the menu if changes were made to the bookmark store. Still in the process of setting up an Ubuntu VM for testing, so I'll mark this as pending for the time being.

     
  • Oddegamra
    Oddegamra
    2013-07-13

    • status: pending --> closed
     
  • Oddegamra
    Oddegamra
    2013-07-13

    That seems to have done the trick. Thanks for reporting the issue, which should be fixed starting from SVN revision 939.