#127 mcomix won't open CBR files

[Kim Scarborough]

Just installed 2.0.1... CBZ files open fine, but I get the following error when I attempt to open CBR files:

[Thread-1 (_run)-list] ERROR: ! Worker thread processing <bound method Extractor._list_contents of <mcomix.archive_extractor.Extractor object at 0x7f0965dc5090>> failed: a bytes-like object is required, not 'str'

[Oddegamra]

Thank you for reporting this problem. Could you please start MComix with "mcomixstarter -Wall name-of-your-archive.cbr" and post the resulting error messages/traceback?

[Kim Scarborough]

03:19:19 [MainThread] INFO: GDK version: 2.42.8, GTK+: 3.24
03:19:19 [MainThread] INFO: PIL version: Pillow [9.1.0]
03:19:19 [MainThread] DEBUG: _SUPPORTED_IMAGE_REGEX='\.(ani|apm|apng|avif|bmp|bw|cur|dib|eps|gif|heic|heif|icb|icns|ico|j2c|j2k|jfif|jp2|jpc|jpe|jpeg|jpf|jpg|jpx|mpo|palm|pbm|pcx|pgm|png|pnm|ppm|ps|psd|qif|qtif|rgb|rgba|sgi|svg|svg\.gz|svgz|targa|tga|tif|tiff|vda|vst|webp|wmf|xbm|xpm)$'
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 1511 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 2447 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 4060 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 418 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 446 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 572 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 435 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 465 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 456 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 581 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 920 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 686 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 540 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 558 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 597 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 556 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 875 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 1242 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 622 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 961 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 735 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 650 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 660 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 509 bytes
03:19:19 [MainThread] DEBUG: provider 0 succeeded in decoding 649 bytes
03:19:19 [MainThread] DEBUG: mutool executable not found
03:19:19 [MainThread] INFO: MuPDF not available.
03:19:19 [MainThread] DEBUG: _SUPPORTED_ARCHIVE_REGEX='\.(7z|bz2|bzip2|cb7|cbr|cbt|cbz|gz|lha|lzh|lzma|rar|tar|xz|zip)$'
03:19:19 [MainThread] DEBUG: Archive handler RarArchive for archive "jingle belle 004 (2005) 25p (jormungand-dcp) [dark horse].cbr" was selected.
03:19:19 [Thread-1 (_run)-list] ERROR: ! Worker thread processing <bound method Extractor._list_contents of <mcomix.archive_extractor.Extractor object at 0x7f8d237d90c0>> failed: a bytes-like object is required, not 'str'
03:19:19 [Thread-1 (_run)-list] DEBUG: Traceback:
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/mcomix/worker_thread.py", line 71, in _run
    self._process_order(order)
  File "/usr/lib/python3.10/site-packages/mcomix/archive_extractor.py", line 215, in _list_contents
    for f in archive.iter_contents():
  File "/usr/lib/python3.10/site-packages/mcomix/archive/archive_recursive.py", line 83, in iter_contents
    for f in self._iter_contents(self._main_archive):
  File "/usr/lib/python3.10/site-packages/mcomix/archive/archive_recursive.py", line 31, in _iter_contents
    for f in archive.iter_contents():
  File "/usr/lib/python3.10/site-packages/mcomix/archive/rar_external.py", line 104, in iter_contents
    filename = self._parse_list_output_line(line.rstrip(os.linesep))
TypeError: a bytes-like object is required, not 'str'

03:19:23 [MainThread] DEBUG: provider 0 succeeded in decoding 1511 bytes
03:19:23 [MainThread] DEBUG: provider 0 succeeded in decoding 2447 bytes
03:19:23 [MainThread] DEBUG: provider 0 succeeded in decoding 4060 bytes
03:19:23 [MainThread] DEBUG: Waiting for thread <Thread(Thread-2 (rmtree)-delete, started 140244161144384)> to finish before exit

[Oddegamra]

Seems like the extraction code using the unrar executable instead of the 7z executable still was missing fixes for Python 3. The issue should be fixed now.