Because it seems to me that I had made more extensive changes other than just using the variables values.
This is simply to prevent that if this Beta version becomes official, you will have to indicate on your site that my theme (ThemeDarkRed) only works from versions 1.9.0.0 to verson 1.26.0.0
In the meantime, I will looking to try to adapt my theme to operate with ’before and after’ 1.26.0.0 code update.
By comparing sources, I notices a severe in-depth work.
Congratulations.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Your theme should work as is in 1.26.2.0 EXCEPT the Hide Button Icons/Text options. I had to change the FavoritesButtonStyle.xaml and TabButtonStyle.xaml files.
Oops too ! I have never used nor tested the options:
« Hide Button icons » & « Hide Button text » since they existed…
1/. I see that the option « Hide Button text » don’t work with my theme nor the theme « Chrome » in official version 1.26.0.0
2/. I confirm that in version 1.26.2.0, option « hide button icons » or option « Hide Button text » does not work with my theme nor any old included themes.
Unfortunately, I would not be available before May 26 (in approximately one week) to make the necessary modifications to my theme and all the old included themes to offer a pseudo « pull request » to fix all of this…
At the same time, I have to admit that there is a moment that I didn’t test any of the new options or changes availables…
In short, nothing serious. And on my side, by end of may, all will be fixed.
With my thanks for not abandoning this project that would deserve to be better known!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
No worries. The main objective for the next release is maintainability. That is why several parts of the code were rewritten and moved around but much still needs to be reviewed although not critical. I think it's slightly easier now to make modifications and experiments for future changes.
One of the most tedious things to change previously were the themes. Any change in any part of the theme had to be changed in others and then checked. That was poorly designed. I am hoping that the Basic and Detailed themes will be enough for most users. Those two themes and their copies are just references to the original Basic and Detailed themes. They do not contain any templates so future changes need only be made in code and the themes will still work without user intervention.
Interesting fact!!! I discovered something in 1.26.1.0. The Old Themes seemed to work fine but at least one control, MainTabControl's style was not being applied when loading a theme. It just seemed like it was being loaded because the Default theme (in code) was similar in structure so what was actually being used is the MainTabControl's style in code.
I honestly want to discourage average users to use the Old Themes because a change in code might break something in a future release, just like the Hide Button Icons/Text in the Old Themes.
As for other users who like to tinker or have enough programming knowhow, they can still create their own themes with fancy templates. They can still share their themes. They just need to update it as the need arise. Maintainability is a bit different with the packaged themes. They are simply expected to work with each distribution which is difficult with the previous theming method.
BTW, your theme works fine with the old and new versions I think; haven't fully tested it. The only thing lacking is support for the Hide Button Icons/Text in 1.26.2.0. The two file in my previous message includes the two files with the necessary changes.
Thank you for all your help.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello Roberto,
The fresh version Beta 1.26.1.0 seems to have only two themes:
- Basic
- Detailed
They work well depending on whether you want to make detailed or simples customizations.
If we import old themes from previous versions ( Brushed Metal - Dark… , Brushed Metal - Light… , Solid Color -… , Chrome )
They also work.
On the other hand, the theme that I had made customized available here: https://maxlauncher.sourceforge.io/themes/index.html (ThemeDarkRed) no longer works with this version Beta 1.26.1.0
BUT, Do not touch anything for the moment !
Because it seems to me that I had made more extensive changes other than just using the variables values.
This is simply to prevent that if this Beta version becomes official, you will have to indicate on your site that my theme (ThemeDarkRed) only works from versions 1.9.0.0 to verson 1.26.0.0
In the meantime, I will looking to try to adapt my theme to operate with ’before and after’ 1.26.0.0 code update.
By comparing sources, I notices a severe in-depth work.
Congratulations.
Oh No=) ! Sorry, I touched a few things.
https://sourceforge.net/p/maxlauncher/bugs/milestone/1.26.1.0/
Bugs 90 & 91 also affect Old Themes.
Your theme should work as is in 1.26.2.0 EXCEPT the Hide Button Icons/Text options. I had to change the FavoritesButtonStyle.xaml and TabButtonStyle.xaml files.
Oops ...
https://sourceforge.net/projects/maxlauncher/files/MaxLauncher/Beta/1.26.2.0/
Hello roberto,
Oops too ! I have never used nor tested the options:
« Hide Button icons » & « Hide Button text » since they existed…
1/. I see that the option « Hide Button text » don’t work with my theme nor the theme « Chrome » in official version 1.26.0.0
2/. I confirm that in version 1.26.2.0, option « hide button icons » or option « Hide Button text » does not work with my theme nor any old included themes.
I also see that all the explanation and the solution is here: https://sourceforge.net/p/maxlauncher/bugs/92/
Unfortunately, I would not be available before May 26 (in approximately one week) to make the necessary modifications to my theme and all the old included themes to offer a pseudo « pull request » to fix all of this…
At the same time, I have to admit that there is a moment that I didn’t test any of the new options or changes availables…
In short, nothing serious. And on my side, by end of may, all will be fixed.
With my thanks for not abandoning this project that would deserve to be better known!
Hi Sarah,
No worries. The main objective for the next release is maintainability. That is why several parts of the code were rewritten and moved around but much still needs to be reviewed although not critical. I think it's slightly easier now to make modifications and experiments for future changes.
One of the most tedious things to change previously were the themes. Any change in any part of the theme had to be changed in others and then checked. That was poorly designed. I am hoping that the Basic and Detailed themes will be enough for most users. Those two themes and their copies are just references to the original Basic and Detailed themes. They do not contain any templates so future changes need only be made in code and the themes will still work without user intervention.
Interesting fact!!! I discovered something in 1.26.1.0. The Old Themes seemed to work fine but at least one control, MainTabControl's style was not being applied when loading a theme. It just seemed like it was being loaded because the Default theme (in code) was similar in structure so what was actually being used is the MainTabControl's style in code.
I honestly want to discourage average users to use the Old Themes because a change in code might break something in a future release, just like the Hide Button Icons/Text in the Old Themes.
As for other users who like to tinker or have enough programming knowhow, they can still create their own themes with fancy templates. They can still share their themes. They just need to update it as the need arise. Maintainability is a bit different with the packaged themes. They are simply expected to work with each distribution which is difficult with the previous theming method.
BTW, your theme works fine with the old and new versions I think; haven't fully tested it. The only thing lacking is support for the Hide Button Icons/Text in 1.26.2.0. The two file in my previous message includes the two files with the necessary changes.
Thank you for all your help.