#88 Bug when assigning the first image (index 0?) from a .ICO icon/icon library

[Sarah Nomi]

Hello,

I’m going to be a bit technical because I’m talking to @madproton who knows the subject.

A new bug has appeared between the version of Maxlauncher 1.24 (M1.24) and the version of Maxlauncher 1.25 (M1.25)

It concerns the assignment / choice of an icon for a file or a folder.

The bug seems to concern icon-type’s images / libraries (.ICO) with one or more images inside (16 x 16 pixels , 24, 48, 64, 128 ...)
And more particularly the first image at index 0 in an icon / icons’library / dll …

I suggest a video of the bug to be more expressive.

These are the 3 same videos, only the format change ( MP4 , AVI , WMV )
Select only one with extension you browser can manage…

MP4 ( 5.24 MB  ) ➜ https://bit.ly/bug_MP4
WMV ( 34.4 MB! ) ➜ https://bit.ly/bug_WMV
AVI ( 59.2 MB! ) ➜ https://bit.ly/bug_AVI

---

Note : X’Y” means X minutes Y seconds.

1)    If there is only one selectable image in the icon (then necessarily in index 0)

M1.24 |  OK : 0’00” ➜ 0’30”
M1.25 | NOK : 1’50” ➜ 2’06”

2)    If there are several images in the icon and the first image at index 0 in the group is selected

M1.24 |  OK : 0’30 ”➜ 0’51”
M1.25 | NOK : 2’08” ➜ 2’24”

3)    If there are several images in the icon and you select any image except the first one (no index 0) and VALIDATE ; THEN now select the first image at index 0

M1.24 |  OK : 0’52” ➜ 1’17” (Note, I didnt validate another index than zero before validate index 0 here , but meh, everything works with M1.24)
M1.25 | OK : 2’24” ➜ 3’00”

---

Absolutely not sure but bug seem to come from line around 306 - 312 in EditButtonDialog.xaml.vb
See comparison picture between M1.24 and M1.25 ➜ https://bit.ly/bug_code

You like Maxlauncher ? ➜ https://bit.ly/I_support_MaxLauncher

Thanks !

[madproton]

Hi,

WOWOWOWOOWWOW!!!! So detailed, always impressive. Took me all of 5 seconds to fix.

Many many thanks.

I've uploaded the modified version. https://sourceforge.net/projects/maxlauncher/files/MaxLauncher/1.25.0.0/

I'll check again later.

(Assign just to reduce another call to FileUtils.Path.ConvertToRelativePath)
NEW>> Dim newIconFile As String = FileUtils.Path.ConvertToRelativePath(sb.ToString)

OLD>> If String.Equals(curIconFile, Me.targetTextBox.Text, 0) AndAlso index = 0 Then
NEW>>If String.Equals(newIconFile, Me.targetTextBox.Text, 0) AndAlso index = 0 Then
Me.IconFile = String.Empty
Me.IconIndex = 0
Else
OLD>> Me.IconFile = curIconFile
NEW>> Me.IconFile = newIconFile

The mistake was from trying to reduce the size of the mld file by not writing the icon path if the index is non-zero(defualt).

Roberto

[Sarah Nomi]

I try to be precise in my requests and bug’s report to get — as we can see here again — faster and more efficients replies.

Some users need to learn from this, no need to be programmer :
It only need to be precise, accurate and specific when you want a new request or describes a bug.

Anyway, as far as I tested your 1.25.0.1 βeta, all reported bugs from above are fixed.

I need to push tests a little more with breaking or exotic .DLL’s, .ICO’s, .EXE’s icons and took this beta as daily use launcher.

As always, Thanks a lot !

[Sarah Nomi]

Note :

I see that the French translation (French.xaml) of this 1.25.0.1 βeta is particularly clear and precise.

Thank you to all the contributors and anonymous who continued to work on it in my absence!

it just lacks an underscore in <sys:String x:Key="TabControl_ContextMenu_Clear">_Vider</sys:String> to be usable in keyboard mode (alt)

[madproton]

Ticket moved from /p/maxlauncher/feature-requests/114/