From: Robert Dodier <robert.dodier@gm...>  20140429 20:15:34

On 20140427, Dimiter Prodanov <dimiterpp@...> wrote: > here is the latest update in the Fourier transform package: > > https://github.com/dprodanov/maximaft Thanks for the update. I have a few comments. * A list of pairs of tests cases and expected results would be helpful. * I think the names should be spelled out, as ft and ift are too easily lost in a namespace of about 2000 symbols. How about fourier and inverse_fourier. (Yes, I know there is already ilt for the inverse Laplace transform. It is an unfortunate name which we need not imitate.) There is already a function named fourier in share/calculus/fourie.mac but maybe that one should be renamed (to fourier_coefs or something). * I wonder if the symbols FT and IFT are needed internally. They seem to play the same role as noun operators. Can we express the rules in terms of 'fourier(...) and 'inverse_fourier(...) expressions? * Maybe you can explain the advantage of the _foo(t) / foo(t) system. I don't see that it's any simpler than 'foo(t) / foo(t), which is already wellknown in Maxima. * I see the implementation has a lot of explicit part hacking. I've tried to show how to use the rule system to handle the stuff which otherwise is handled by part hacking. If there is something that doesn't seem to work, let's have a look at it and fix the problem, instead of resorting to part hacking. Thanks for your work on this topic, I appreciate it. best, Robert Dodier 