Screenshot instructions:
Windows
Mac
Red Hat Linux
Ubuntu
Click URL instructions:
Rightclick on ad, choose "Copy Link", then paste here →
(This may not be possible with some types of ads)
From: SourceForge.net <noreply@so...>  20040107 15:00:21

Bugs item #872433, was opened at 20040107 09:00 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 Category: Share Libraries Group: None Status: Open Resolution: None Priority: 5 Submitted By: Barton Willis (willisbl) Assigned to: Nobody/Anonymous (nobody) Summary: rncombine broken Initial Comment: The function rncombine is broken. (C1) load("rncomb")$ Lines d2 and d3 are okay, but d4 is bogus (C2) rncombine(x+y/x); (D2) y/x+x (C3) rncombine(x+y/x); (D3) y/x+x (C4) rncombine(y+x/y); (D4) y+x (C5) build_info(); Maxima version: 5.9.0 Maxima build date: 19:10 2/9/2003 host type: i686pcmingw32 lispimplementationtype: Kyoto Common Lisp lispimplementationversion: GCL25.0 Notes: 1. The function rncombine is supposed to work like combine, except that it combines terms that have denominators that differ by a numerical factor. 2. When rncombine is fixed, either the function should autoload, or the user documentation should explain that one must first load rncomb.mac. Barton  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 
From: SourceForge.net <noreply@so...>  20080622 05:51:48

Bugs item #872433, was opened at 20040107 15:00 Message generated for change (Comment added) made by guno You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Share Libraries Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Barton Willis (willisbl) Assigned to: Nobody/Anonymous (nobody) Summary: rncombine broken Initial Comment: The function rncombine is broken. (C1) load("rncomb")$ Lines d2 and d3 are okay, but d4 is bogus (C2) rncombine(x+y/x); (D2) y/x+x (C3) rncombine(x+y/x); (D3) y/x+x (C4) rncombine(y+x/y); (D4) y+x (C5) build_info(); Maxima version: 5.9.0 Maxima build date: 19:10 2/9/2003 host type: i686pcmingw32 lispimplementationtype: Kyoto Common Lisp lispimplementationversion: GCL25.0 Notes: 1. The function rncombine is supposed to work like combine, except that it combines terms that have denominators that differ by a numerical factor. 2. When rncombine is fixed, either the function should autoload, or the user documentation should explain that one must first load rncomb.mac. Barton  Comment By: guno (guno) Date: 20080620 17:14 Message: Logged In: YES user_id=1709853 Originator: NO hi maxima/share/simplification/rncomb.mac contains the function rncombine1 from lineno 35 to lineno 50 this function contains the bug the factor multiplied in line 44 to flist is cancelled out again in line 48 if the "if" branch is taken but it is not cacelled out if the if branch is not taken. this is the bug. one can repair this by deleting line 44 and by changing line 48 to then flist:denomthru(cons(flist*flist_denom,lsplitdum*flist_denom))/flist_denom, now the function will work correct. can anybody do this? 35 rncombine1(list):=block( 36 [flist,splitdum,lsplitdum,flist_denom], 37 if list=[] then return(0), 38 flist:first(list), 39 if length(list)=1 40 then return(if inpart(num(flist),0)="+" 41 then rncombine1(args(num(flist)))/denom(flist) 42 else flist), 43 flist_denom:(flist_denom:denom(flist))/numfactor(flist_denom), 44 flist:flist*flist_denom, 45 splitdum:predpartition(rest(list), 46 lambda([dum],numberp(denom(dum)/flist_denom))), 47 if (lsplitdum:last(splitdum))#[] 48 then flist:denomthru(cons(flist,lsplitdum*flist_denom))/flist_denom, 49 flist+rncombine1(first(splitdum)))$ 50 guenter  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 
From: SourceForge.net <noreply@so...>  20080725 00:47:41

Bugs item #872433, was opened at 20040107 16:00 Message generated for change (Comment added) made by hgeyer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Share Libraries Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Barton Willis (willisbl) Assigned to: Nobody/Anonymous (nobody) Summary: rncombine broken Initial Comment: The function rncombine is broken. (C1) load("rncomb")$ Lines d2 and d3 are okay, but d4 is bogus (C2) rncombine(x+y/x); (D2) y/x+x (C3) rncombine(x+y/x); (D3) y/x+x (C4) rncombine(y+x/y); (D4) y+x (C5) build_info(); Maxima version: 5.9.0 Maxima build date: 19:10 2/9/2003 host type: i686pcmingw32 lispimplementationtype: Kyoto Common Lisp lispimplementationversion: GCL25.0 Notes: 1. The function rncombine is supposed to work like combine, except that it combines terms that have denominators that differ by a numerical factor. 2. When rncombine is fixed, either the function should autoload, or the user documentation should explain that one must first load rncomb.mac. Barton  >Comment By: Harald Geyer (hgeyer) Date: 20080725 02:47 Message: Logged In: YES user_id=929336 Originator: NO Hi guenter, thanks for looking into this, i think I'll commit the suggested fix, as without this rncombine is completely broken. However while reviewing the fix and writing some rtest file I found the following issue: (%i12) rncombine(f/(3*b)+1/2+a/b+c/d) (%o12) (f+3*a)/(3*b)+c/d+1/2 (%i13) rncombine(f/(3*b)+x+a/b+c/d) (%o13) x+(f/3+a)/b+c/d < THIS IS ODD (%i14) rncombine(f/(3*b)+a+x/b+c/d) (%o14) (3*x+f)/(3*b)+c/d+a %o13 is not wrong, but it is not what I'd expect rncombine() to do. I think the result of rncombine() shouldn't depend on the ordering of symbols. As rncombine() was completely broken in the past several years and we didn't get lots of complaints perhaps it is best to just cut it out? Any opinions?  Comment By: guno (guno) Date: 20080620 19:14 Message: Logged In: YES user_id=1709853 Originator: NO hi maxima/share/simplification/rncomb.mac contains the function rncombine1 from lineno 35 to lineno 50 this function contains the bug the factor multiplied in line 44 to flist is cancelled out again in line 48 if the "if" branch is taken but it is not cacelled out if the if branch is not taken. this is the bug. one can repair this by deleting line 44 and by changing line 48 to then flist:denomthru(cons(flist*flist_denom,lsplitdum*flist_denom))/flist_denom, now the function will work correct. can anybody do this? 35 rncombine1(list):=block( 36 [flist,splitdum,lsplitdum,flist_denom], 37 if list=[] then return(0), 38 flist:first(list), 39 if length(list)=1 40 then return(if inpart(num(flist),0)="+" 41 then rncombine1(args(num(flist)))/denom(flist) 42 else flist), 43 flist_denom:(flist_denom:denom(flist))/numfactor(flist_denom), 44 flist:flist*flist_denom, 45 splitdum:predpartition(rest(list), 46 lambda([dum],numberp(denom(dum)/flist_denom))), 47 if (lsplitdum:last(splitdum))#[] 48 then flist:denomthru(cons(flist,lsplitdum*flist_denom))/flist_denom, 49 flist+rncombine1(first(splitdum)))$ 50 guenter  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 
From: SourceForge.net <noreply@so...>  20080808 02:47:31

Bugs item #872433, was opened at 20040107 16:00 Message generated for change (Comment added) made by hgeyer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Share Libraries Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Barton Willis (willisbl) Assigned to: Nobody/Anonymous (nobody) Summary: rncombine broken Initial Comment: The function rncombine is broken. (C1) load("rncomb")$ Lines d2 and d3 are okay, but d4 is bogus (C2) rncombine(x+y/x); (D2) y/x+x (C3) rncombine(x+y/x); (D3) y/x+x (C4) rncombine(y+x/y); (D4) y+x (C5) build_info(); Maxima version: 5.9.0 Maxima build date: 19:10 2/9/2003 host type: i686pcmingw32 lispimplementationtype: Kyoto Common Lisp lispimplementationversion: GCL25.0 Notes: 1. The function rncombine is supposed to work like combine, except that it combines terms that have denominators that differ by a numerical factor. 2. When rncombine is fixed, either the function should autoload, or the user documentation should explain that one must first load rncomb.mac. Barton  >Comment By: Harald Geyer (hgeyer) Date: 20080808 04:47 Message: Logged In: YES user_id=929336 Originator: NO Ok, commited the patch to CVS as rncomb.mac rev 1.3  Comment By: Harald Geyer (hgeyer) Date: 20080725 02:47 Message: Logged In: YES user_id=929336 Originator: NO Hi guenter, thanks for looking into this, i think I'll commit the suggested fix, as without this rncombine is completely broken. However while reviewing the fix and writing some rtest file I found the following issue: (%i12) rncombine(f/(3*b)+1/2+a/b+c/d) (%o12) (f+3*a)/(3*b)+c/d+1/2 (%i13) rncombine(f/(3*b)+x+a/b+c/d) (%o13) x+(f/3+a)/b+c/d < THIS IS ODD (%i14) rncombine(f/(3*b)+a+x/b+c/d) (%o14) (3*x+f)/(3*b)+c/d+a %o13 is not wrong, but it is not what I'd expect rncombine() to do. I think the result of rncombine() shouldn't depend on the ordering of symbols. As rncombine() was completely broken in the past several years and we didn't get lots of complaints perhaps it is best to just cut it out? Any opinions?  Comment By: guno (guno) Date: 20080620 19:14 Message: Logged In: YES user_id=1709853 Originator: NO hi maxima/share/simplification/rncomb.mac contains the function rncombine1 from lineno 35 to lineno 50 this function contains the bug the factor multiplied in line 44 to flist is cancelled out again in line 48 if the "if" branch is taken but it is not cacelled out if the if branch is not taken. this is the bug. one can repair this by deleting line 44 and by changing line 48 to then flist:denomthru(cons(flist*flist_denom,lsplitdum*flist_denom))/flist_denom, now the function will work correct. can anybody do this? 35 rncombine1(list):=block( 36 [flist,splitdum,lsplitdum,flist_denom], 37 if list=[] then return(0), 38 flist:first(list), 39 if length(list)=1 40 then return(if inpart(num(flist),0)="+" 41 then rncombine1(args(num(flist)))/denom(flist) 42 else flist), 43 flist_denom:(flist_denom:denom(flist))/numfactor(flist_denom), 44 flist:flist*flist_denom, 45 splitdum:predpartition(rest(list), 46 lambda([dum],numberp(denom(dum)/flist_denom))), 47 if (lsplitdum:last(splitdum))#[] 48 then flist:denomthru(cons(flist,lsplitdum*flist_denom))/flist_denom, 49 flist+rncombine1(first(splitdum)))$ 50 guenter  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 
From: SourceForge.net <noreply@so...>  20091106 23:30:41

Bugs item #872433, was opened at 20040107 16:00 Message generated for change (Comment added) made by crategus You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Share Libraries Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Barton Willis (willisbl) Assigned to: Nobody/Anonymous (nobody) Summary: rncombine broken Initial Comment: The function rncombine is broken. (C1) load("rncomb")$ Lines d2 and d3 are okay, but d4 is bogus (C2) rncombine(x+y/x); (D2) y/x+x (C3) rncombine(x+y/x); (D3) y/x+x (C4) rncombine(y+x/y); (D4) y+x (C5) build_info(); Maxima version: 5.9.0 Maxima build date: 19:10 2/9/2003 host type: i686pcmingw32 lispimplementationtype: Kyoto Common Lisp lispimplementationversion: GCL25.0 Notes: 1. The function rncombine is supposed to work like combine, except that it combines terms that have denominators that differ by a numerical factor. 2. When rncombine is fixed, either the function should autoload, or the user documentation should explain that one must first load rncomb.mac. Barton  >Comment By: Dieter Kaiser (crategus) Date: 20091107 00:30 Message: The original example now works. See the patch in the last posting. The documentation explains that the function has to be loaded first. Closing this bug report as fixed. Dieter Kaiser  Comment By: Harald Geyer (hgeyer) Date: 20080808 04:47 Message: Logged In: YES user_id=929336 Originator: NO Ok, commited the patch to CVS as rncomb.mac rev 1.3  Comment By: Harald Geyer (hgeyer) Date: 20080725 02:47 Message: Logged In: YES user_id=929336 Originator: NO Hi guenter, thanks for looking into this, i think I'll commit the suggested fix, as without this rncombine is completely broken. However while reviewing the fix and writing some rtest file I found the following issue: (%i12) rncombine(f/(3*b)+1/2+a/b+c/d) (%o12) (f+3*a)/(3*b)+c/d+1/2 (%i13) rncombine(f/(3*b)+x+a/b+c/d) (%o13) x+(f/3+a)/b+c/d < THIS IS ODD (%i14) rncombine(f/(3*b)+a+x/b+c/d) (%o14) (3*x+f)/(3*b)+c/d+a %o13 is not wrong, but it is not what I'd expect rncombine() to do. I think the result of rncombine() shouldn't depend on the ordering of symbols. As rncombine() was completely broken in the past several years and we didn't get lots of complaints perhaps it is best to just cut it out? Any opinions?  Comment By: guno (guno) Date: 20080620 19:14 Message: Logged In: YES user_id=1709853 Originator: NO hi maxima/share/simplification/rncomb.mac contains the function rncombine1 from lineno 35 to lineno 50 this function contains the bug the factor multiplied in line 44 to flist is cancelled out again in line 48 if the "if" branch is taken but it is not cacelled out if the if branch is not taken. this is the bug. one can repair this by deleting line 44 and by changing line 48 to then flist:denomthru(cons(flist*flist_denom,lsplitdum*flist_denom))/flist_denom, now the function will work correct. can anybody do this? 35 rncombine1(list):=block( 36 [flist,splitdum,lsplitdum,flist_denom], 37 if list=[] then return(0), 38 flist:first(list), 39 if length(list)=1 40 then return(if inpart(num(flist),0)="+" 41 then rncombine1(args(num(flist)))/denom(flist) 42 else flist), 43 flist_denom:(flist_denom:denom(flist))/numfactor(flist_denom), 44 flist:flist*flist_denom, 45 splitdum:predpartition(rest(list), 46 lambda([dum],numberp(denom(dum)/flist_denom))), 47 if (lsplitdum:last(splitdum))#[] 48 then flist:denomthru(cons(flist,lsplitdum*flist_denom))/flist_denom, 49 flist+rncombine1(first(splitdum)))$ 50 guenter  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=104933&aid=872433&group_id=4933 