Menu
▾
▴
[Maven-plugins-trackers] [ maven-plugins-Feature Requests-1872688 ] [maven-javancss-plugin] Upgrade to 28.49
|
From: SourceForge.net <no...@so...> - 2008-02-28 11:18:39
|
Feature Requests item #1872688, was opened at 2008-01-16 12:42 Message generated for change (Comment added) made by xaviou You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=497856&aid=1872688&group_id=61626 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: JavaNCSS Group: Next Release (example) Status: Open Resolution: Fixed Priority: 5 Private: No Submitted By: Xavier Chatelain (xaviou) Assigned to: Jeff Jensen (jeffjensen) Summary: [maven-javancss-plugin] Upgrade to 28.49 Initial Comment: It seems maven-javancss-plugin version 1.3.1 comes with the oldest version of javancss (21.41, md5sum 8d51423d054285a8712810ac746a9e98). Could it be upgraded with the latest version of JavaNCSS (28.49)? This latest version (28.49) comes with "Various Java 1.5 grammar parser bugs fixed". With the current version (21.41) we have ParseException like that: [echo] Generating the JavaNCSS... javancss: [echo] Generating JavaNCSS report for site generation javancss:do-xml: [...] [java] Lexical error at line 35, column 8. Encountered: "@" (64), after : "" [...] [java] Encountered "enum" at line 32, column 8. [java] Was expecting one of: [java] "abstract" ... [java] "interface" ... [java] "public" ... [java] "final" ... [java] "synchronized" ... [java] "strictfp" ... [java] "class" ... ---------------------------------------------------------------------- >Comment By: Xavier Chatelain (xaviou) Date: 2008-02-28 12:18 Message: Logged In: YES user_id=932495 Originator: YES Hi Jeff! I eventually had the time to test it, and it works (I don't get anymore the Java5 bugs as explained above)! Here was my test plan (just to say there was one) : 1. I tested with the 1.3.1 version, and the bug appeared 2. I uninstalled the 1.3.1 version from my maven 1 installation 3. Actually I did not find the snapshot (on http://people.apache.org/repo/m1-snapshot-repository/maven/plugins/), so I updated the new files from the CVS (the project.xml and the 3 jars) and built and install the 1.3.2 snapshot. 4. I tested with the 1.3.2.snapshot, and it works! So it can be released! ---------------------------------------------------------------------- Comment By: Jeff Jensen (jeffjensen) Date: 2008-02-11 20:31 Message: Logged In: YES user_id=498804 Originator: NO It seems so - I updated all 3 and checked them in. It looks like it did not change, but the other 2 did. The file sizes between the new and old are the same too. ---------------------------------------------------------------------- Comment By: Xavier Chatelain (xaviou) Date: 2008-02-11 15:40 Message: Logged In: YES user_id=932495 Originator: YES Thanks Jeff for the snapshot. I did not have the chance to test it yet (I am away until the end of the week), but I noticed that jhbasic.jar has not been updated in the CVS repo (in /maven-plugins/javancss/jars). Is it normal? ---------------------------------------------------------------------- Comment By: Jeff Jensen (jeffjensen) Date: 2008-02-10 18:19 Message: Logged In: YES user_id=498804 Originator: NO Thank you very much for your simple instructions and trying it first. I deployed a 1.3.2 snapshot; please verify it works so we can release it! I can't believe almost a month has passed since you entered them...I am sorry it took so long for me to do this. You are of course correct on the "hack packaging". I did not make any attempt to change that! If you find want to, please do... :-) I don't remember history on that, and it could very well be there were issues getting the artifacts in central/ibiblio at one time. ---------------------------------------------------------------------- Comment By: Xavier Chatelain (xaviou) Date: 2008-01-16 17:55 Message: Logged In: YES user_id=932495 Originator: YES Hi Jeff! Here is a quick hack, in order to release a maven-javancss-plugin with the latest JavaNCSS JAR: 1. Download the latest version of JavaNCSS here: http://www.kclee.de/clemens/java/javancss/javancss28.49.zip 2. Unzip, and commit the 3 JARs (ccl.jar, javancss.jar and jhbasic.jar) in the /maven-plugins/javancss/jars CVS repository. I did a plugin install and tested it, it works fine (I don't get anymore the Java5 bugs as explained above). Note (this may be another feature/bug request): this hack is as dirty as the plugin packaging is today: actually the 3 JARs are packed within the plugin, but this may not be necessary as they are available in the Maven repo (here: http://repo1.maven.org/maven/javancss/jars/). ---------------------------------------------------------------------- Comment By: Jeff Jensen (jeffjensen) Date: 2008-01-16 14:04 Message: Logged In: YES user_id=498804 Originator: NO Hi Xavier! Do you have time to determine the changes and test it, then attach the patch file(s)? Besides making the time to get to it, I don't have a working setup of this plugin (which not only adds to the time, it reduces the test cases!). I'll gladly package and release it for you... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=497856&aid=1872688&group_id=61626 |
