Re: [Maven-plugins-developer] [vote] Releasemaven-cobertura-plugin-1.2

[Jeff J. <jef...@up...>]

Giving it some thought this morning, I strongly prefer to release the
plugins code as-is (since they've had many weeks of problem-free running)
and update the docs to note the debug setting issue, and do another snapshot
soon after with any debug code-handling decision.

I think this because the debug issue is not new/not a regression, and this
change should have more than casual testing to avoid any issues when the
user wants debug off.

Even though the code change appears minor, small "innocent" changes are
famous for causing problems.  :-)  I really am against the "last minute
change" syndrome.

Additionally, new FindBugs and Cobertura releases are on the horizon, so
additional plugin releases are forthcoming when they are available and have
some miles on them.


-----Original Message-----
From: mav...@li...
[mailto:mav...@li...] On Behalf Of
Jeff Jensen
Sent: Friday, June 02, 2006 12:10 PM
To: Lukas Theussl
Cc: mav...@li...
Subject: Re: [Maven-plugins-developer] [vote]
Releasemaven-cobertura-plugin-1.2

Great info Lukas, thanks.  I will change the plugin and add a doc note.


Quoting Lukas Theussl <lth...@ap...>:

>
> +1
>
> However, not having used cobertura for a long time, I had forgotten 
> that you need to set maven.compile.debug=on when running the plugin, 
> otherwise you don't get any coverage data. I had 
> maven.compile.debug=off in one of my properties files and it took me a 
> while to figure out what was wrong.
>
> AFAICS, this is nowhere mentioned in the docs on the web page. 
> However, instead of letting the user figure this out himself, I'd 
> suggest we force debug=on when executing the plugin, since otherwise, 
> the report is completely useless anyway. Just put something like this 
> in the cobertura:report goal when calling cobertura:on:
>
>      <!-- Make sure maven.compile.debug = on -->
>      <j:set var="compileDebugOld" value="${maven.compile.debug}"/>
>      <j:set var="maven.compile.debug" scope="parent" value="on"/>
>      <attainGoal name="cobertura:on"/>
>      <j:set var="maven.compile.debug" scope="parent"
> value="${compileDebugOld}"/>
>
>
> Actually, I just noticed that also findbugs needs debug=on for getting 
> the line number information. You should do the same as above when 
> calling java:compile in maven-findbugs-plugin:report.
>
>
> Cheers,
> -Lukas
>
>
> Jeff Jensen wrote:
> > Please vote to release Cobertura plugin from snapshot.  I will do so 
> > on
> Sunday
> > if no objections.
> >
> >
> >
> > _______________________________________________
> > Maven-plugins-developer mailing list 
> > Mav...@li...
> > https://lists.sourceforge.net/lists/listinfo/maven-plugins-developer
> >
>





_______________________________________________
Maven-plugins-developer mailing list
Mav...@li...
https://lists.sourceforge.net/lists/listinfo/maven-plugins-developer