Thread: [Maven-js-plugin-users] Doesnt compress scripts under the vendor folder
Brought to you by:
mvaaltemus
From: Kannan E. <kan...@gm...> - 2007-11-07 09:36:41
|
Hi, This is further to the thread http://sourceforge.net/forum/forum.php?thread_id=1858317&forum_id=712484 I have my folder structure as follows webapp src main java resources webapp (this is the folder under which web contents are placed) scripts myapp (some scripts under many directory levels) ---- A jscalendar B.js directly under jscalendar lang (folder) C.js under a lang folder vendor dojo-widget (Many java script files) myvendor (js files) test My configuration for the plugin has a <include>**/**.js</include>. I see that all scripts under myapp folder are getting compressed (they are nested deep at many directory levels). B.js directly under jscalendar is getting compressed. However anything under vendor/dojo-widget is not getting compressed. and anything under lang folder is not getting compressed. I assumed it was the licensing information which was present in these files which was the problem, but some files under myvendor folder is not getting compressed although there is no license information. I am not able to do any *guess* based on these patterns, can someone tell me why these folders are getting skipped or if you need someother logs how I should enable them? -- Regards, Kannan Ekanath |
From: Kannan E. <kan...@gm...> - 2007-11-07 10:32:44
|
Ok, I got the issue here, i see a small message "Unterminated string literal". I put a System.out in JSMin.java file, and I could see that there was *indeed* an error in one particular javascript file, in the lang folder, which stopped further compression. Seems a little odd though, if there is a javascript error in one file, shouldnt the task go ahead and compress everything and then report errors ? :) My problem seems to be solved once I correct the javascript errors Regards, Kannan On Nov 7, 2007 3:06 PM, Kannan Ekanath <kan...@gm...> wrote: > Hi, > This is further to the thread > http://sourceforge.net/forum/forum.php?thread_id=1858317&forum_id=712484 > > I have my folder structure as follows > webapp > src > main > java > resources > webapp (this is the folder under which web contents are placed) > scripts > myapp > (some scripts under many directory levels) ---- > A > jscalendar > B.js directly under jscalendar > lang (folder) > C.js under a lang folder > vendor > dojo-widget > (Many java script files) > myvendor > (js files) > test > > My configuration for the plugin has a <include>**/**.js</include>. I see > that all scripts under myapp folder are getting compressed (they are nested > deep at many directory levels). B.js directly under jscalendar is getting > compressed. However anything under vendor/dojo-widget is not getting > compressed. and anything under lang folder is not getting compressed. > > I assumed it was the licensing information which was present in these > files which was the problem, but some files under myvendor folder is not > getting compressed although there is no license information. > > I am not able to do any *guess* based on these patterns, can someone tell > me why these folders are getting skipped or if you need someother logs how I > should enable them? > > -- > Regards, > Kannan Ekanath -- Regards, Kannan Ekanath |
From: Adam <pun...@gm...> - 2007-11-07 22:13:34
|
I just realized that the reply to was wrong on my email. Here it is again: I do think that the error logging needs to be more detailed, and it will be in 1.3 final. If you are using the current snapshot, it currently is listing the files that are being compressed. This is not a finalized logging implementation and is something I keep in only in the snapshots. Once it is removed, the error messages will be a lot clearer. On a side note, when you say it stopped further compression, do you mean on that file or altogether stopped compressing files? On Nov 7, 2007 10:16 AM, Adam <pun...@gm...> wrote: > I do think that the error logging needs to be more detailed, and it > will be in 1.3 final. If you are using the current snapshot, it > currently is listing the files that are being compressed. This is not > a finalized logging implementation and is something I keep in only in > the snapshots. Once it is removed, the error messages will be a lot > clearer. > > On a side note, when you say it stopped further compression, do you > mean on that file or altogether stopped compressing files? > > > On Nov 7, 2007 5:32 AM, Kannan Ekanath <kan...@gm...> wrote: > > Ok, I got the issue here, i see a small message "Unterminated string > > literal". I put a System.out in JSMin.java file, and I could see that there > > was *indeed* an error in one particular javascript file, in the lang folder, > > which stopped further compression. > > > > Seems a little odd though, if there is a javascript error in one file, > > shouldnt the task go ahead and compress everything and then report errors ? > > :) > > > > My problem seems to be solved once I correct the javascript errors > > > > Regards, > > Kannan > > > > > > > > On Nov 7, 2007 3:06 PM, Kannan Ekanath <kan...@gm...> wrote: > > > Hi, > > > This is further to the thread > > http://sourceforge.net/forum/forum.php?thread_id=1858317&forum_id=712484 > > > > > > I have my folder structure as follows > > > webapp > > > src > > > main > > > java > > > resources > > > webapp (this is the folder under which web contents are placed) > > > scripts > > > myapp > > > (some scripts under many directory levels) ---- > > A > > > jscalendar > > > B.js directly under jscalendar > > > lang (folder) > > > C.js under a lang folder > > > vendor > > > dojo-widget > > > (Many java script files) > > > myvendor > > > (js files) > > > test > > > > > > My configuration for the plugin has a <include>**/**.js</include>. I see > > that all scripts under myapp folder are getting compressed (they are nested > > deep at many directory levels). B.js directly under jscalendar is getting > > compressed. However anything under vendor/dojo-widget is not getting > > compressed. and anything under lang folder is not getting compressed. > > > > > > I assumed it was the licensing information which was present in these > > files which was the problem, but some files under myvendor folder is not > > getting compressed although there is no license information. > > > > > > I am not able to do any *guess* based on these patterns, can someone tell > > me why these folders are getting skipped or if you need someother logs how I > > should enable them? > > > > > > -- > > > Regards, > > > Kannan Ekanath > > > > > > > > -- > > Regards, > > Kannan Ekanath > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by: Splunk Inc. > > Still grepping through log files to find problems? Stop. > > Now Search log events and configuration files using AJAX and a browser. > > Download your FREE copy of Splunk now >> http://get.splunk.com/ > > _______________________________________________ > > Maven-js-plugin-users mailing list > > Mav...@li... > > https://lists.sourceforge.net/lists/listinfo/maven-js-plugin-users > > > > > > > > -- > Adam Altemus > -- Adam Altemus |
From: Kannan E. <kan...@gm...> - 2007-11-08 16:11:05
|
Hi Adam, In my case I am using 1.2 (since that is the version maven downloaded by default) and once error occured, it stopped further compressing *any* file (any file under the webapp folder). Thanks, Kannan On 11/8/07, Adam <pun...@gm...> wrote: > > I just realized that the reply to was wrong on my email. Here it is > again: > > I do think that the error logging needs to be more detailed, and it > will be in 1.3 final. If you are using the current snapshot, it > currently is listing the files that are being compressed. This is not > a finalized logging implementation and is something I keep in only in > the snapshots. Once it is removed, the error messages will be a lot > clearer. > > On a side note, when you say it stopped further compression, do you > mean on that file or altogether stopped compressing files? > > > On Nov 7, 2007 10:16 AM, Adam <pun...@gm...> wrote: > > I do think that the error logging needs to be more detailed, and it > > will be in 1.3 final. If you are using the current snapshot, it > > currently is listing the files that are being compressed. This is not > > a finalized logging implementation and is something I keep in only in > > the snapshots. Once it is removed, the error messages will be a lot > > clearer. > > > > On a side note, when you say it stopped further compression, do you > > mean on that file or altogether stopped compressing files? > > > > > > On Nov 7, 2007 5:32 AM, Kannan Ekanath <kan...@gm...> wrote: > > > Ok, I got the issue here, i see a small message "Unterminated string > > > literal". I put a System.out in JSMin.java file, and I could see that > there > > > was *indeed* an error in one particular javascript file, in the lang > folder, > > > which stopped further compression. > > > > > > Seems a little odd though, if there is a javascript error in one file, > > > shouldnt the task go ahead and compress everything and then report > errors ? > > > :) > > > > > > My problem seems to be solved once I correct the javascript errors > > > > > > Regards, > > > Kannan > > > > > > > > > > > > On Nov 7, 2007 3:06 PM, Kannan Ekanath <kan...@gm...> > wrote: > > > > Hi, > > > > This is further to the thread > > > > http://sourceforge.net/forum/forum.php?thread_id=1858317&forum_id=712484 > > > > > > > > I have my folder structure as follows > > > > webapp > > > > src > > > > main > > > > java > > > > resources > > > > webapp (this is the folder under which web contents are > placed) > > > > scripts > > > > myapp > > > > (some scripts under many directory > levels) ---- > > > A > > > > jscalendar > > > > B.js directly under jscalendar > > > > lang (folder) > > > > C.js under a lang folder > > > > vendor > > > > dojo-widget > > > > (Many java script files) > > > > myvendor > > > > (js files) > > > > test > > > > > > > > My configuration for the plugin has a <include>**/**.js</include>. I > see > > > that all scripts under myapp folder are getting compressed (they are > nested > > > deep at many directory levels). B.js directly under jscalendar is > getting > > > compressed. However anything under vendor/dojo-widget is not getting > > > compressed. and anything under lang folder is not getting compressed. > > > > > > > > I assumed it was the licensing information which was present in > these > > > files which was the problem, but some files under myvendor folder is > not > > > getting compressed although there is no license information. > > > > > > > > I am not able to do any *guess* based on these patterns, can someone > tell > > > me why these folders are getting skipped or if you need someother logs > how I > > > should enable them? > > > > > > > > -- > > > > Regards, > > > > Kannan Ekanath > > > > > > > > > > > > -- > > > Regards, > > > Kannan Ekanath > > > > ------------------------------------------------------------------------- > > > This SF.net email is sponsored by: Splunk Inc. > > > Still grepping through log files to find problems? Stop. > > > Now Search log events and configuration files using AJAX and a > browser. > > > Download your FREE copy of Splunk now >> http://get.splunk.com/ > > > _______________________________________________ > > > Maven-js-plugin-users mailing list > > > Mav...@li... > > > https://lists.sourceforge.net/lists/listinfo/maven-js-plugin-users > > > > > > > > > > > > > > -- > > Adam Altemus > > > > > > -- > Adam Altemus > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Maven-js-plugin-users mailing list > Mav...@li... > https://lists.sourceforge.net/lists/listinfo/maven-js-plugin-users > -- Regards, Kannan Ekanath |
From: Adam A. <aal...@mo...> - 2007-11-08 16:49:57
|
I will add that as a bug that needs fixed for the 1.3 release, as well as the need for improved error logging. _____ From: mav...@li... [mailto:mav...@li...] On Behalf Of Kannan Ekanath Sent: Thursday, November 08, 2007 11:11 AM To: Adam Cc: mav...@li... Subject: Re: [Maven-js-plugin-users] Doesnt compress scripts under thevendor folder Hi Adam, In my case I am using 1.2 (since that is the version maven downloaded by default) and once error occured, it stopped further compressing *any* file (any file under the webapp folder). Thanks, Kannan On 11/8/07, Adam <pun...@gm...> wrote: I just realized that the reply to was wrong on my email. Here it is again: I do think that the error logging needs to be more detailed, and it will be in 1.3 final. If you are using the current snapshot, it currently is listing the files that are being compressed. This is not a finalized logging implementation and is something I keep in only in the snapshots. Once it is removed, the error messages will be a lot clearer. On a side note, when you say it stopped further compression, do you mean on that file or altogether stopped compressing files? On Nov 7, 2007 10:16 AM, Adam < <mailto:pun...@gm...> pun...@gm...> wrote: > I do think that the error logging needs to be more detailed, and it > will be in 1.3 final. If you are using the current snapshot, it > currently is listing the files that are being compressed. This is not > a finalized logging implementation and is something I keep in only in > the snapshots. Once it is removed, the error messages will be a lot > clearer. > > On a side note, when you say it stopped further compression, do you > mean on that file or altogether stopped compressing files? > > > On Nov 7, 2007 5:32 AM, Kannan Ekanath <kan...@gm...> wrote: > > Ok, I got the issue here, i see a small message "Unterminated string > > literal". I put a System.out in JSMin.java file, and I could see that there > > was *indeed* an error in one particular javascript file, in the lang folder, > > which stopped further compression. > > > > Seems a little odd though, if there is a javascript error in one file, > > shouldnt the task go ahead and compress everything and then report errors ? > > :) > > > > My problem seems to be solved once I correct the javascript errors > > > > Regards, > > Kannan > > > > > > > > On Nov 7, 2007 3:06 PM, Kannan Ekanath <kan...@gm... > wrote: > > > Hi, > > > This is further to the thread > > http://sourceforge.net/forum/forum.php?thread_id=1858317 <http://sourceforge.net/forum/forum.php?thread_id=1858317&forum_id=712484> &forum_id=712484 > > > > > > I have my folder structure as follows > > > webapp > > > src > > > main > > > java > > > resources > > > webapp (this is the folder under which web contents are placed) > > > scripts > > > myapp > > > (some scripts under many directory levels) ---- > > A > > > jscalendar > > > B.js directly under jscalendar > > > lang (folder) > > > C.js under a lang folder > > > vendor > > > dojo-widget > > > (Many java script files) > > > myvendor > > > (js files) > > > test > > > > > > My configuration for the plugin has a <include>**/**.js</include>. I see > > that all scripts under myapp folder are getting compressed (they are nested > > deep at many directory levels). B.js directly under jscalendar is getting > > compressed. However anything under vendor/dojo-widget is not getting > > compressed. and anything under lang folder is not getting compressed. > > > > > > I assumed it was the licensing information which was present in these > > files which was the problem, but some files under myvendor folder is not > > getting compressed although there is no license information. > > > > > > I am not able to do any *guess* based on these patterns, can someone tell > > me why these folders are getting skipped or if you need someother logs how I > > should enable them? > > > > > > -- > > > Regards, > > > Kannan Ekanath > > > > > > > > -- > > Regards, > > Kannan Ekanath > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by: Splunk Inc. > > Still grepping through log files to find problems? Stop. > > Now Search log events and configuration files using AJAX and a browser. > > Download your FREE copy of Splunk now >> http://get.splunk.com/ > > _______________________________________________ > > Maven-js-plugin-users mailing list > > Mav...@li... > > https://lists.sourceforge.net/lists/listinfo/maven-js-plugin-users > > > > > > > > -- > Adam Altemus > -- Adam Altemus ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Maven-js-plugin-users mailing list Mav...@li... https://lists.sourceforge.net/lists/listinfo/maven-js-plugin-users -- Regards, Kannan Ekanath |