Re: [matplotlib-devel] Problems with new PyQt4 API

[Benjamin R. <ben...@ou...>]

On Thu, Mar 3, 2011 at 3:15 AM, Martin Teichmann <lkb...@gm...>wrote:

> Hi Benjamin, Hi List,
>
> sorry for the backwards patch, here the forward one:
>
> ------------------------------------------------------------------------
> --- backend_qt4_orig.py 2011-03-02 16:16:38.257797767 +0100
> +++ backend_qt4.py      2011-03-02 16:17:19.526831397 +0100
> @@ -395,8 +395,9 @@
>              filters.append(filter)
>         filters = ';;'.join(filters)
>
> -        fname = QtGui.QFileDialog.getSaveFileName(
> -            self, "Choose a filename to save to", start, filters,
> selectedFilter)
> +        fname, _ = QtGui.QFileDialog.getSaveFileNameAndFilter(
> +            self, "Choose a filename to save to", start, filters,
> +            selectedFilter)
>         if fname:
>             try:
>                 self.canvas.print_figure( unicode(fname) )
>
> ----------------------------------------------------------------------------
>
> It is done against a rather old version of matplotlib (the 0.99.3, the
> newest in kubuntu...) but the code hasn't changed since then,
> acording to github, so only the line numbers are wrong.
>
> The second patch I sent is now obsolete, as you hinted to the
> patch on github. I had followed the link on the matplotlib
> web site (http://matplotlib.sourceforge.net/) which links still to
> some subversion repository once you click onto "source code"
> Could please someone update that link to github? Or is there
> a new matplotlib website as well (google didn't find one).
>
> Greetings
>
> Martin
>
> --
> Max-Born-Institut
> Max-Born-Straße 2a
> 12489 Berlin
> +49 30 6392 1234
>

Martin,

Thank you for double-checking your patches.  I will see about getting it
added into mpl today.

As for the sourceforge/github confusion, we are currently in a transition
phase.  Our repository is now hosted on github, but the official website and
trackers are still sourceforge.  Sorry for any confusion there.  The
(un)official new website will be http://matplotlib.github.com.

Thank you for helping to make matplotlib better!

Ben Root