Re: [Matlab-emacs-discuss] matlab-version/matlab-show-version

[Eric L. <el...@ma...>]

It's probably fine to not print the version number when matlab-shell starts.  I don't think any other shell fcns print their version number.  A holdover from a different age.

Eric

-----Original Message-----
From: Uwe Brauer <ou...@ma...> 
Sent: Saturday, December 7, 2024 2:40 AM
To: Eric Ludlam <el...@ma...>
Cc: Uwe Brauer <ou...@ma...>; mat...@li...; John Ciolfi <ci...@ma...>
Subject: Re: matlab-version/matlab-show-version

>>> "EL" == Eric Ludlam <el...@ma...> writes:

>> From: Uwe Brauer <ou...@ma...> 
>>>>> "EL" == Eric Ludlam <el...@ma...> writes:

>>> The command matlab-show-version was always there since before I
>>> adopted matlab-mode. I'm not attached to it and would not mind if it
>>> were removed.

>> According to git blame or mercurial annotate, you are the author 😉
>> (however this functionality is not very reliable, since any chance in
>> the indent etc, is registered.

> Makes sense - Matt emailed me the file, and I put it into version control.  I think it was RCS at the time. 😊

I had to revert to commit b2baf6b106587480 causes problems with
matlab-shell.

I now understand why this function was added, it displays the
matlab-mode version when the shell is called.

However there is a byte compiler warning with this function namely 
In matlab-show-version:
matlab.el:1473:38: Warning: reference to free variable ‘matlab-mode-version’

Which was pointed out to me by the ELPA and MELPA maintainers.

What shall we do, any thought?


-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine.