Re: [Matlab-emacs-discuss] having emacs-matlab in ELPA, finally. FSF paper signed

[Uwe B. <ou...@ma...>]

> Uwe Brauer <ou...@ma...> writes:

> You don't have to do anything*, I just have to add a package
> specification (similar to the "recipe file" for MELPA) to elpa.git.

> * As soon as it works.  The main issues right now, are as you noticed
>   that ELPA doesn't release a new tarball for every commit, but just
>   when a new version is released.  We track this by checking for commits
>   that bump the "Version" header in the main file (in your case
>   matlab.el).  You currently don't have any version number, so the build
>   fails.  I would suggest applying a change like this, if it doesn't
>   break any assumptions you have regarding the minimal Emacs version:

> diff --git a/matlab.el b/matlab.el
> index 8ca0ee24a2..b82229a672 100644
> --- a/matlab.el
> +++ b/matlab.el
> @@ -5,11 +5,7 @@
>  ;; Maintainer: Eric M. Ludlam <el...@ma...>
>  ;; Created: 04 Jan 91
>  ;; Keywords: MATLAB(R)
> -;; Version:
> -
> -(defconst matlab-mode-version "5.0"
> -  "Current version of MATLAB(R) mode.")
> -
> +;; Version: 5.0
>  ;;
>  ;; Copyright (C) 1997-2022 Eric M. Ludlam
>  ;; Copyright (C) 1991-1997 Matthew R. Wette
> @@ -50,6 +46,10 @@
 
>  ;;; Code:
 
> +(defconst matlab-mode-version (package-get-version)
> +  "Current version of MATLAB(R) mode.")
> +
> +
>  (require 'matlab-compat)
>  (require 'matlab-syntax)
>  (require 'matlab-scan)

A couple of remarks, 

    1. this diff seems against an older matlab-mode version (may the one
       in sourceforge), the latest github version is 6.2
       https://github.com/mathworks/Emacs-MATLAB-Mode.git

    2. Jonas Bernoulli one of the MELPA maintainers, recommended (but
       did not demand) to add file called matlab-mode.el which is
       basically a dummy file but also contains the current version 


>   The other issue is that ELPA checks the copyright string and wants to
>   see that all packages in GNU ELPA have their copyright assigned to the
>   FSF.

There is an automated process for checking this. If I had known, it
would have saved my quite a bit of time and work. I eyeballed the logs
and if there was an unknown author I checked the diff, and if necessary
contacted him. 

>   If you can fix these two things, then everything should go through.
>   You can then decide to filter out files out of the final tarball by
>   adding an .elpaignore file that lists what files to exclude.


    1. I will add an elpaignore file, which is urgent,

    2. And concerning the version number, what shall I do, your proposal
       or Stefan's?

For the moment being I would like to keep the MELPA version as well till
I know ELPA works

Uwe 

-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine.