Re: [Matlab-emacs-discuss] the filling patch and its problems

[John C. <ci...@ma...>]

Hi Uwe,

I don't think these fill-paragraph patches made it into master. Attached are the patches that work for me. Are there any reasons to not apply them?

Thanks,
John



________________________________
From: Uwe Brauer <ou...@ma...>
Sent: Monday, July 31, 2023 11:57 AM
To: Eric Ludlam <el...@ma...>
Cc: Matlab-emacs-discuss <mat...@li...>
Subject: Re: [Matlab-emacs-discuss] the filling patch and its problems

>>> "EL" == Eric Ludlam <el...@ma...> writes:

> Is anyone out there interested in the "code fill" feature?

You mean besides me 😇 I do hope so!


> It was a hairy thing to implement back in the day, and most of the
> feedback I got was "how do I turn this off?" It is likely easier to
> drop the feature than figure out how to fix it for all cases.

I cannot judge this and I don't want to cause you headaches.

However I can tell you that code that is written with the native matlab
editor (say by my students) tend to have these enormous comment lines as
in the files


fill_prob2.m
fill_prob.m

So filling these lines would help me quite a bit and I thought emacs
users sharing code with those using the native editor might face similar
problems.


The thing that puzzles me:

in commit 0f305501f26d633048c83a89b6652db169394a3f
that line filling problems seemed to be solved

But in the last two commits it throws an error.

So what changed and can't we just go back?


> Basically, it isn't hard to create a line of code it can't fill, in
> which case it throws this error. Maybe a warning is better?

Yes I think so.

Uwe
--
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military.
I support the NATO membership of the Ukraine.
I support the EU membership of the Ukraine.
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/<https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view>