From: Uwe B. <ou...@ma...> - 2023-12-20 17:21:22
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > No no - it is indeed backward compatible. I tested it out with emacs > 28.1 also. font-lock-reference-face has been deprecated for a while > now. And font-lock-constant-face has been around since at least emacs > 20.3 (according to documentation). So the patch is backward > compatible. Ok thanks for checking. Are there any other comments, @Eric, @John? I'd prefer to wait a bit more till I push, I did not encounter any difficulties so far. But I only checked the part concerning the fonts, not TRAMP stuff. > On 12/20/23 17:18, Uwe Brauer wrote: >>>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: >>> Hello All, >>> I made a couple merge requests but Uwe told me that there are >>> apparently issues merging on sourceforge atm. Here are the links to >>> the two merge requests, just for reference: >>> + https://sourceforge.net/p/matlab-emacs/src/merge-requests/3/ >>> + https://sourceforge.net/p/matlab-emacs/src/merge-requests/4/ >>> The first one was a fix for the fact that emacs 29.1 has removed >>> font-lock-reference-face and we are to use font-lock-constant-face >>> instead. >> It seems to me that your patch is not backward compatible, so user of >> emacs <29 will run into difficulties, right? >> -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |