|
From: Uwe B. <ou...@ma...> - 2021-07-20 16:55:05
|
>>> "JC" == Julien Claisse <jul...@mo...> writes:
Hi Julien
> Hi Uwe,
> Sorry, this is my fault : this patch does not correct the fact that
> matlab-shell-save-and-go can work with scripts from anywhere. It only
> corrects that we can now run functions with 1 or more parameters.
I am terrible sorry for the delay, but until now I was very busy. So the first thing after my courses finished was to merge the hairybranch written by Eric into master.
Now concerning your example I can reproduce it, but it maybe because I used the merged version.
> Here is an example :
> 1 - Open matlab-shell
> 2 - mkdir test-matlab-shell-save-and-go/
> 3 - Create a new file test.m under this new directory :
> function test(p1)
> disp(['hello ' num2str(p1) '!'])
> 4 - Do a matlab-shell-save-and-go from this file.
When I do this I see in the minibuffer what you described in 7!!!
> 5 - Enter (5) in the minibuffer prompt and press enter
> 6 - Without the patch you get one error:
>>> run('/home/jc/test-matlab-shell-save-and-go/test')
> Not enough input arguments.
> Error in test (line 2)
> disp(['hello ' num2str(p1) '!'])
> Error in run (line 91)
> evalin('caller', strcat(script, ';'));
> 7 - Apply the patch, and do the same. It works :
>>> addpath('/home/jc/test-matlab-shell-save-and-go/')
>>> test(5)
> hello 5!
This is what I see. I don't recall having applied your patch, I searched the changelog and can't see anything. I also looked at your patch
,----
|
| + (let ((cmd (concat "addpath('" dir "')")))
| + (matlab-shell-send-command cmd))
| + (let ((cmd (concat fn-name param)))
| (matlab-shell-send-command cmd)))
`----
are not applied.
So may I ask you to pull the latest master and see whether you still run into a problem?
Thanks and regards
Uwe
|