Re: [Matlab-emacs-discuss] Bug in auto-filling strings

[Hunter M. <hun...@gm...>]

Hi Eric,

That fixed some of the errors, but I can still find bugs.  For example,
take the m-file:
foo = 'correct';
disp(['this is a ', foo, 'string']);

Put your cursor at the end of the 2nd line, change fill column to 18, and
put a space.  Mine results in:
foo = 'correct';
disp(['this is ' ...
      'a '], foo, 'string']);

which has an extra ] and is a syntax error.

This is definitely not an urgent issue, so take your time.  Let me know
what else I can do to help!  I really appreciate your code, and enjoy
contributing to good free software.

Thanks,
-Hunter

On Tue, Sep 23, 2014 at 9:47 AM, Eric Ludlam <Eri...@ma...>
wrote:

>  Hi Hunter,
>
>
>
> I made a small change to how strings are auto-filled that I think better
> covers several variants of pre-existing [] around the string.   I submitted
> the change to the CVS repository on sourceforge.  Could you try it out and
> let me know how it goes?
>
>
>
> Thanks
>
> Eric
>
>
>
> *From:* Hunter McClelland [mailto:hun...@gm...]
> *Sent:* Friday, September 19, 2014 12:08 PM
> *To:* mat...@li...
> *Subject:* [Matlab-emacs-discuss] Bug in auto-filling strings
>
>
>
> Hello developers,
>
>
> This is a bug report for matlab-mode (I hope this is the right place to
> submit these?)
>
> I'm using version 3.3.2
>
> When I'm editing a file in MATLAB mode, I found a bug in how the auto-fill
> works, an example is below.
>
> 0) open some m-file in matlab mode
>
> 1) set your fill column to 40 (c-x f 40)
>
> 2) create the line: "disp(['this is a , foo, ' string']);"
>
> 3) change fill column to 32 (c-x f 32)
>
> 4) put a space after the line, causing it to auto fill.  Mine now reads:
> disp(['This is a ', foo, [' ' ...
>                     'string']);
>
>
>
> The bug is that there are now two opening "[" but only one closing "]" and
> this is a syntax error.
>
> I can produce other similarly syntax errors auto-filling with different
> fill-columns, so something is buggy in how the auto-fill is working.
>
>
>
> I like MATLAB mode a lot, thank you for great software!
>
> -Hunter
>