From: Nidish N. B. <nid...@il...> - 2024-05-12 21:24:27
|
All, I've implemented some additional cell block behavior that makes using cells in matlab through emacs smoother. It's similar to the stock matlab GUI experience but better (IMO ;) ). I was wondering where I should apply my patches since I remember a lot of discussion on migrating to github. What's the current status on this? Shall I go ahead and make a merge request on Sourceforge itself? Thanks! Nidish |
From: Uwe B. <ou...@ma...> - 2024-05-13 07:30:52
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > All, > I've implemented some additional cell block behavior that makes using > cells in matlab through emacs smoother. It's similar to the stock > matlab GUI experience but better (IMO ;) ). I am not sure what the stock matlab GUI experience is, but I rarely use the GUI.... > I was wondering where I should apply my patches since I remember a lot > of discussion on migrating to github. What's the current status on > this? John hasn't answered yet. I will ping him again. > Shall I go ahead and make a merge request on Sourceforge itself? Or just sending the patch.[1] BTW, since you have contributed in the past: do you want write access so that you can push changes yourself? Thank you Uwe Footnotes: [1] did I mention that I am not a huge fan of merge requests 😇 -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
From: Uwe B. <ou...@ma...> - 2024-05-13 10:49:14
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > Here's a screenshot of how I have it setup now. The cells are > delimited by a string that defaults to a regexp that matches for > commented lines starting with "%%". It supports sending cells one by > one to the shell and provides some nifty navigation & moving utils. I > also have it setup so the current setup is bold-faced (see below). Ok, that sounds quite interesting, I use cells quite a bit myself > BTW, since you have contributed in the past: do you > want write access so that you can push changes yourself? > That would be nice! Let me ask also Eric and John, since I don't want to decide that myself, but I am pretty sure that they will be delighted to have another developer. > Thank you > Uwe > Footnotes: > [1] did I mention that I am not a huge fan of merge requests 😇 > Hehe, fair enough. I'll try to make a patch this weekend! :-D Great. Sorry for being so old fashioned. -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
From: Nidish N. B. <nid...@il...> - 2024-05-13 11:41:11
|
No worries - I look forward to hearing back. If I get push rights by the weekend, I'll push directly. If not, I'll make a patch and send it. I stand guilty of being called old-fashioned by colleagues too, so I do totally get it! ;-) Have a great week! Nidish On 5/13/24 12:49, Uwe Brauer wrote: >>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > >> Here's a screenshot of how I have it setup now. The cells are >> delimited by a string that defaults to a regexp that matches for >> commented lines starting with "%%". It supports sending cells one by >> one to the shell and provides some nifty navigation & moving utils. I >> also have it setup so the current setup is bold-faced (see below). > Ok, that sounds quite interesting, I use cells quite a bit myself > > >> BTW, since you have contributed in the past: do you >> want write access so that you can push changes yourself? > >> That would be nice! > Let me ask also Eric and John, since I don't want to decide that myself, > but I am pretty sure that they will be delighted to have another > developer. > > >> Thank you > >> Uwe >> Footnotes: >> [1] did I mention that I am not a huge fan of merge requests 😇 > >> Hehe, fair enough. I'll try to make a patch this weekend! :-D > Great. Sorry for being so old fashioned. > |
From: Uwe B. <ou...@ma...> - 2024-05-14 15:09:05
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > No worries - I look forward to hearing back. If I get push rights by > the weekend, I'll push directly. If not, I'll make a patch and send > it. Eric and John let me decide, (great). Since I am trying since for more than a year to get the package into ELPA, did you sign the FSF papers (I might have asked you that in the past, but, memory, you know)? If not are you willing to do so? -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
From: Nidish N. B. <nid...@il...> - 2024-05-14 15:11:58
|
Great! And yes, I had signed the FSF papers a while back. Best, Nidish On 5/14/24 17:08, Uwe Brauer wrote: >>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: >> No worries - I look forward to hearing back. If I get push rights by >> the weekend, I'll push directly. If not, I'll make a patch and send >> it. > Eric and John let me decide, (great). > > Since I am trying since for more than a year to get the package into > ELPA, did you sign the FSF papers (I might have asked you that in the > past, but, memory, you know)? If not are you willing to do so? > > |
From: Uwe B. <ou...@ma...> - 2024-05-14 15:40:19
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > Great! > And yes, I had signed the FSF papers a while back. Great, I would need your sourceforge userid. In case you don't have one, please open a sourceforge account. Uwe > Best, > Nidish > On 5/14/24 17:08, Uwe Brauer wrote: >>>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: >>> No worries - I look forward to hearing back. If I get push rights by >>> the weekend, I'll push directly. If not, I'll make a patch and send >>> it. >> Eric and John let me decide, (great). >> >> Since I am trying since for more than a year to get the package into >> ELPA, did you sign the FSF papers (I might have asked you that in the >> past, but, memory, you know)? If not are you willing to do so? >> >> -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
From: Nidish N. B. <nid...@il...> - 2024-05-14 17:23:24
|
On 5/14/24 17:39, Uwe Brauer wrote: >>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: >> Great! >> And yes, I had signed the FSF papers a while back. > > Great, I would need your sourceforge userid. > > In case you don't have one, please open a sourceforge account. Yes I do - my ID is: nidish96 > > Uwe >> Best, >> Nidish >> On 5/14/24 17:08, Uwe Brauer wrote: >>>>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: >>>> No worries - I look forward to hearing back. If I get push rights by >>>> the weekend, I'll push directly. If not, I'll make a patch and send >>>> it. >>> Eric and John let me decide, (great). >>> >>> Since I am trying since for more than a year to get the package into >>> ELPA, did you sign the FSF papers (I might have asked you that in the >>> past, but, memory, you know)? If not are you willing to do so? >>> >>> > |
From: Uwe B. <ou...@ma...> - 2024-05-14 17:38:12
Attachments:
smime.p7s
|
> On 5/14/24 17:39, Uwe Brauer wrote: > Yes I do - my ID is: nidish96 Ok, so you should have write access now. BTW, maybe it is better you create a branch for testing and then I (or you merge that later into master)? so that at least we can do some testing. -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
From: Nidish N. B. <nid...@il...> - 2024-05-14 17:45:04
|
On 5/14/24 19:37, Uwe Brauer wrote: >> On 5/14/24 17:39, Uwe Brauer wrote: >> Yes I do - my ID is: nidish96 > Ok, so you should have write access now. > > BTW, maybe it is better you create a branch for testing and then I (or > you merge that later into master)? > so that at least we can do some testing. Thank you! And yes, I agree - I'll create a testing branch for my latest edits and then you can test it out before merging! :) |
From: Nidish N. B. <nid...@il...> - 2024-05-14 20:13:53
|
Okay I've pushed the first version of the cell utils. This is the first time I'm making a substantial contribution to a package, so please forgive me if something I'm doing is not how you'd rather have it - happy to learn! :) A few pointers: * All the new contributions are in a new branch called "matlab-cells": https://sourceforge.net/p/matlab-emacs/src/ci/matlab-cells/tree/ * I've dumped all the code in matlab-cell.el and made it a minor-mode. All the new variables and functions are prefixed with "matlab-cell-" * The new minor-mode is enabled by default by calling its setup function in the define-derived-mode of matlab-mode in matlab.el * I see that matlab-cellbreak-face already exists so perhaps there's some duplication of efforts - it would make sense to remove redundancies. * A large portion of the code is based on another package, python-cell : https://github.com/twmr/python-cell.el The main features that the new minor-mode enables are: * It redefines the page-break character to "%%" so an overline is drawn over those, making it visually look better. * The current cell that point is in is highlighted by being boldfaced (this is customizable). * Convenience functions for moving point forward and backward by one cell (also support being called with prefix arguments). * Convenience functions for moving a cell up or down by a block (number-prefixes supported too). * Some more non-interactive convenience functions to help development. * I've not bound any of the functions to any keymap within the package yet. In my config though, these are the bindings I'm using (in case someone's interested): ("C-v" . 'matlab-cell-forward-cell) ("M-v" . 'matlab-cell-backward-cell) ("C-<return>" . matlab-shell-run-cell) ("C-c C-b" . (lambda () (interactive) (save-window-excursion (matlab-shell-run-cell)) (matlab-cell-forward-cell))) ("C-x n c" . 'matlab-cell-narrow-to-cell) ("M-[" . 'backward-paragraph) ("M-]" . 'forward-paragraph) ("C-c <down>" . 'matlab-cell-move-cell-down) ("C-c <up>" . 'matlab-cell-move-cell-up) I'll appreciate comments and suggestions! :) Best, Nidish On 5/14/24 19:44, Nidish Narayanaa Balaji wrote: > On 5/14/24 19:37, Uwe Brauer wrote: >>> On 5/14/24 17:39, Uwe Brauer wrote: >>> Yes I do - my ID is: nidish96 >> Ok, so you should have write access now. >> >> BTW, maybe it is better you create a branch for testing and then I (or >> you merge that later into master)? >> so that at least we can do some testing. > > Thank you! > > And yes, I agree - I'll create a testing branch for my latest edits > and then you can test it out before merging! :) > > > > _______________________________________________ > Matlab-emacs-discuss mailing list > Mat...@li... > https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss |