matlab-emacs-discuss

[Matlab-emacs-discuss] add-change-log-entry-other-window for matlab files

[Uwe B. <ou...@ma...>]

Hi

I use  add-change-log-entry-other-window a lot. 

The nice thing about elisp files is that you get entries like

	* matlab_init.el (my-matlab-shell-mode-hook): 296 

There is nothing similar for matlab. 

Does anybody have a hack for this feature?

Regards

Uwe 

Re: [Matlab-emacs-discuss] add-change-log-entry-other-window for matlab files

[Eric L. <eri...@gm...>]

Hiya,

matlab-mode has defined `add-log-current-defun-function' for a long time.

I'm using the hairyblocks branch, and tried the below command and it 
added the function name of a nested function to the record similar to below.

While the implementation of add-log-current-defun-function has changed 
in my branch, how add-log it is integrated with in matlab-mode hasn't 
really changed.

Eric

On 6/18/21 4:22 PM, Uwe Brauer wrote:
> Hi
>
> I use  add-change-log-entry-other-window a lot.
>
> The nice thing about elisp files is that you get entries like
>
> 	* matlab_init.el (my-matlab-shell-mode-hook): 296
>
> There is nothing similar for matlab.
>
> Does anybody have a hack for this feature?
>
> Regards
>
> Uwe
>
>
> _______________________________________________
> Matlab-emacs-discuss mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss

Re: [Matlab-emacs-discuss] add-change-log-entry-other-window for matlab files

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <eri...@gm...> writes:

Hi Eric,

Thanks for he quick reply
> Hiya,
> matlab-mode has defined `add-log-current-defun-function' for a long time.

You are right, I did not test this carefully enough.

However in lisp files, for examples defcustom is also recognised, so the
question is whether it would make sense to enhance the relevant  matlab functionality.

What I am thinking of is a good old script.

I see two candidates here

    1. A cell with a header

Like 
%% Test the implementation of Euler's method

    2. A direct execution of a function like 
[t,y] = ode45(f, intv, y0);


What do you think about it?

Regards

Uwe 

Re: [Matlab-emacs-discuss] add-change-log-entry-other-window for matlab files

[Eric L. <eri...@gm...>]

Sounds like a fine idea to me.  I posted a change to the hairyblocks 
branch that will use the function name, or text after the cell start as 
the 'defun' for add log.

The hairyblocks branch has been stable for a while with a lot of 
developers at MW using it.  It should be ready to merge into the main 
branch whenever you are ready for it.

Eric

On 6/20/21 2:46 AM, Uwe Brauer wrote:
>>>> "EL" == Eric Ludlam <eri...@gm...> writes:
> Hi Eric,
>
> Thanks for he quick reply
>> Hiya,
>> matlab-mode has defined `add-log-current-defun-function' for a long time.
> You are right, I did not test this carefully enough.
>
> However in lisp files, for examples defcustom is also recognised, so the
> question is whether it would make sense to enhance the relevant  matlab functionality.
>
> What I am thinking of is a good old script.
>
> I see two candidates here
>
>      1. A cell with a header
>
> Like
> %% Test the implementation of Euler's method
>
>      2. A direct execution of a function like
> [t,y] = ode45(f, intv, y0);
>
>
> What do you think about it?
>
> Regards
>
> Uwe

Re: [Matlab-emacs-discuss] add-change-log-entry-other-window for matlab files

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <eri...@gm...> writes:

> Sounds like a fine idea to me.  I posted a change to the hairyblocks
> branch that will use the function name, or text after the cell start
> as the 'defun' for add log.


Great I just saw it, thanks!


> The hairyblocks branch has been stable for a while with a lot of
> developers at MW using it.  It should be ready to merge into the main
> branch whenever you are ready for it.

Right, let me just pull, compile, and test it this afternoon. Then I
will merge and push.

[Matlab-emacs-discuss] [a problem in the branch: the return key] (was: add-change-log-entry-other-window for matlab files)

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <eri...@gm...> writes:


> Sounds like a fine idea to me.  I posted a change to the hairyblocks
> branch that will use the function name, or text after the cell start
> as the 'defun' for add log.

> The hairyblocks branch has been stable for a while with a lot of
> developers at MW using it.  It should be ready to merge into the main
> branch whenever you are ready for it.



I am just running into a problem with the hairyblocks branch.

I want to insert an empty line, in a matlab.m file hitting 
the return key, but I receive the following error 

,----
| Debugger entered--Lisp error: (void-function matlab-return)
|   signal(void-function (matlab-return))
|   help-fns--analyze-function(matlab-return)
|   help-fns-function-description-header(matlab-return)
|   describe-function-1(matlab-return)
|   describe-key((([return] . [return])))
|   funcall-interactively(describe-key (([return] . [return])))
|   call-interactively(describe-key nil nil)
|   command-execute(describe-key)
`----

Indeed my personal binding had (I don't know for how long)
  (local-set-key [return]  'matlab-return) 


Eyeballing the changelog, I find 
  Remove matlab-comment-indent as a setting (use nil)
│  (matlab-return-function, matlab-return, matlab-plain-ret)
│  (matlab-indent-after-ret, matlab-indent-end-before-ret)
│  (matlab-semicolon-on-return, matlab-indent-before-ret)
│  (matlab-linefeed):

Which I interpret that you removed matlab-return.

So I suggest that before I merge that branch into master, we had into
the NEWS file and entry were we tell which functions have been removed
in order to avoid users complains.

What do you think?

Uwe 

Re: [Matlab-emacs-discuss] [a problem in the branch: the return key] (was: add-change-log-entry-other-window for matlab files)

[Eric L. <eri...@gm...>]

Hi Uwe,

Yes, that makes sense.  But also reminds me that way more than that should
be in the news file.  Matlab mode used to do a lot of stuff that now has
native support in emacs which changes how to configure things.  Sadly I
didn't think to build a news like file for them other than all the check-in
logs.  I could work on that but it will be a day or two as I'm doing family
stuff this week.

Some of the summary of changes is in an email I put together a month or so
ago, but not at the right detail level.

Eric

On Sun, Jun 20, 2021, 9:06 AM Uwe Brauer <ou...@ma...> wrote:

> >>> "EL" == Eric Ludlam <eri...@gm...> writes:
>
>
> > Sounds like a fine idea to me.  I posted a change to the hairyblocks
> > branch that will use the function name, or text after the cell start
> > as the 'defun' for add log.
>
> > The hairyblocks branch has been stable for a while with a lot of
> > developers at MW using it.  It should be ready to merge into the main
> > branch whenever you are ready for it.
>
>
>
> I am just running into a problem with the hairyblocks branch.
>
> I want to insert an empty line, in a matlab.m file hitting
> the return key, but I receive the following error
>
> ,----
> | Debugger entered--Lisp error: (void-function matlab-return)
> |   signal(void-function (matlab-return))
> |   help-fns--analyze-function(matlab-return)
> |   help-fns-function-description-header(matlab-return)
> |   describe-function-1(matlab-return)
> |   describe-key((([return] . [return])))
> |   funcall-interactively(describe-key (([return] . [return])))
> |   call-interactively(describe-key nil nil)
> |   command-execute(describe-key)
> `----
>
> Indeed my personal binding had (I don't know for how long)
>   (local-set-key [return]  'matlab-return)
>
>
> Eyeballing the changelog, I find
>   Remove matlab-comment-indent as a setting (use nil)
> │  (matlab-return-function, matlab-return, matlab-plain-ret)
> │  (matlab-indent-after-ret, matlab-indent-end-before-ret)
> │  (matlab-semicolon-on-return, matlab-indent-before-ret)
> │  (matlab-linefeed):
>
> Which I interpret that you removed matlab-return.
>
> So I suggest that before I merge that branch into master, we had into
> the NEWS file and entry were we tell which functions have been removed
> in order to avoid users complains.
>
> What do you think?
>
> Uwe
>
>

Re: [Matlab-emacs-discuss] [a problem in the branch: the return key]

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <eri...@gm...> writes:

> Hi Uwe,
> Yes, that makes sense.  But also reminds me that way more than that should
> be in the news file.  Matlab mode used to do a lot of stuff that now has
> native support in emacs which changes how to configure things.  Sadly I
> didn't think to build a news like file for them other than all the check-in
> logs.  I could work on that but it will be a day or two as I'm doing family
> stuff this week.

Sure no hurry. I am occupied with family business as well. ;-)

Re: [Matlab-emacs-discuss] [a problem in the branch: the return key]

[Eric L. <eri...@gm...>]

Hi Uwe,

I updated the NEWS file, and submitted the change to the hairyblocks branch.

Eric

On Sun, Jun 20, 2021 at 11:27 AM Uwe Brauer <ou...@ma...> wrote:

> >>> "EL" == Eric Ludlam <eri...@gm...> writes:
>
> > Hi Uwe,
> > Yes, that makes sense.  But also reminds me that way more than that
> should
> > be in the news file.  Matlab mode used to do a lot of stuff that now has
> > native support in emacs which changes how to configure things.  Sadly I
> > didn't think to build a news like file for them other than all the
> check-in
> > logs.  I could work on that but it will be a day or two as I'm doing
> family
> > stuff this week.
>
> Sure no hurry. I am occupied with family business as well. ;-)
>

Re: [Matlab-emacs-discuss] [a problem in the branch: the return key]

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <eri...@gm...> writes:

> Hi Uwe,
> I updated the NEWS file, and submitted the change to the hairyblocks branch.

Great I could then merge into master and also include the two patches,
one by Julien Claisse the  other by  Karthik Chikmagalur. However I will
be very very busy the next week till Sunday. So I prefer to do this next
weekend just in case that there are complications.

I hope that is ok with you

Uwe  

Re: [Matlab-emacs-discuss] [a problem in the branch: the return key]

[Eric L. <eri...@gm...>]

Sounds good.  Thanks Uwe!

On Sun, Jul 11, 2021 at 3:02 PM Uwe Brauer <ou...@ma...> wrote:

> >>> "EL" == Eric Ludlam <eri...@gm...> writes:
>
> > Hi Uwe,
> > I updated the NEWS file, and submitted the change to the hairyblocks
> branch.
>
> Great I could then merge into master and also include the two patches,
> one by Julien Claisse the  other by  Karthik Chikmagalur. However I will
> be very very busy the next week till Sunday. So I prefer to do this next
> weekend just in case that there are complications.
>
> I hope that is ok with you
>
> Uwe
>