Menu
▾
▴
matlab-emacs-discuss
|
From: Uwe B. <ou...@ma...> - 2024-12-05 17:54:33
Attachments:
smime.p7s
|
Hi
I am currently dealing to get matlab-mode into ELPA. I will also open an issue in github (not sure what is better for most of you
The ELPA maintainer, told me
1. Why do we have still the function matlab-show-version
2. And matlab-version as a defconst
3. And where to put the defconst in matlab.el or in matlab-mode.el The MELPA maintainer recommended the introduction of this file.
I will also write him
Uwe
--
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military.
I support the EU and NATO membership of Ukraine.
|
|
From: Eric L. <el...@ma...> - 2024-12-05 18:54:55
|
The command matlab-show-version was always there since before I adopted matlab-mode. I'm not attached to it and would not mind if it were removed.
For matlab-version, do you mean matlab-mode-version? As for why defconst, seems reasonable to me since it's a constant. 😊
Eric
-----Original Message-----
From: Uwe Brauer <ou...@ma...>
Sent: Thursday, December 5, 2024 12:54 PM
To: mat...@li...
Cc: Eric Ludlam <el...@ma...>; John Ciolfi <ci...@ma...>
Subject: matlab-version/matlab-show-version
Hi
I am currently dealing to get matlab-mode into ELPA. I will also open an issue in github (not sure what is better for most of you
The ELPA maintainer, told me
1. Why do we have still the function matlab-show-version
2. And matlab-version as a defconst
3. And where to put the defconst in matlab.el or in matlab-mode.el The MELPA maintainer recommended the introduction of this file.
I will also write him
Uwe
--
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military.
I support the EU and NATO membership of Ukraine.
|
|
From: Uwe B. <ou...@ma...> - 2024-12-05 18:57:44
Attachments:
smime.p7s
|
>>> "EL" == Eric Ludlam <el...@ma...> writes: > The command matlab-show-version was always there since before I > adopted matlab-mode. I'm not attached to it and would not mind if it > were removed. According to git blame or mercurial annotate, you are the author 😉 (however this functionality is not very reliable, since any chance in the indent etc, is registered. Ok I remove it then > For matlab-version, do you mean matlab-mode-version? As for why > defconst, seems reasonable to me since it's a constant. 😊 Yep, matlab-mode-version. -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
|
From: Eric L. <el...@ma...> - 2024-12-05 19:02:41
|
>From: Uwe Brauer <ou...@ma...> >>>> "EL" == Eric Ludlam <el...@ma...> writes: >> The command matlab-show-version was always there since before I >> adopted matlab-mode. I'm not attached to it and would not mind if it >> were removed. > According to git blame or mercurial annotate, you are the author 😉 > (however this functionality is not very reliable, since any chance in > the indent etc, is registered. Makes sense - Matt emailed me the file, and I put it into version control. I think it was RCS at the time. 😊 Eric |
|
From: Uwe B. <ou...@ma...> - 2024-12-07 07:31:39
Attachments:
smime.p7s
|
> Makes sense - Matt emailed me the file, and I put it into version control. I think it was RCS at the time. 😊 I just checked, matlab-shell uses matlab-show-version So the question is do we want to keep it, maybe people want to see the matlab-show-version when calling matlab-shell? I will move the function back for the moment till the issue is settled because otherwise the test fails and matlab-mode cannot be compiled > Eric -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
|
From: Uwe B. <ou...@ma...> - 2024-12-07 07:40:13
Attachments:
smime.p7s
|
>>> "EL" == Eric Ludlam <el...@ma...> writes: >> From: Uwe Brauer <ou...@ma...> >>>>> "EL" == Eric Ludlam <el...@ma...> writes: >>> The command matlab-show-version was always there since before I >>> adopted matlab-mode. I'm not attached to it and would not mind if it >>> were removed. >> According to git blame or mercurial annotate, you are the author 😉 >> (however this functionality is not very reliable, since any chance in >> the indent etc, is registered. > Makes sense - Matt emailed me the file, and I put it into version control. I think it was RCS at the time. 😊 I had to revert to commit b2baf6b106587480 causes problems with matlab-shell. I now understand why this function was added, it displays the matlab-mode version when the shell is called. However there is a byte compiler warning with this function namely In matlab-show-version: matlab.el:1473:38: Warning: reference to free variable ‘matlab-mode-version’ Which was pointed out to me by the ELPA and MELPA maintainers. What shall we do, any thought? -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
|
From: Eric L. <el...@ma...> - 2024-12-09 14:11:47
|
It's probably fine to not print the version number when matlab-shell starts. I don't think any other shell fcns print their version number. A holdover from a different age. Eric -----Original Message----- From: Uwe Brauer <ou...@ma...> Sent: Saturday, December 7, 2024 2:40 AM To: Eric Ludlam <el...@ma...> Cc: Uwe Brauer <ou...@ma...>; mat...@li...; John Ciolfi <ci...@ma...> Subject: Re: matlab-version/matlab-show-version >>> "EL" == Eric Ludlam <el...@ma...> writes: >> From: Uwe Brauer <ou...@ma...> >>>>> "EL" == Eric Ludlam <el...@ma...> writes: >>> The command matlab-show-version was always there since before I >>> adopted matlab-mode. I'm not attached to it and would not mind if it >>> were removed. >> According to git blame or mercurial annotate, you are the author 😉 >> (however this functionality is not very reliable, since any chance in >> the indent etc, is registered. > Makes sense - Matt emailed me the file, and I put it into version control. I think it was RCS at the time. 😊 I had to revert to commit b2baf6b106587480 causes problems with matlab-shell. I now understand why this function was added, it displays the matlab-mode version when the shell is called. However there is a byte compiler warning with this function namely In matlab-show-version: matlab.el:1473:38: Warning: reference to free variable ‘matlab-mode-version’ Which was pointed out to me by the ELPA and MELPA maintainers. What shall we do, any thought? -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X