matlab-emacs-discuss

[Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

Hi 

Given the following example


        while diff > TOL && k <= nmax                             % por una parte se condiciona al while con un valor de tolerancia para el error diff, error de una iteración de la iteración simple, y, por otra parte, se toma un numero máximo de iteraciones porque puede perfectamente el error de iteración no ser menor que la tolerancia, provocando un bucle infinito     


matlab-fill-region returns the following errors

Who wrote this filling algorithm? According to git-hg blame, it was Eric
and the code is well quite old.

I have no idea how to debug this.

Any comments?

Regards

Uwe 

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[John C. <ci...@ma...>]

Hi Uwe,

Eric fixed the issue, see attached patches which apply against the current source forge tip, 3048e9. I also tested it and have deployed it internally within MathWorks. Can you try the patches and if they are good, update source forge?

Thanks,
John
________________________________
From: Uwe Brauer <ou...@ma...>
Sent: Tuesday, April 25, 2023 5:53 AM
To: mat...@li... <mat...@li...>
Subject: [Matlab-emacs-discuss] another bug with the filling alorithm



Hi

Given the following example


while diff > TOL && k <= nmax % por una parte se condiciona al while con un valor de tolerancia para el error diff, error de una iteración de la iteración simple, y, por otra parte, se toma un numero máximo de iteraciones porque puede perfectamente el error de iteración no ser menor que la tolerancia, provocando un bucle infinito


matlab-fill-region returns the following errors

Who wrote this filling algorithm? According to git-hg blame, it was Eric
and the code is well quite old.

I have no idea how to debug this.

Any comments?

Regards

Uwe

--
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military.
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/<https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view>

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

>>> "JC" == John Ciolfi <ci...@ma...> writes:
Hi John, Hi Eric
> Hi Uwe,
> Eric fixed the issue, see attached patches which apply against the
> current source forge tip, 3048e9. 

Thanks very much, especially Eric for the fix 😉, that is very much
appreciated from my side, since a bunch of matlab exams are waiting to
be corrected.


> I also tested it and have deployed
> it internally within MathWorks. Can you try the patches and if they
> are good, update source forge?


I try to test this as soon as possible, hopefully this evening. 

Maybe in two weeks I got also start the move to github (and renaming
master to default), right now, I am a bit to busy for this (exam period
started and *now* students are starting to study).


Uwe 


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <el...@ma...> writes:

> I think you are correct that it isn’t quite right, but I understand why.  I get the column to indent the following lines under and set the fill prefix before handing it over to the built in fill-paragraph code.  Fill paragraph then moves the comment inward, but the fill prefix has already been defined.
> Do you think it should leave the original comment column alone?  That’s my guess.

I think what I posted seems to be one possibility


I tried just to run 
matlab-indent-region 
on 
#+begin_src 
    ev = 0; % el número de evaluaciones al inicio es cero, pues no ha
                                                                  % habido
                                                                  % ninguna
                                                                  % iteración
#+end_src

and I obtained an error I attach, something is not right here


> The comment specific part of matlab-fill-paragraph has a couple
> dubious things it’s doing that I’ll need to better understand to see
> if they are supporting some sort of edge cases. My intuition is that
> chunks of that code can be replaced with ‘fill-region’ instead of what
> it’s doing now but my first cut did something surprising instead.

> I’ll poke at it a little bit, but in theory I’m on vacation this week, so we’ll see.


Oops, by all means that is not urgent, enjoy your holidays...



-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/