Menu
▾
▴
matlab-emacs-discuss
|
From: Nidish N. B. <nid...@il...> - 2023-12-19 16:56:50
Attachments:
mypatch.patch
|
Hello All, I made a couple merge requests but Uwe told me that there are apparently issues merging on sourceforge atm. Here are the links to the two merge requests, just for reference: + https://sourceforge.net/p/matlab-emacs/src/merge-requests/3/ + https://sourceforge.net/p/matlab-emacs/src/merge-requests/4/ The first one was a fix for the fact that emacs 29.1 has removed font-lock-reference-face and we are to use font-lock-constant-face instead. The second is a small fix I had to do to let me work with matlab-shell over a TRAMP session. The issue was that it was initially calling emacsinit.m addressed to the local machine, which matlab of course can't find. I just changed "/home/<user-login-name>/" to "~/" in the command and it reads the right emacsinit file. This still requires that matlab-mode and emacs be installed in the exact same location on the remote machine as on the local machine. It's not ideal, but it serves my purposes for now. I'm sending a single patch file for both the merge requests here. Best, Nidish -- Dr. Nidish Narayanaa Balaji Humboldt Postdoctoral Fellow Institute of Aircraft Propulsion Systems Department of Aerospace Engineering and Geodesy University of Stuttgart Pfaffenwaldring 6 D-70569 Stuttgart Tel.: +49 711 685 69433 e-mail: nid...@il... |
|
From: Uwe B. <ou...@ma...> - 2023-12-19 17:13:04
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: Hello Nidish > Hello All, > I made a couple merge requests but Uwe told me that there are > apparently issues merging on sourceforge atm. Here are the links to > the two merge requests, just for reference: > + https://sourceforge.net/p/matlab-emacs/src/merge-requests/3/ > + https://sourceforge.net/p/matlab-emacs/src/merge-requests/4/ > The first one was a fix for the fact that emacs 29.1 has removed > font-lock-reference-face and we are to use font-lock-constant-face > instead. > The second is a small fix I had to do to let me work with matlab-shell > over a TRAMP session. The issue was that it was initially calling > emacsinit.m addressed to the local machine, which matlab of course > can't find. I just changed "/home/<user-login-name>/" to "~/" in the > command and it reads the right emacsinit file. This still requires > that matlab-mode and emacs be installed in the exact same location on > the remote machine as on the local machine. It's not ideal, but it > serves my purposes for now. Thanks, I had no problem applying your patch to commit b49c86e5738f. I would like to test in the coming days, especially the font locking, since I don't use TRAMP. Do others, @Eric, @John have remarks to make? Thanks and regards Uwe -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
|
From: Uwe B. <ou...@ma...> - 2023-12-20 16:19:04
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > Hello All, > I made a couple merge requests but Uwe told me that there are > apparently issues merging on sourceforge atm. Here are the links to > the two merge requests, just for reference: > + https://sourceforge.net/p/matlab-emacs/src/merge-requests/3/ > + https://sourceforge.net/p/matlab-emacs/src/merge-requests/4/ > The first one was a fix for the fact that emacs 29.1 has removed > font-lock-reference-face and we are to use font-lock-constant-face > instead. It seems to me that your patch is not backward compatible, so user of emacs <29 will run into difficulties, right? -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
|
From: Nidish N. B. <nid...@il...> - 2023-12-20 16:30:05
|
No no - it is indeed backward compatible. I tested it out with emacs 28.1 also. font-lock-reference-face has been deprecated for a while now. And font-lock-constant-face has been around since at least emacs 20.3 (according to documentation). So the patch is backward compatible. On 12/20/23 17:18, Uwe Brauer wrote: >>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: >> Hello All, >> I made a couple merge requests but Uwe told me that there are >> apparently issues merging on sourceforge atm. Here are the links to >> the two merge requests, just for reference: >> + https://sourceforge.net/p/matlab-emacs/src/merge-requests/3/ >> + https://sourceforge.net/p/matlab-emacs/src/merge-requests/4/ >> The first one was a fix for the fact that emacs 29.1 has removed >> font-lock-reference-face and we are to use font-lock-constant-face >> instead. > It seems to me that your patch is not backward compatible, so user of > emacs <29 will run into difficulties, right? > -- Dr. Nidish Narayanaa Balaji Humboldt Postdoctoral Fellow Institute of Aircraft Propulsion Systems Department of Aerospace Engineering and Geodesy University of Stuttgart Pfaffenwaldring 6 D-70569 Stuttgart Tel.: +49 711 685 69433 e-mail: nid...@il... |
|
From: Uwe B. <ou...@ma...> - 2023-12-20 17:21:22
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: > No no - it is indeed backward compatible. I tested it out with emacs > 28.1 also. font-lock-reference-face has been deprecated for a while > now. And font-lock-constant-face has been around since at least emacs > 20.3 (according to documentation). So the patch is backward > compatible. Ok thanks for checking. Are there any other comments, @Eric, @John? I'd prefer to wait a bit more till I push, I did not encounter any difficulties so far. But I only checked the part concerning the fonts, not TRAMP stuff. > On 12/20/23 17:18, Uwe Brauer wrote: >>>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: >>> Hello All, >>> I made a couple merge requests but Uwe told me that there are >>> apparently issues merging on sourceforge atm. Here are the links to >>> the two merge requests, just for reference: >>> + https://sourceforge.net/p/matlab-emacs/src/merge-requests/3/ >>> + https://sourceforge.net/p/matlab-emacs/src/merge-requests/4/ >>> The first one was a fix for the fact that emacs 29.1 has removed >>> font-lock-reference-face and we are to use font-lock-constant-face >>> instead. >> It seems to me that your patch is not backward compatible, so user of >> emacs <29 will run into difficulties, right? >> -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
|
From: Nidish N. B. <nid...@il...> - 2023-12-20 17:29:51
|
In case this helps, here's a quick way to check the tramp stuff if you
have a second machine with MATLAB. I'll refer to the primary machine as
the local machine and the secondary machine as the remote machine in the
following.
1. Install emacs on the remote machine. Install matlab-mode on it also
(ensure it is the same version as on the local machine).
2. Apply the patch on the installed matlab-mode on both the local &
remote machines.
3. Ensure ssh server is running on the remote machine and is
discoverable from the local machine.
4. Open a matlab file on the remote machine from an emacs session on
the local machine through TRAMP.
5. Write some matlab code on the buffer.
6. Invoke matlab-shell from the tramp-buffer.
7. Check if matlab-shell-run-cell works.
8. Check, from the MATLAB REPL, which device it is running on. It
should be running on the remote machine.
On 12/20/23 18:21, Uwe Brauer wrote:
>>>> "NNB" == Nidish Narayanaa Balaji<nid...@il...> writes:
>> No no - it is indeed backward compatible. I tested it out with emacs
>> 28.1 also. font-lock-reference-face has been deprecated for a while
>> now. And font-lock-constant-face has been around since at least emacs
>> 20.3 (according to documentation). So the patch is backward
>> compatible.
> Ok thanks for checking.
>
>
> Are there any other comments, @Eric, @John?
>
> I'd prefer to wait a bit more till I push, I did not encounter any difficulties so far.
> But I only checked the part concerning the fonts, not TRAMP stuff.
>
>> On 12/20/23 17:18, Uwe Brauer wrote:
>>>>>> "NNB" == Nidish Narayanaa Balaji<nid...@il...> writes:
>>>> Hello All,
>>>> I made a couple merge requests but Uwe told me that there are
>>>> apparently issues merging on sourceforge atm. Here are the links to
>>>> the two merge requests, just for reference:
>>>> +https://sourceforge.net/p/matlab-emacs/src/merge-requests/3/
>>>> +https://sourceforge.net/p/matlab-emacs/src/merge-requests/4/
>>>> The first one was a fix for the fact that emacs 29.1 has removed
>>>> font-lock-reference-face and we are to use font-lock-constant-face
>>>> instead.
>>> It seems to me that your patch is not backward compatible, so user of
>>> emacs <29 will run into difficulties, right?
>>>
--
Dr. Nidish Narayanaa Balaji
Humboldt Postdoctoral Fellow
Institute of Aircraft Propulsion Systems
Department of Aerospace Engineering and Geodesy
University of Stuttgart
Pfaffenwaldring 6
D-70569 Stuttgart
Tel.: +49 711 685 69433
e-mail:nid...@il...
|
|
From: Uwe B. <ou...@ma...> - 2023-12-27 16:32:18
Attachments:
smime.p7s
|
>>> "NNB" == Nidish Narayanaa Balaji <nid...@il...> writes: Hi Nidish, > In case this helps, here's a quick way to check the tramp stuff if you > have a second machine with MATLAB. I'll refer to the primary machine > as the local machine and the secondary machine as the remote machine > in the following. Sorry for not having responded earlier (the holidays...) > 1. Install emacs on the remote machine. Install matlab-mode on it also > (ensure it is the same version as on the local machine). > 2. Apply the patch on the installed matlab-mode on both the local & > remote machines. > 3. Ensure ssh server is running on the remote machine and is > discoverable from the local machine. > 4. Open a matlab file on the remote machine from an emacs session on > the local machine through TRAMP. > 5. Write some matlab code on the buffer. > 6. Invoke matlab-shell from the tramp-buffer. > 7. Check if matlab-shell-run-cell works. > 8. Check, from the MATLAB REPL, which device it is running on. It > should be running on the remote machine. Thanks for these details instructions. Though I do posses another machine, a MaC, I haven't had the time to set all this up, and I am not sure that I will have the time in the coming days. However, finally, I found out at least how to access the merge request on sourceforge, although I don't want to use their webinterface for merging merge requests, I prefer to pull (clone), check, and then move the commits on the main repository (and merge it there to master). So I think I will do that with our two requests (I will then also create two branches.). So far nobody seemed to have applied these patch(es) so maybe this way somebody feel inclined. However, before doing this I need to know: did you sign the FSF papers, and would you be willing to do so. The reason is, we want to move matlab-emacs-mode to ELPA (I have started the process twice, only one signature is missing, which reminds me to contact that person again). So please tell me whether you would be willing to do so. Another remark: An additional goal is to move or at least to mirror the repository to github since that might attract more people that feel more comfortable or acquainted with github (however I still would prefer to use the mailing list as the main communication channel, the github issues, for me are far inferior. I hope to do this still in 2023. And last but not least, I also plan to rename the main development branch: «master»--> «default». The reason has nothing to do with political issues, I am a mercurial user who access the git repositories via the hg-git plugin. In mercurial the main branch (which is technical a different beast than a git branch) is always called default and having the same name in git, could somehow simplify things for me. Kind regards Uwe -- I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel I strongly condemn Putin's war of aggression against Ukraine. I support to deliver weapons to Ukraine's military. I support the EU and NATO membership of Ukraine. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X