matlab-emacs-discuss

[Matlab-emacs-discuss] compiler warnings

[John C. <Joh...@ma...>]

I just updated to the latest matlab emacs and see a few warnings. I realize some of these are to support older emacs's but some look like they could be fixed (and maybe suppress the others for older releases)? I'm building on Debian 8 using emacs 24.4.1


Thanks

John


In matlab-with-emacs-link:
matlab.el:119:8:Warning: reference to free variable `matlab-use-eei'
matlab.el:120:8:Warning: reference to free variable `matlab-eei-process'

In matlab-do-functions-have-end-p:
matlab.el:213:28:Warning: reference to free variable `matlab-defun-regex'

In matlab-font-lock-adjustments:
matlab.el:522:28:Warning: `set-face-underline-p' is an obsolete function (as
    of 24.3); use `set-face-underline' instead.
matlab.el:535:13:Warning: `set-face-underline-p' is an obsolete function (as
    of 24.3); use `set-face-underline' instead.
matlab.el:548:13:Warning: `set-face-bold-p' is an obsolete function (as of
    24.4); use `set-face-bold' instead.
matlab.el:548:24:Warning: `set-face-bold-p' is an obsolete function (as of
    24.4); use `set-face-bold' instead.

In matlab-mode:
matlab.el:1180:21:Warning: `default-fill-column' is an obsolete variable (as
    of 23.2); use `fill-column' instead.
matlab.el:1238:31:Warning: reference to free variable `matlab-defun-regex'

In matlab-semicolon-on-return:
matlab.el:2654:35:Warning: reference to free variable
    `matlab-quiesce-nosemi-regexp'

In matlab-mode-verify-fix-file:
matlab.el:3872:24:Warning: `interactive-p' is an obsolete function (as of
    23.2); use `called-interactively-p' instead.

In matlab-shell-active-p:
matlab.el:4271:31:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer

In matlab-shell-mode:
matlab.el:4476:9:Warning: assignment to free variable
    `matlab-shell-last-error-anchor'

In matlab-shell-previous-matching-input-from-input:
matlab.el:4869:51:Warning: `previous-line' is for interactive use only; use
    `forward-line' with negative argument instead.

In matlab-shell-tab:
matlab.el:5036:24:Warning: display-completion-list called with 2 arguments,
    but accepts only 1

In matlab-output-to-temp-buffer:
matlab.el:5277:56:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer

In matlab-shell-collect-command-output:
matlab.el:5357:19:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer

In matlab-find-other-window-file-line-column:
matlab.el:5445:27:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.

In matlab-shell-help-mode:
matlab.el:5611:18:Warning: reference to free variable
    `matlab-shell-help-mode-menu'

In matlab-shell-topic-mode:
matlab.el:5650:13:Warning: assignment to free variable `mode-motion-hook'
matlab.el:5651:18:Warning: reference to free variable
    `matlab-shell-topic-mode-menu'

In matlab-shell-topic-browser-create-contents:
matlab.el:5663:52:Warning: `toggle-read-only' is an obsolete function (as of
    24.3); use `read-only-mode' instead.
matlab.el:5673:8:Warning: `toggle-read-only' is an obsolete function (as of
    24.3); use `read-only-mode' instead.

In matlab-shell-topic-highlight-line:
matlab.el:5735:37:Warning: reference to free variable `mouse-grabbed-buffer'
matlab.el:5748:41:Warning: reference to free variable `mode-motion-extent'

In end of data:
matlab.el:5867:1:Warning: the following functions might not be defined at
    runtime: comint-check-proc, comint-mode, gud-mode, gud-set-buffer,
    gud-call, comint-after-pmark-p, comint-next-matching-input-from-input,
    ring-empty-p, ring-ref, ring-insert, comint-simple-send,
    comint-send-string, gud-display-frame
matlab.el:5867:1:Warning: the following functions are not known to be defined:
    extent-list, start-itimer, matlab-overlays-at, matlab-overlay-get,
    matlab-overlay-start, matlab-overlay-end, matlab-next-overlay-change,
    mlint-minor-mode, matlab-point-at-eol, matlab-point-at-bol,
    matlab-delete-overlay, matlab-cancel-timer, matlab-run-with-idle-timer,
    matlab-make-overlay, matlab-overlay-put, mlint-buffer,
    mlint-clear-warnings, mlint-clear-cross-function-variable-highlighting,
    set-extent-begin-glyph, make-extent, make-glyph, matlab-eei-run,
    matlab-eei-eval-region, matlab-previous-overlay-change, view-major-mode,
    event-buffer, event-point, mode-motion-ensure-extent-ok, detach-extent,
    set-extent-endpoints
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/matlab.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile mlint.el

In mlint-reset-program:
mlint.el:98:20:Warning: reference to free variable `mlint-programs'

In mlint-column-output:
mlint.el:168:51:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:169:46:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:170:46:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.

In mlint-run:
mlint.el:214:19:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer
mlint.el:258:41:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:217:51:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:240:31:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:225:52:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:232:55:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:227:56:Warning: `string-to-int' is an obsolete function (as of 22.1);
    use `string-to-number' instead.
mlint.el:250:37:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.
mlint.el:262:27:Warning: (lambda (x) ...) quoted with ' rather than with #'

In mlint-linemark-create-group:
mlint.el:321:20:Warning: `object-name-string' is an obsolete function (as of
    24.4); use `eieio-object-name-string' instead.
mlint.el:388:54:Warning: reference to free variable `mlint-overlay-map'
mlint.el:410:59:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer
mlint.el:450:22:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.
mlint.el:514:22:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.
mlint.el:532:22:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.

In mlint-clear-warnings:
mlint.el:579:4:Warning: `mapcar' called for effect; use `mapc' or `dolist'
    instead

In mlint-next-buffer:
mlint.el:626:33:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.

In mlint-prev-buffer:
mlint.el:635:33:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.

In mlint-next-buffer-new:
mlint.el:652:33:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.
mlint.el:652:31:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.

In mlint-prev-buffer-new:
mlint.el:668:33:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.
mlint.el:668:31:Warning: `goto-line' is for interactive use only; use
    `forward-line' instead.

In mlint-ediff-cleanup-hook:
mlint.el:824:20:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer
mlint.el:828:26:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/mlint.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile tlc.el

In tlc-mode:
tlc.el:141:21:Warning: `make-variable-buffer-local' not called at toplevel
tlc.el:151:9:Warning: `make-variable-buffer-local' not called at toplevel

In tlc-calc-next-indentation:
tlc.el:245:17:Warning: assignment to free variable
    `indent-because-of-continuation'
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/tlc.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile matlab-publish.el

In matlab-insert-title:
matlab-publish.el:174:4:Warning: `beginning-of-buffer' is for interactive use
    only; use `(goto-char (point-min))' instead.
matlab-publish.el:175:24:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.

In matlab-insert-section:
matlab-publish.el:181:4:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.

In matlab-insert-description-text:
matlab-publish.el:188:4:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.

In matlab-insert-bold-text:
matlab-publish.el:213:4:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.

In matlab-insert-monospaces-text:
matlab-publish.el:220:4:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.

In matlab-insert-preformated-text:
matlab-publish.el:228:4:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.

In matlab-insert-equation:
matlab-publish.el:238:4:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.

In matlab-insert-bullet-list:
matlab-publish.el:248:4:Warning: `previous-line' is for interactive use only;
    use `forward-line' with negative argument instead.
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/matlab-publish.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile linemark.el

In linemark-new-group:
linemark.el:185:50:Warning: `object-name-string' is an obsolete function (as
    of 24.4); use `eieio-object-name-string' instead.
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/linemark.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile semantic-matlab.el
semanticdb-matlab.el: (lambda (x) ...) quoted with ' rather than with #'
semanticdb-matlab.el: (lambda (x) ...) quoted with ' rather than with #'

In toplevel form:
semantic-matlab.el:518:20:Warning: assignment to free variable
    `semantic-idle-summary-function'

In semantic-default-matlab-setup:
semantic-matlab.el:612:9:Warning: assignment to free variable
    `semantic-imenu-bucketize-type-members'

In end of data:
semantic-matlab.el:621:1:Warning: the function `fame-message-nolog' is not
    known to be defined.
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/semantic-matlab.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile semanticdb-matlab.el

In toplevel form:
semanticdb-matlab.el:114:82:Warning: Use `with-current-buffer' rather than
    save-excursion+set-buffer

In semanticdb-matlab-cache-files:
semanticdb-matlab.el:245:18:Warning: reference to free variable
    `semantic-matlab-dependency-system-include-path'
semanticdb-matlab.el:329:8:Warning: (lambda (x) ...) quoted with ' rather than
    with #'
semanticdb-matlab.el:369:8:Warning: (lambda (x) ...) quoted with ' rather than
    with #'

In end of data:
semanticdb-matlab.el:378:1:Warning: the following functions are not known to
    be defined: semanticdb-find-translate-path-default,
    semantic-matlab-find-oldstyle-classes, matlab-shell-active-p,
    matlab-shell-which-fcn, matlab-shell-completion-list
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/semanticdb-matlab.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile srecode-matlab.el
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/srecode-matlab.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile cedet-matlab.el

In matlab-cedet-setup:
cedet-matlab.el:52:19:Warning: reference to free variable
    `srecode-map-load-path'
cedet-matlab.el:52:19:Warning: assignment to free variable
    `srecode-map-load-path'

In end of data:
cedet-matlab.el:62:1:Warning: the function `srecode-map-update-map' is not
    known to be defined.
Wrote /local-ssd/ciolfi/sbtools/apps/emacs-add-ons/src/matlab-emacs/matlab-emacs/cedet-matlab.elc
emacs -Q -batch --no-site-file --eval '(setq debug-on-error t)' -L ./ -L ~/cedet/trunk/lisp/cedet/ --eval '(progn )' -f batch-byte-compile company-matlab-shell.el

In company-matlab-shell-tab:
company-matlab-shell.el:30:23:Warning: reference to free variable
    `comint-prompt-regexp'

In company-matlab-shell-grab-symbol:
company-matlab-shell.el:58:26:Warning: reference to free variable
    `comint-prompt-regexp'

In end of data:
company-matlab-shell.el:84:1:Warning: the function `company-begin-backend' is
    not known to be defined.

Re: [Matlab-emacs-discuss] compiler warnings

[Uwe B. <ou...@ma...>]

>>> "John" == John Ciolfi <Joh...@ma...> writes:

   > I just updated to the latest matlab emacs and see a few warnings. I
   > realize some of these are to support older emacs's but some look like
   > they could be fixed (and maybe suppress the others for older
   > releases)? I'm building on Debian 8 using emacs 24.4.1

I am on GNU emacs 25 (git version, after being a die hard Xemacs user
for ages).

IMHO the GNU emacs team changes to much the definition of variables
(which could break backward compatibility), but I don't want to change
the naming of certain variable because GNU emacs 23 and Xemacs users
could run into problems, not that there are many left, but...

The most harmful warnings I can detect are those starting with

   > matlab.el:5867:1:Warning: the following functions are not known to be defined:
   >     extent-list, start-itimer, matlab-overlays-at, matlab-overlay-get,

Some of the stuff looks Xemacs specific so maybe we should wrap
a (if    (featurep 'xemacs) around it, Eric any ideas?


Uwe Brauer 

Re: [Matlab-emacs-discuss] compiler warnings

[John C. <Joh...@ma...>]

It would be good to fix the warnings that are real. For example, if you could you fix the lambda quoting that would help. On emacs 24, one of the lambda issues shows up when you load an m-file.

In mlint.el add the #' as in:

                          (mapconcat '(lambda (x) x) (cdddr entry) "\\|")
=>
                          (mapconcat #'(lambda (x) x) (cdddr entry) "\\|")

In semanticdb-matlab.el, two occurrences of 

	    (mapcar '(lambda (x)
=>
	    (mapcar #'(lambda (x)


Thanks
John


________________________________________
From: Uwe Brauer <ou...@ma...>
Sent: Friday, September 2, 2016 8:09 AM
To: John Ciolfi
Cc: mat...@li...
Subject: Re: [Matlab-emacs-discuss] compiler warnings

>>> "John" == John Ciolfi <Joh...@ma...> writes:

   > I just updated to the latest matlab emacs and see a few warnings. I
   > realize some of these are to support older emacs's but some look like
   > they could be fixed (and maybe suppress the others for older
   > releases)? I'm building on Debian 8 using emacs 24.4.1

I am on GNU emacs 25 (git version, after being a die hard Xemacs user
for ages).

IMHO the GNU emacs team changes to much the definition of variables
(which could break backward compatibility), but I don't want to change
the naming of certain variable because GNU emacs 23 and Xemacs users
could run into problems, not that there are many left, but...

The most harmful warnings I can detect are those starting with

   > matlab.el:5867:1:Warning: the following functions are not known to be defined:
   >     extent-list, start-itimer, matlab-overlays-at, matlab-overlay-get,

Some of the stuff looks Xemacs specific so maybe we should wrap
a (if    (featurep 'xemacs) around it, Eric any ideas?


Uwe Brauer

Re: [Matlab-emacs-discuss] compiler warnings

[Uwe B. <ou...@ma...>]

>>> "John" == John Ciolfi <Joh...@ma...> writes:

   > It would be good to fix the warnings that are real. For example, if
   > you could you fix the lambda quoting that would help. On emacs 24,
   > one of the lambda issues shows up when you load an m-file. In
   > mlint.el add the #' as in:

   >                           (mapconcat '(lambda (x) x) (cdddr entry) "\\|")
   > =>
   >                           (mapconcat #'(lambda (x) x) (cdddr entry) "\\|")

   > In semanticdb-matlab.el, two occurrences of 

   > 	    (mapcar '(lambda (x)
   > =>
   > 	    (mapcar #'(lambda (x)


Hm ok this change does not break anything in Xemacs, what's about GNU
emacs 23 or inferior??
Any opinions?


BTW this is still just a warning or did you face
any problems with
(mapconcat '(lambda (x) x) (cdddr entry) "\\|")

??

I say I wait a couple of days and if nobody objects I change and push.

Uwe 

Re: [Matlab-emacs-discuss] compiler warnings

[Eric L. <Eri...@ma...>]

Hi Uwe,

The overlay abstraction should avoid the warnings, but perhaps the defalias isn't working with the byte compiler correctly.  I don't know why those warnings exist.  It may be an eval-and-compile type trick is needed around that block.

There were some other warnings in the list where I suspect we just need to move a definition sooner in the file.  I think they are harmless otherwise.

There are some changes from Emacsen that are pretty old, perhaps we can just claim to not support Emacs 22 or earlier.  That was quite a while ago.

Eric

-----Original Message-----
From: Uwe Brauer [mailto:ou...@ma...] 
Sent: Friday, September 02, 2016 8:09 AM
To: John Ciolfi <Joh...@ma...>
Cc: mat...@li...
Subject: Re: [Matlab-emacs-discuss] compiler warnings

>>> "John" == John Ciolfi <Joh...@ma...> writes:

   > I just updated to the latest matlab emacs and see a few warnings. I
   > realize some of these are to support older emacs's but some look like
   > they could be fixed (and maybe suppress the others for older
   > releases)? I'm building on Debian 8 using emacs 24.4.1

I am on GNU emacs 25 (git version, after being a die hard Xemacs user for ages).

IMHO the GNU emacs team changes to much the definition of variables (which could break backward compatibility), but I don't want to change the naming of certain variable because GNU emacs 23 and Xemacs users could run into problems, not that there are many left, but...

The most harmful warnings I can detect are those starting with

   > matlab.el:5867:1:Warning: the following functions are not known to be defined:
   >     extent-list, start-itimer, matlab-overlays-at, matlab-overlay-get,

Some of the stuff looks Xemacs specific so maybe we should wrap
a (if    (featurep 'xemacs) around it, Eric any ideas?


Uwe Brauer 


------------------------------------------------------------------------------
_______________________________________________
Matlab-emacs-discuss mailing list
Mat...@li...
https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss