matlab-emacs-discuss — Discuss Emacs/MATLAB integration

Re: [Matlab-emacs-discuss] [a mess of GPL versions]

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <eri...@gm...> writes:

> I'm not picky about what version of GPL we use as long as it is 2 or
> greater.

I upgraded all headers to GPL3v+, save the .m files in the test
directory. No sure whether it is worth, to add a header there.

I also added a COPYING file, containing the License (the same the emacs
repository uses; that is a recommendation of RMS). Will push this also.

I might also add information to the README file more information about
the directory story (again based on the README file of the emacs repository)


> I fixed things up on the semantic stuff recently, but I agree that I may be
> the only one who uses that stuff.  There's a bunch of esoteric options that
> could move to a subdir, and if needed use something like (require
> 'subir/srcfile) to get it.  I'd recommend a "cedet" subdir, and/or leave it
> out of the debian package.


I leave this to you to decide 🙃

Concerning Debian and ELPA.

    1. I think when I finish the README file (I can wait, if you wish,
       after we settle the semantic stuff), I give the Debian guy a go.

    2. ELPA, there is one signature missing namely from
       Nathaniel Chodosh  nch...@an....
       I wrote him last year and he did not reply, but he still seems to be
       in that place and commits to github.
       I am not sure how to proceed. His patch can be found in the
       copyright branch, in the copyright directory. If he does not answer,
       we might

       1. consider to rewrite his patch

       2. To remove it

       3. Or give up to move Matlab to ELPA


Uwe 
-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the NATO membership of the Ukraine.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[Matlab-emacs-discuss] the filling patch and its problems

[Uwe B. <ou...@ma...>]

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the NATO membership of the Ukraine.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

>>> "EL" == Eric Ludlam <el...@ma...> writes:

> I think you are correct that it isn’t quite right, but I understand why.  I get the column to indent the following lines under and set the fill prefix before handing it over to the built in fill-paragraph code.  Fill paragraph then moves the comment inward, but the fill prefix has already been defined.
> Do you think it should leave the original comment column alone?  That’s my guess.

I think what I posted seems to be one possibility


I tried just to run 
matlab-indent-region 
on 
#+begin_src 
    ev = 0; % el número de evaluaciones al inicio es cero, pues no ha
                                                                  % habido
                                                                  % ninguna
                                                                  % iteración
#+end_src

and I obtained an error I attach, something is not right here


> The comment specific part of matlab-fill-paragraph has a couple
> dubious things it’s doing that I’ll need to better understand to see
> if they are supporting some sort of edge cases. My intuition is that
> chunks of that code can be replaced with ‘fill-region’ instead of what
> it’s doing now but my first cut did something surprising instead.

> I’ll poke at it a little bit, but in theory I’m on vacation this week, so we’ll see.


Oops, by all means that is not urgent, enjoy your holidays...



-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

>>> "JC" == John Ciolfi <ci...@ma...> writes:
Hi John, Hi Eric
> Hi Uwe,
> Eric fixed the issue, see attached patches which apply against the
> current source forge tip, 3048e9. 

Thanks very much, especially Eric for the fix 😉, that is very much
appreciated from my side, since a bunch of matlab exams are waiting to
be corrected.


> I also tested it and have deployed
> it internally within MathWorks. Can you try the patches and if they
> are good, update source forge?


I try to test this as soon as possible, hopefully this evening. 

Maybe in two weeks I got also start the move to github (and renaming
master to default), right now, I am a bit to busy for this (exam period
started and *now* students are starting to study).


Uwe 


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] another bug with the filling alorithm

[John C. <ci...@ma...>]

Hi Uwe,

Eric fixed the issue, see attached patches which apply against the current source forge tip, 3048e9. I also tested it and have deployed it internally within MathWorks. Can you try the patches and if they are good, update source forge?

Thanks,
John
________________________________
From: Uwe Brauer <ou...@ma...>
Sent: Tuesday, April 25, 2023 5:53 AM
To: mat...@li... <mat...@li...>
Subject: [Matlab-emacs-discuss] another bug with the filling alorithm



Hi

Given the following example


while diff > TOL && k <= nmax % por una parte se condiciona al while con un valor de tolerancia para el error diff, error de una iteración de la iteración simple, y, por otra parte, se toma un numero máximo de iteraciones porque puede perfectamente el error de iteración no ser menor que la tolerancia, provocando un bucle infinito


matlab-fill-region returns the following errors

Who wrote this filling algorithm? According to git-hg blame, it was Eric
and the code is well quite old.

I have no idea how to debug this.

Any comments?

Regards

Uwe

--
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military.
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/<https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view>

Re: [Matlab-emacs-discuss] filling of very long inline comments

[John C. <ci...@ma...>]

I took a quick look. matlab-fill-comment-line assumes that it is filling a comment only line and not a trailing comment. I'm not as familiar with the code as Eric. Eric would you have a chance to look at this?

Also, I've noticed that M-q doesn't work on some comments. For example, given the following, M-q on the first comment results in mixing the comment with the function line. Whereas M-q on the second comment works as expected.

function f = foo
% 1. a long comment comment comment comment comment comment comment comment comment comment comment comment comment comment comment comment comment

    f = 1;
    % 2. a long comment comment comment comment comment comment comment comment comment comment comment comment comment comment comment comment comment
    f = f + 1;
end

Thanks,
John
________________________________
From: Uwe Brauer <ou...@ma...>
Sent: Monday, April 24, 2023 3:03 PM
To: mat...@li... <mat...@li...>
Subject: [Matlab-emacs-discuss] filling of very long inline comments


Hi

I am currently reading code provided by my students who use the native matlab editor.

So I see lines like this

while diff > TOL && k <= nmax %por una parte se condiciona al while con un valor de tolerancia para el error diff, error de una iteración (de la iteración simple), y, por otra parte, se toma un numero máximo de iteraciones porque puede perfectamente el error de iteración no ser menor que la tolerancia, provocando un bucle infinito

Which is simply terrible, so I tried to use (matlab-fill-comment-line)
(because matlab fill paragraph ended up deleting the "%" in several
lines.

However the matlab-fill-comment-line gave me an error I attach:

I am running the latest master.

Any idea what is wrong here?

Regards

Uwe

--
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military.
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/<https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view>

[Matlab-emacs-discuss] another bug with the filling alorithm

[Uwe B. <ou...@ma...>]

Hi 

Given the following example


        while diff > TOL && k <= nmax                             % por una parte se condiciona al while con un valor de tolerancia para el error diff, error de una iteración de la iteración simple, y, por otra parte, se toma un numero máximo de iteraciones porque puede perfectamente el error de iteración no ser menor que la tolerancia, provocando un bucle infinito     


matlab-fill-region returns the following errors

Who wrote this filling algorithm? According to git-hg blame, it was Eric
and the code is well quite old.

I have no idea how to debug this.

Any comments?

Regards

Uwe 

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Peter M. <pet...@gm...>]

Hi Uwe,

thanks -- I see the new version on MELPA now.

Peter

On Mon, Apr 24, 2023 at 5:56 AM Uwe Brauer <ou...@ma...> wrote:

> >>> "PM" == Peter Mao <pet...@gm...> writes:
>
> > Hi Uwe,
> > Here are the original patches (matlab-elecp-patch and
> > matlab-elecp-patch_PHM) that would be applied to commit [5069e3c], and
> the
> > patch corresponding to the PR in question
> > (0001-fix-electric-pair-handling-of-single-quote.patch) to be applied to
> be
> > applied to [b700722].  Content-wise, the PR is the same as the two
> original
> > patches applied serially.
>
> Thanks I applied the patch and also committed as author Peter Mao.
> (That is easier if later copyright questions appear)
>
> Regards
>
> Uwe
>
>
> --
> Warning: Content may be disturbing to some audiences
> I strongly condemn Putin's war of aggression against the Ukraine.
> I support to deliver weapons to Ukraine's military.
> I support the ban of Russia from SWIFT.
> I support the EU membership of the Ukraine.
>
> https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/
>

[Matlab-emacs-discuss] filling of very long inline comments

[Uwe B. <ou...@ma...>]

Hi 

I am currently reading code provided by my students who use the native matlab editor. 

So I see lines like this 

        while diff > TOL && k <= nmax                             %por una parte se condiciona al while con un valor de tolerancia para el error diff, error de una iteración (de la iteración simple), y, por otra parte, se toma un numero máximo de iteraciones porque puede perfectamente el error de iteración no ser menor que la tolerancia, provocando un bucle infinito   

Which is simply terrible, so I tried to use (matlab-fill-comment-line)
(because matlab fill paragraph ended up deleting the "%" in several
lines.

However the matlab-fill-comment-line gave me an error I attach:

I am running the latest master.

Any idea what is wrong here?

Regards

Uwe 

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Uwe B. <ou...@ma...>]

>>> "PM" == Peter Mao <pet...@gm...> writes:

> Hi Uwe,
> Here are the original patches (matlab-elecp-patch and
> matlab-elecp-patch_PHM) that would be applied to commit [5069e3c], and the
> patch corresponding to the PR in question
> (0001-fix-electric-pair-handling-of-single-quote.patch) to be applied to be
> applied to [b700722].  Content-wise, the PR is the same as the two original
> patches applied serially.

Thanks I applied the patch and also committed as author Peter Mao.
(That is easier if later copyright questions appear)

Regards

Uwe 


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Peter M. <pet...@gm...>]

Hi Uwe,

Here are the original patches (matlab-elecp-patch and
matlab-elecp-patch_PHM) that would be applied to commit [5069e3c], and the
patch corresponding to the PR in question
(0001-fix-electric-pair-handling-of-single-quote.patch) to be applied to be
applied to [b700722].  Content-wise, the PR is the same as the two original
patches applied serially.

Here is the text of the original issue:

note: I formatted this email in markdown for readability (let me know if
> there's a better way).
>
> I use **electric-pair-mode**.  If you don't you can turn it on locally with
> ```
> (electric-pair-local-mode t)
> ```
> to see what the issue is.
>
> Briefly, with **electric-pair-mode** on (locally or globally), If I type
> the characters `(abc)def`, I get the same output.  The characters that pair
> are the ones in the syntax table (use `describe-syntax' to see it) that are
> of type "open", "close", or "string".
>
> In **matlab-mode**, the pairs (), [], {} (all "open"/"close" type) work
> fine, as does the "string" type delimiter " (aka, double-quote, #x22, ?")
> because it is listed in the variable `electric-pair-pairs`.  The only one
> that does NOT work is the "string" type delimiter ' (aka, single-quote,
> #x27, ?').  So with the `(abc)def` example above, with #x27, I get:
> ```
> 'abc'def'
> ```
> Note the single-quote at the end of the output string after the `f`.
>

Peter

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Uwe B. <ou...@ma...>]

>>> "PM" == Peter Mao <pet...@gm...> writes:


Hi Peter,
> Hi Uwe,
> Here is the email thread from the PR I put up on sourceforge last night.
> Sorry for the confusion -- I'm much better acquainted with the github
> workflow.

> The PR is the equivalent of the two patches in this thread applied serially
> matlab.el of ~ a year ago.  I had to make some adjustments by hand last
> night (patch couldn't always find the right location to add lines), but it
> seems to work fine for me.

Oh well, I can't find the patches, at least not easily. Would you mind

    1. Either send me the patches, again, by email indicating against
       which commit they are supposed to applied.

    2. Or using a PR in gitlab (as I said, most likely in one month I
       try to move/mirror the repository in github, meanwhile I make
       some experiments, but in gitlab, I am more acquainted with
       (because heptapod, where the mercurial development dwells uses a
       gitlab clone)
       the repository is found at
       https://gitlab.com/kalthad/matlab-emacs
       Since I am still more acquainted with patches, but would like to
       understand PR, the logic is this

       - you fork the repository

       - you create a new branch, commit and send th RP, right? You
         create a new branch?

Regards

Uwe 

[Matlab-emacs-discuss] [wrong link] (was: matlab-mode, electric-pair-mode and the single quote ('))

[Uwe B. <ou...@ma...>]

> Hi Peter,


> Oh well, I can't find the patches, at least not easily. Would you mind

>     1. Either send me the patches, again, by email indicating against
>        which commit they are supposed to applied.

>     2. Or using a PR in gitlab (as I said, most likely in one month I
>        try to move/mirror the repository in github, meanwhile I make
>        some experiments, but in gitlab, I am more acquainted with
>        (because heptapod, where the mercurial development dwells uses a
>        gitlab clone)
>        the repository is found at
>        https://gitlab.com/kalthad/matlab-emacs
>        Since I am still more acquainted with patches, but would like to
>        understand PR, the logic is this

>        - you fork the repository

>        - you create a new branch, commit and send th RP, right? You
>          create a new branch?

Sorry the gitlab repository I meant is 
https://gitlab.com/kalthad/matlab-emacs-default

This is the actual one.


Uwe 


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Uwe B. <ou...@ma...>]

> Hi Peter,


> Oh well, I can't find the patches, at least not easily. Would you mind

>     1. Either send me the patches, again, by email indicating against
>        which commit they are supposed to applied.

>     2. Or using a PR in gitlab (as I said, most likely in one month I
>        try to move/mirror the repository in github, meanwhile I make
>        some experiments, but in gitlab, I am more acquainted with
>        (because heptapod, where the mercurial development dwells uses a
>        gitlab clone)
>        the repository is found at
>        https://gitlab.com/kalthad/matlab-emacs
>        Since I am still more acquainted with patches, but would like to
>        understand PR, the logic is this

>        - you fork the repository

>        - you create a new branch, commit and send th RP, right? You
>          create a new branch?

I have just to add, if you fork the gitlab repository, please note that
the main branch is now called default, not master any longer
(I am a mercurial user and that simplifies things for me).


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Peter M. <pet...@gm...>]

Hi Uwe,

Here is the email thread from the PR I put up on sourceforge last night.
Sorry for the confusion -- I'm much better acquainted with the github
workflow.

The PR is the equivalent of the two patches in this thread applied serially
matlab.el of ~ a year ago.  I had to make some adjustments by hand last
night (patch couldn't always find the right location to add lines), but it
seems to work fine for me.

Peter

On Sun, May 15, 2022 at 1:19 PM Eric Ludlam <eri...@gm...> wrote:

> Hi Peter,
>
> Sorry, I completely lost track of this thread when it came in.
>
> Thanks for trying out the patch.  I'm glad it started working for you!
>
> Regarding your questions:
> 1) That defvar tells the byte-compiler that variable exists so it
> doesn't throw a warning when compiling in batch-mode.  You are correct
> that it has no other functional value.
> 2) \\s_ matches symbol characters. This if you type MyVar_'  it will
> correctly match.
>
> 4) Yes, nconc modifies the list.  You would need to make a deep copy of
> electric-pairs-pairs first before modifying it.  Thus, your soln of just
> typing in something is good. :)
> 5) Use 'toggle-debug-on-error' for your first file and see what the
> stack says.  Hard to speculate otherwise.  Run the toggle-debug command
> a 2nd time to turn off debugging.
>
> Good Luck
> Eric
>
> On 4/28/22 11:24 PM, Peter Mao wrote:
> > Hi Eric,
> >
> > Thank you -- that inspired me to make electric-pair-pairs a buffer
> > local variable.  Surprisingly (to me) electric still pairs
> > double-quote (") as I would expect and single-quote (') works in all
> > the contexts I can think of right now.
> >
> > questions/comments:
> > 1.  Your `(defvar electric-pair-inhibit-predicate)` did not seem
> > necessary, so I removed it in my patch
> > 2.  I don't understand the `\\s_` option in your `looking-at`
> > argument, but kept it in, as it seems to do no harm to any of my
> > matlab code.
> > 3.  I added the `\\.` to `looking-at` to handle non-conjugate transpose.
> > 4.  I tried using `nconc` to add single quote to the local
> > `electric-pair-pairs`, but it would always change the global value as
> > well, so I fell back to `setq`.  This is some bit of elisp that I just
> > don't understand.
> > 5.  I'm using emacs 28.1 now with the native-compilation on.  I find
> > that the changes to matlab.el don't work for the first m-file opened,
> > but on the second one (or kill and open the first) all the electric
> > mods work as desired.
> >
> > Peter
> >
> > On Tue, Apr 26, 2022 at 4:10 PM Eric Ludlam <eri...@gm...>
> wrote:
> >
> >     Hi, yes - I meant `show-paren-mode'.  Not sure what I was thinking
> >     at the time.
> >     In the code for matlab.el, it is all about show-paren-* features
> >     it is extending.
> >
> >     I poked around some more to see how to extend electric-pair-mode,
> >     and found the defcustom `electric-pair-inhibit-predicate'.  I
> >     hacked together a little thing that prevents the mode from pairing
> >     up a single quote after a symbol, ie - when used as transpose. The
> >     downside is it also disables the user's selection, so not sure
> >     what to do about that.
> >
> >     Anyway, I attached it as a way to brainstorm what the right
> >     patterns are to fix the original problem.
> >
> >     Eric
> >
> >     On Tue, Apr 26, 2022 at 2:30 AM Uwe Brauer <ou...@ma...> wrote:
> >
> >         >>> "PM" == Peter Mao <pet...@gm...> writes:
> >
> >         Hi all
> >         > hi Eric and John,
> >         > Thanks for your responses.  Eric -- did you mean
> >         `show-paren-mode`?  I
> >         > can't find any references to a `paren-mode` in melpa, elpa
> >         or emacs
> >         > (28.1).  I'll try it out if I can find it!
> >
> >         I was wondering myself. I tend to believe that years ago there
> >         was some
> >         paren-mode package, but I cannot find it in my archives.
> >
> >         Uwe Brauer
> >         _______________________________________________
> >         Matlab-emacs-discuss mailing list
> >         Mat...@li...
> >
> https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
> >
>
>

[Matlab-emacs-discuss] cannot find the path of peter mao

[Uwe B. <ou...@ma...>]

Hi 

As some of you might have noticed (being in the CC)


I received an email from
From: "peter mao" <pm...@us...>

With a merge request

    1. I cannot reply to the email address he used,

    2. I cannot find any patch indicated in the email namely 
,----
| 
| peter mao has requested to merge changes from
| `ssh://@git.code.sf.net/u/pm02134/matlab-emacs` at commit `[d0f287]`
| into the branch `master`
| 
| I discussed this with Eric last year over email and this incorporates
| his original patch and a small tweak that I made. I thought this would
| be implemented at some point, but the main code is now several commits
| ahead, so I patched onto [b700722].
| 
`----

Not sure who to proceed. Any clarification would be welcome, but I also
moved John's last commit to a new branch org-mode. Not sure whether this would case a problem.

Regards

Uwe Brauer 

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] [matlab-emacs:src] Merge request: fix single-quote handling with electric-pair mode

[Uwe B. <ou...@ma...>]

>>> "pm" == peter mao <pm...@us...> writes:

> Merge request: fix single-quote handling with electric-pair mode
> ---

Hi Peter

First, thanks for the patch

> peter mao has requested to merge changes from
> `ssh://@git.code.sf.net/u/pm02134/matlab-emacs` at commit `[d0f287]`
> into the branch `master`

> I discussed this with Eric last year over email and this incorporates
> his original patch and a small tweak that I made. I thought this would
> be implemented at some point, but the main code is now several commits
> ahead, so I patched onto [b700722].


Sorry must have escaped my attention. I will do this at this weekend. 

Right now 

    1. I also testing how to move/mirror the repository to github, since
       John brought up that topic, hoping it would be more attractive
       for users,

    2. Moreover  I want to rename the main branch from master--> default
       (I am a mercurial user and the others did not object). 

So I have to sort this out today, but most likely I will just I merge
your patch into master in sourceforge and leave the other changes for
the next weeks, when I have more time. I think it is safer to move
master-->default, when we move to github.

Uwe Brauer 

> ---

> Sent from sourceforge.net because you indicated interest in <https://sourceforge.net/p/matlab-emacs/src/merge-requests/2/>



> To unsubscribe from further messages, please visit <https://sourceforge.net/auth/subscriptions/>

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: [Matlab-emacs-discuss] mlint not working, void variable

[Eric L. <eri...@gm...>]

Hi Nicholas,

Sorry I missed this when it first came in.

First, if you aren't already, try using the version of matlab-mode from 
git in case you happen to have an older version.  I happen to be on 
Emacs 27 which required some changes to mlint / linemark to work 
correctly with those versions of eieio (the clos library in Emacs.)  I 
haven't tried it with E29.

You stack trace is a bit hard to interpret when byte compiled.  If you 
do this:
M-x load-librry RET mlint.el RET

it will load the src, not the byte compiled version, and you should get 
an easier to understand stack.

Since the error is related to a cl-* variable within one of the clos 
macros, I wouldn't be surprised if more changes were needed to account 
for anything new in E29.  In the E29 NEWS file in git, I see it says you 
may need to add '(require 'eieio-compat')' to some files written against 
older versions of eieio, so that is a possibility.

Eric

On 7/18/22 5:48 AM, Nicholas Harrison wrote:
> Hi and thanks for the package!
>
> I'm trying to get linting to work, but nothing will show. I would love 
> help debugging.
> My steps:
> 1. Open .m file and turn on matlab-mode
> 2. Turn on mlint-minor-mode
> 3. Run mlint-buffer
>
> This is run from emacs -Q with packages loaded first and variables to 
> executables set. Apparently something right is happening since I see 
> some lines in the *M-Lint* buffer, but I get the following error and 
> stack trace:
>
>     Debugger entered--Lisp error: (void-variable cl--nm)
>       #f(compiled-function (&rest args) #<bytecode -0x155fd570868d38f2>)()
>       #f(compiled-function (cl--cnm e active-p) #<bytecode
>     0xbaea774c3e9d26b>)(#f(compiled-function (&rest args) #<bytecode
>     -0x155fd570868d38f2>) #<mlint-lm-entry
>     mlint-lm-entry-158f7c4907cc> nil)
>       apply(#f(compiled-function (cl--cnm e active-p) #<bytecode
>     0xbaea774c3e9d26b>) #f(compiled-function (&rest args) #<bytecode
>     -0x155fd570868d38f2>) (#<mlint-lm-entry
>     mlint-lm-entry-158f7c4907cc> nil))
>       #f(compiled-function (&rest cl--args) "Set object E to be
>     active.\nACTIVE-P if it should be made visible." #<bytecode
>     -0x1e9379681ed694e5>)(#<mlint-lm-entry
>     mlint-lm-entry-158f7c4907cc> nil)
>       apply(#f(compiled-function (&rest cl--args) "Set object E to be
>     active.\nACTIVE-P if it should be made visible." #<bytecode
>     -0x1e9379681ed694e5>) #<mlint-lm-entry
>     mlint-lm-entry-158f7c4907cc> nil)
>       linemark-display(#<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil)
>       #f(compiled-function (e) #<bytecode
>     0x11b9e8c2c87755be>)(#<mlint-lm-entry mlint-lm-entry-158f7c4907cc>)
>       apply(#f(compiled-function (e) #<bytecode 0x11b9e8c2c87755be>)
>     #<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil)
>       linemark-delete(#<mlint-lm-entry mlint-lm-entry-158f7c4907cc>)
>       #<subr
>     F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_28>(#<mlint-lm-entry
>     mlint-lm-entry-158f7c4907cc>)
>       mapc(#<subr
>     F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_28>
>     (#<mlint-lm-entry mlint-lm-entry-158f7c4907cc>))
>       mlint-clear-warnings()
>       mlint-buffer()
>       funcall(mlint-buffer)
>       (condition-case e (funcall hook) ((debug error) (signal
>     'doom-hook-error (list hook e))))
>       doom-run-hook(mlint-buffer)
>       run-hook-wrapped(doom-run-hook mlint-buffer)
>       (condition-case e (run-hook-wrapped hook #'doom-run-hook)
>     ((debug doom-hook-error) (if debug-on-error nil (lwarn hook :error
>     "Error running hook %S because: %s" (if (symbolp (car (cdr e)))
>     (symbol-name (car (cdr e))) (car (cdr e))) (car (cdr (cdr e)))))
>     (signal 'doom-hook-error (cons hook (cdr e)))))
>       (let ((hook (car --dolist-tail--))) (condition-case e
>     (run-hook-wrapped hook #'doom-run-hook) ((debug doom-hook-error)
>     (if debug-on-error nil (lwarn hook :error "Error running hook %S
>     because: %s" (if (symbolp (car ...)) (symbol-name (car ...)) (car
>     (cdr e))) (car (cdr (cdr e))))) (signal 'doom-hook-error (cons
>     hook (cdr e))))) (setq --dolist-tail-- (cdr --dolist-tail--)))
>       (while --dolist-tail-- (let ((hook (car --dolist-tail--)))
>     (condition-case e (run-hook-wrapped hook #'doom-run-hook) ((debug
>     doom-hook-error) (if debug-on-error nil (lwarn hook :error "Error
>     running hook %S because: %s" (if (symbolp ...) (symbol-name ...)
>     (car ...)) (car (cdr ...)))) (signal 'doom-hook-error (cons hook
>     (cdr e))))) (setq --dolist-tail-- (cdr --dolist-tail--))))
>       (let ((--dolist-tail-- hooks)) (while --dolist-tail-- (let
>     ((hook (car --dolist-tail--))) (condition-case e (run-hook-wrapped
>     hook #'doom-run-hook) ((debug doom-hook-error) (if debug-on-error
>     nil (lwarn hook :error "Error running hook %S because: %s" (if ...
>     ... ...) (car ...))) (signal 'doom-hook-error (cons hook (cdr
>     e))))) (setq --dolist-tail-- (cdr --dolist-tail--)))))
>       doom-run-hooks(after-save-hook)
>       apply(doom-run-hooks after-save-hook)
>       run-hooks(after-save-hook)
>       basic-save-buffer(nil)
>       save-buffer()
>       mlint-buffer()
>       #<subr funcall-interactively>(mlint-buffer)
>       apply(#<subr funcall-interactively> mlint-buffer)
>       funcall-interactively(mlint-buffer)
>       #<subr call-interactively>(mlint-buffer nil nil)
>       apply(#<subr call-interactively> (mlint-buffer nil nil))
>       explain-pause--wrap-call-interactively(#<subr
>     call-interactively> mlint-buffer nil nil)
>       apply(explain-pause--wrap-call-interactively #<subr
>     call-interactively> (mlint-buffer nil nil))
>       call-interactively(mlint-buffer nil nil)
>       command-execute(mlint-buffer)
>
>
> Any ideas?
>
> Emacs version: GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ 
> Version 3.24.20, cairo version 1.16.0) of 2022-06-14
> Matlab version: R2022a
> OS: Linux Mint 20.3 Cinnamon
>
>  Nick
>
>
> _______________________________________________
> Matlab-emacs-discuss mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss

[Matlab-emacs-discuss] mlint not working, void variable

[Nicholas H. <nic...@gm...>]

Hi and thanks for the package!

I'm trying to get linting to work, but nothing will show. I would love help
debugging.
My steps:
1. Open .m file and turn on matlab-mode
2. Turn on mlint-minor-mode
3. Run mlint-buffer

This is run from emacs -Q with packages loaded first and variables to
executables set. Apparently something right is happening since I see some
lines in the *M-Lint* buffer, but I get the following error and stack trace:

Debugger entered--Lisp error: (void-variable cl--nm)
>   #f(compiled-function (&rest args) #<bytecode -0x155fd570868d38f2>)()
>   #f(compiled-function (cl--cnm e active-p) #<bytecode
> 0xbaea774c3e9d26b>)(#f(compiled-function (&rest args) #<bytecode
> -0x155fd570868d38f2>) #<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil)
>   apply(#f(compiled-function (cl--cnm e active-p) #<bytecode
> 0xbaea774c3e9d26b>) #f(compiled-function (&rest args) #<bytecode
> -0x155fd570868d38f2>) (#<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil))
>   #f(compiled-function (&rest cl--args) "Set object E to be
> active.\nACTIVE-P if it should be made visible." #<bytecode
> -0x1e9379681ed694e5>)(#<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil)
>   apply(#f(compiled-function (&rest cl--args) "Set object E to be
> active.\nACTIVE-P if it should be made visible." #<bytecode
> -0x1e9379681ed694e5>) #<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil)
>   linemark-display(#<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil)
>   #f(compiled-function (e) #<bytecode
> 0x11b9e8c2c87755be>)(#<mlint-lm-entry mlint-lm-entry-158f7c4907cc>)
>   apply(#f(compiled-function (e) #<bytecode 0x11b9e8c2c87755be>)
> #<mlint-lm-entry mlint-lm-entry-158f7c4907cc> nil)
>   linemark-delete(#<mlint-lm-entry mlint-lm-entry-158f7c4907cc>)
>   #<subr
> F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_28>(#<mlint-lm-entry
> mlint-lm-entry-158f7c4907cc>)
>   mapc(#<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_28>
> (#<mlint-lm-entry mlint-lm-entry-158f7c4907cc>))
>   mlint-clear-warnings()
>   mlint-buffer()
>   funcall(mlint-buffer)
>   (condition-case e (funcall hook) ((debug error) (signal 'doom-hook-error
> (list hook e))))
>   doom-run-hook(mlint-buffer)
>   run-hook-wrapped(doom-run-hook mlint-buffer)
>   (condition-case e (run-hook-wrapped hook #'doom-run-hook) ((debug
> doom-hook-error) (if debug-on-error nil (lwarn hook :error "Error running
> hook %S because: %s" (if (symbolp (car (cdr e))) (symbol-name (car (cdr
> e))) (car (cdr e))) (car (cdr (cdr e))))) (signal 'doom-hook-error (cons
> hook (cdr e)))))
>   (let ((hook (car --dolist-tail--))) (condition-case e (run-hook-wrapped
> hook #'doom-run-hook) ((debug doom-hook-error) (if debug-on-error nil
> (lwarn hook :error "Error running hook %S because: %s" (if (symbolp (car
> ...)) (symbol-name (car ...)) (car (cdr e))) (car (cdr (cdr e))))) (signal
> 'doom-hook-error (cons hook (cdr e))))) (setq --dolist-tail-- (cdr
> --dolist-tail--)))
>   (while --dolist-tail-- (let ((hook (car --dolist-tail--)))
> (condition-case e (run-hook-wrapped hook #'doom-run-hook) ((debug
> doom-hook-error) (if debug-on-error nil (lwarn hook :error "Error running
> hook %S because: %s" (if (symbolp ...) (symbol-name ...) (car ...)) (car
> (cdr ...)))) (signal 'doom-hook-error (cons hook (cdr e))))) (setq
> --dolist-tail-- (cdr --dolist-tail--))))
>   (let ((--dolist-tail-- hooks)) (while --dolist-tail-- (let ((hook (car
> --dolist-tail--))) (condition-case e (run-hook-wrapped hook
> #'doom-run-hook) ((debug doom-hook-error) (if debug-on-error nil (lwarn
> hook :error "Error running hook %S because: %s" (if ... ... ...) (car
> ...))) (signal 'doom-hook-error (cons hook (cdr e))))) (setq
> --dolist-tail-- (cdr --dolist-tail--)))))
>   doom-run-hooks(after-save-hook)
>   apply(doom-run-hooks after-save-hook)
>   run-hooks(after-save-hook)
>   basic-save-buffer(nil)
>   save-buffer()
>   mlint-buffer()
>   #<subr funcall-interactively>(mlint-buffer)
>   apply(#<subr funcall-interactively> mlint-buffer)
>   funcall-interactively(mlint-buffer)
>   #<subr call-interactively>(mlint-buffer nil nil)
>   apply(#<subr call-interactively> (mlint-buffer nil nil))
>   explain-pause--wrap-call-interactively(#<subr call-interactively>
> mlint-buffer nil nil)
>   apply(explain-pause--wrap-call-interactively #<subr call-interactively>
> (mlint-buffer nil nil))
>   call-interactively(mlint-buffer nil nil)
>   command-execute(mlint-buffer)
>

Any ideas?

Emacs version: GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+
Version 3.24.20, cairo version 1.16.0) of 2022-06-14
Matlab version: R2022a
OS: Linux Mint 20.3 Cinnamon

 Nick

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Eric L. <eri...@gm...>]

Hi Peter,

Sorry, I completely lost track of this thread when it came in.

Thanks for trying out the patch.  I'm glad it started working for you!

Regarding your questions:
1) That defvar tells the byte-compiler that variable exists so it 
doesn't throw a warning when compiling in batch-mode.  You are correct 
that it has no other functional value.
2) \\s_ matches symbol characters. This if you type MyVar_'  it will 
correctly match.

4) Yes, nconc modifies the list.  You would need to make a deep copy of 
electric-pairs-pairs first before modifying it.  Thus, your soln of just 
typing in something is good. :)
5) Use 'toggle-debug-on-error' for your first file and see what the 
stack says.  Hard to speculate otherwise.  Run the toggle-debug command 
a 2nd time to turn off debugging.

Good Luck
Eric

On 4/28/22 11:24 PM, Peter Mao wrote:
> Hi Eric,
>
> Thank you -- that inspired me to make electric-pair-pairs a buffer 
> local variable.  Surprisingly (to me) electric still pairs 
> double-quote (") as I would expect and single-quote (') works in all 
> the contexts I can think of right now.
>
> questions/comments:
> 1.  Your `(defvar electric-pair-inhibit-predicate)` did not seem 
> necessary, so I removed it in my patch
> 2.  I don't understand the `\\s_` option in your `looking-at` 
> argument, but kept it in, as it seems to do no harm to any of my 
> matlab code.
> 3.  I added the `\\.` to `looking-at` to handle non-conjugate transpose.
> 4.  I tried using `nconc` to add single quote to the local 
> `electric-pair-pairs`, but it would always change the global value as 
> well, so I fell back to `setq`.  This is some bit of elisp that I just 
> don't understand.
> 5.  I'm using emacs 28.1 now with the native-compilation on.  I find 
> that the changes to matlab.el don't work for the first m-file opened, 
> but on the second one (or kill and open the first) all the electric 
> mods work as desired.
>
> Peter
>
> On Tue, Apr 26, 2022 at 4:10 PM Eric Ludlam <eri...@gm...> wrote:
>
>     Hi, yes - I meant `show-paren-mode'.  Not sure what I was thinking
>     at the time.
>     In the code for matlab.el, it is all about show-paren-* features
>     it is extending.
>
>     I poked around some more to see how to extend electric-pair-mode,
>     and found the defcustom `electric-pair-inhibit-predicate'.  I
>     hacked together a little thing that prevents the mode from pairing
>     up a single quote after a symbol, ie - when used as transpose. The
>     downside is it also disables the user's selection, so not sure
>     what to do about that.
>
>     Anyway, I attached it as a way to brainstorm what the right
>     patterns are to fix the original problem.
>
>     Eric
>
>     On Tue, Apr 26, 2022 at 2:30 AM Uwe Brauer <ou...@ma...> wrote:
>
>         >>> "PM" == Peter Mao <pet...@gm...> writes:
>
>         Hi all
>         > hi Eric and John,
>         > Thanks for your responses.  Eric -- did you mean
>         `show-paren-mode`?  I
>         > can't find any references to a `paren-mode` in melpa, elpa
>         or emacs
>         > (28.1).  I'll try it out if I can find it!
>
>         I was wondering myself. I tend to believe that years ago there
>         was some
>         paren-mode package, but I cannot find it in my archives.
>
>         Uwe Brauer
>         _______________________________________________
>         Matlab-emacs-discuss mailing list
>         Mat...@li...
>         https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
>

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Peter M. <pet...@gm...>]

Hi Eric,

Thank you -- that inspired me to make electric-pair-pairs a buffer local
variable.  Surprisingly (to me) electric still pairs double-quote (") as I
would expect and single-quote (') works in all the contexts I can think of
right now.

questions/comments:
1.  Your `(defvar electric-pair-inhibit-predicate)` did not seem necessary,
so I removed it in my patch
2.  I don't understand the `\\s_` option in your `looking-at` argument, but
kept it in, as it seems to do no harm to any of my matlab code.
3.  I added the `\\.` to `looking-at` to handle non-conjugate transpose.
4.  I tried using `nconc` to add single quote to the local
`electric-pair-pairs`, but it would always change the global value as well,
so I fell back to `setq`.  This is some bit of elisp that I just don't
understand.
5.  I'm using emacs 28.1 now with the native-compilation on.  I find that
the changes to matlab.el don't work for the first m-file opened, but on the
second one (or kill and open the first) all the electric mods work as
desired.

Peter

On Tue, Apr 26, 2022 at 4:10 PM Eric Ludlam <eri...@gm...> wrote:

> Hi, yes - I meant `show-paren-mode'.  Not sure what I was thinking at the
> time.
> In the code for matlab.el, it is all about show-paren-* features it is
> extending.
>
> I poked around some more to see how to extend electric-pair-mode, and
> found the defcustom `electric-pair-inhibit-predicate'.  I hacked together a
> little thing that prevents the mode from pairing up a single quote after a
> symbol, ie - when used as transpose.  The downside is it also disables the
> user's selection, so not sure what to do about that.
>
> Anyway, I attached it as a way to brainstorm what the right patterns are
> to fix the original problem.
>
> Eric
>
> On Tue, Apr 26, 2022 at 2:30 AM Uwe Brauer <ou...@ma...> wrote:
>
>> >>> "PM" == Peter Mao <pet...@gm...> writes:
>>
>> Hi all
>> > hi Eric and John,
>> > Thanks for your responses.  Eric -- did you mean `show-paren-mode`?  I
>> > can't find any references to a `paren-mode` in melpa, elpa or emacs
>> > (28.1).  I'll try it out if I can find it!
>>
>> I was wondering myself. I tend to believe that years ago there was some
>> paren-mode package, but I cannot find it in my archives.
>>
>> Uwe Brauer
>> _______________________________________________
>> Matlab-emacs-discuss mailing list
>> Mat...@li...
>> https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
>>
>

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Eric L. <eri...@gm...>]

Hi, yes - I meant `show-paren-mode'.  Not sure what I was thinking at the
time.
In the code for matlab.el, it is all about show-paren-* features it is
extending.

I poked around some more to see how to extend electric-pair-mode, and found
the defcustom `electric-pair-inhibit-predicate'.  I hacked together a
little thing that prevents the mode from pairing up a single quote after a
symbol, ie - when used as transpose.  The downside is it also disables the
user's selection, so not sure what to do about that.

Anyway, I attached it as a way to brainstorm what the right patterns are to
fix the original problem.

Eric

On Tue, Apr 26, 2022 at 2:30 AM Uwe Brauer <ou...@ma...> wrote:

> >>> "PM" == Peter Mao <pet...@gm...> writes:
>
> Hi all
> > hi Eric and John,
> > Thanks for your responses.  Eric -- did you mean `show-paren-mode`?  I
> > can't find any references to a `paren-mode` in melpa, elpa or emacs
> > (28.1).  I'll try it out if I can find it!
>
> I was wondering myself. I tend to believe that years ago there was some
> paren-mode package, but I cannot find it in my archives.
>
> Uwe Brauer
> _______________________________________________
> Matlab-emacs-discuss mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matlab-emacs-discuss
>

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[John C. <ci...@ma...>]

We are using:

(show-paren-mode t)

which works well.

Though, show paren mode doesn't have the nice feature that electric pair mode has regarding automatically adding the closing single quote. I think show paren mode and electric pair mode would complement each other nicely if we could get electric pair mode working.


________________________________
From: Uwe Brauer
Sent: Tuesday, April 26, 2022 2:24 AM
To: Peter Mao
Cc: John Ciolfi; matlab-emacs-discuss
Subject: Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

>>> "PM" == Peter Mao <pet...@gm...> writes:

Hi all
> hi Eric and John,
> Thanks for your responses.  Eric -- did you mean `show-paren-mode`?  I
> can't find any references to a `paren-mode` in melpa, elpa or emacs
> (28.1).  I'll try it out if I can find it!

I was wondering myself. I tend to believe that years ago there was some
paren-mode package, but I cannot find it in my archives.

Uwe Brauer

Re: [Matlab-emacs-discuss] matlab-mode, electric-pair-mode and the single quote (')

[Uwe B. <ou...@ma...>]

>>> "PM" == Peter Mao <pet...@gm...> writes:

Hi all
> hi Eric and John,
> Thanks for your responses.  Eric -- did you mean `show-paren-mode`?  I
> can't find any references to a `paren-mode` in melpa, elpa or emacs
> (28.1).  I'll try it out if I can find it!

I was wondering myself. I tend to believe that years ago there was some
paren-mode package, but I cannot find it in my archives.

Uwe Brauer