Re: [Math-atlas-devel] Re: Small legacy patches
Brought to you by:
rwhaley,
tonyc040457
From: Camm M. <ca...@en...> - 2003-12-22 17:28:52
|
Hi Clint! I've not put in any mental CPU on the ATL_zero calls -- they were added due to an errata report posted on the website against an old release. I'm upgrading my diffs from that release, so I'm really not sure if these mods are needed in the newer stuff. The SNAME call infinitesimal-patch should be right though, I think. Take care, rw...@cs... (R Clint Whaley) writes: > Camm, > > Sorry to repeat, but I just realized I had been a little imprecise. > The cleanup cases also have BETA=0 support. The only exception is when > K is <= NB. Therefore, I think you need to call ATL_zero iff you are > in a case where _all you call_ is the K cleanup. If you call M cleanup, > and then K cleanup, you would be fine, for instance. At least that was > my theory in writing the code without the ATL_zero calls you have added. > > ? > Clint > > >From mat...@li... Mon Dec 22 11:57:04 2003 > X-Original-To: rw...@cs... > To: ca...@en... > Cc: mat...@li... > From: rw...@cs... (R Clint Whaley) > X-Virus-Scanned: by amavisd-new and ClamAV at cs.utk.edu > X-Spam-Score: 0.0 (/) > Subject: [Math-atlas-devel] Re: Small legacy patches > X-BeenThere: mat...@li... > X-Mailman-Version: 2.0.9-sf.net > List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/math-atlas-devel>, > <mailto:mat...@li...?subject=unsubscribe> > List-Id: List for developer discussion, > NOT SUPPORT. <math-atlas-devel.lists.sourceforge.net> > List-Post: <mailto:mat...@li...> > List-Help: <mailto:mat...@li...?subject=help> > List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/math-atlas-devel>, > <mailto:mat...@li...?subject=subscribe> > List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=math-atlas-devel> > X-Original-Date: Mon, 22 Dec 2003 11:56:16 -0500 (EST) > Date: Mon, 22 Dec 2003 11:56:16 -0500 (EST) > X-Spam-Score: 0.0 (/) > X-Virus-Scanned: by amavisd-new and ClamAV at cs.utk.edu > X-Spam-Status: No, hits=-4.9 tagged_above=-100.0 required=7.0 tests=BAYES_00 > X-Spam-Level: > > Camm, > > Thanks for giving the stuff such a going over. It's unfortunate that the > debian outage screwed up the timing. If you are correct that we need this, > it will be the first errata entry, as the day of the release is too late > to change significant source. > > However, what makes you believe we need those calls to ATL_zero? I think you > don't need them when you are calling non-cleanup code, since the non-cleanup > code have a BETA=0 specific case that never touches $C$. The only reason > they are zeroed in the cleanup case is to be sure that NaN/inf don't > propogate through the computation from the workspace, because the cleanup > uses BETA=X to handle BETA=0. > > ? > Clint > > >From ca...@en... Mon Dec 22 11:28:36 2003 > X-Original-To: rw...@cs... > To: rw...@cs... (R Clint Whaley) > Cc: mat...@li... > Subject: Small legacy patches > From: Camm Maguire <ca...@en...> > Date: 22 Dec 2003 11:28:33 -0500 > User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 > MIME-Version: 1.0 > X-Virus-Scanned: by amavisd-new and ClamAV at cs.utk.edu > X-Spam-Status: No, hits=-4.9 tagged_above=-100.0 required=7.0 tests=BAYES_00 > X-Spam-Level: > > Greetings! I think this one is needed: > > --- atlas-3.5.19.orig/interfaces/blas/C/testing/c_zblat2.f > +++ atlas-3.5.19/interfaces/blas/C/testing/c_zblat2.f > @@ -1611,7 +1611,7 @@ > * .. Common blocks .. > COMMON /INFOC/INFOT, NOUTC, OK > * .. Executable Statements .. > - CONJ = SNAME( 5: 5 ).EQ.'c' > + CONJ = SNAME( 11: 11 ).EQ.'c' > * Define the number of arguments. > NARGS = 9 > * > > But these may no longer be: > > > --- atlas-3.5.19.orig/src/blas/gemm/ATL_NCmmIJK_c.c > +++ atlas-3.5.19/src/blas/gemm/ATL_NCmmIJK_c.c > @@ -228,7 +228,7 @@ > for (i=Mb; i; i--, a += incAm, b += incBm, c += incCm) > { > for (j=Nb; j; j--, a += incAn, b += incBn, c += incCn) > - { > + { Mjoin(PATL,zero)(MB*NB, cp, 1); > if (Kb) > { > mm_bX(MB, NB, KB, ATL_rone, a, lda, b, ldb, ATL_rzero, cp, MB); > --- atlas-3.5.19.orig/src/blas/gemm/ATL_NCmmJIK_c.c > +++ atlas-3.5.19/src/blas/gemm/ATL_NCmmJIK_c.c > @@ -229,7 +229,7 @@ > for (j=Nb; j; j--, a += incAn, b += incBn, c += incCn) > { > for (i=Mb; i; i--, a += incAm, b += incBm, c += incCm) > - { > + { Mjoin(PATL,zero)(MB*nr, cp, 1); > if (Kb) > { > mm_bX(MB, NB, KB, ATL_rone, a, lda, b, ldb, ATL_rzero, cp, MB); > @@ -272,7 +272,7 @@ > geadd(MB, nr, alpha, cp, MB, beta, c, ldc); > } > if (mr) /* cleanup small mr x nr block of C */ > - { > + { Mjoin(PATL,zero)(MB*nr, cp, 1); > c = C + Mb*MB + ldc*Nb*NB; > a = A + Mb*(incAm+Kb*incAk); > b = B + Nb*( incBn+(Mb*(incBm+Kb*incBk)) ); > --- atlas-3.5.19.orig/src/blas/gemm/ATL_cNCmmIJK_c.c > +++ atlas-3.5.19/src/blas/gemm/ATL_cNCmmIJK_c.c > @@ -384,7 +384,7 @@ > for (i=Mb; i; i--, a += incAm, b += incBm, c += incCm) > { > for (j=Nb; j; j--, a += incAn, b += incBn, c += incCn) > - { > + { Mjoin(PATL,zero)(MB*NB, cp, 1); > if (Kb) > { > r0mm_bX(MB, NB, KB, ar0, a+1, lda, b+1, ldb, ATL_rzero, cp, MB); > --- atlas-3.5.19.orig/src/blas/gemm/ATL_cNCmmJIK_c.c > +++ atlas-3.5.19/src/blas/gemm/ATL_cNCmmJIK_c.c > @@ -384,7 +384,7 @@ > for (j=Nb; j; j--, a += incAn, b += incBn, c += incCn) > { > for (i=Mb; i; i--, a += incAm, b += incBm, c += incCm) > - { > + { Mjoin(PATL,zero)(MB*nr, cp, 1); > if (Kb) > { > r0mm_bX(MB, NB, KB, ar0, a+1, lda, b+1, ldb, ATL_rzero, cp, MB); > @@ -466,7 +466,7 @@ > geadd(MB, nr, alpha, cp, MB, beta, c, ldc); > } > if (mr) /* cleanup small mr x nr block of C */ > - { > + { Mjoin(PATL,zero)(MB*nr, cp, 1); > c = C + ((Mb*MB + ldc*Nb*NB)<<1); > a = A + Mb*(incAm+Kb*incAk); > b = B + Nb*( incBn+(Mb*(incBm+Kb*incBk)) ); > > > Great work Clint! > > Take care, > > > -- > Camm Maguire ca...@en... > ========================================================================== > "The earth is but one country, and mankind its citizens." -- Baha'u'llah > > > > ------------------------------------------------------- > This SF.net email is sponsored by: IBM Linux Tutorials. > Become an expert in LINUX or just sharpen your skills. Sign up for IBM's > Free Linux Tutorials. Learn everything from the bash shell to sys admin. > Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click > _______________________________________________ > Math-atlas-devel mailing list > Mat...@li... > https://lists.sourceforge.net/lists/listinfo/math-atlas-devel > > > > -- Camm Maguire ca...@en... ========================================================================== "The earth is but one country, and mankind its citizens." -- Baha'u'llah |