Menu

#154 Expand Gamma Setting Options

open
nobody
None
2015-06-28
2008-09-25
Anonymous
No

On some systems (all of the ones I own, at least, especially the Nokia N810 and Sharp Zaurus SL-C3100), everything is too dark to be fun to play, even on the "Lightest" setting.

I made a small change that allows for the alpha to be set to an "ActuallyLightEnough" setting, or 0.40F, as it is in actual_gamma_values.

I suppose it would possibly be better to put the gamma on a number scale (eg, from 1 (darkest) to 10 (lightest)) instead of the current one as well.

Discussion

  • Nobody/Anonymous

    Patch proof-of-concept

     
  • Nobody/Anonymous

    Sorry, I bungled that patch. It should be something like this (sorry if these don't work, but you should get what I did):

    --- AlephOne-20080913/Source_Files/RenderOther/fades.h 2002-03-14 03:03:46.000000000 -0600
    +++ AlephOne-20080913-changed/Source_Files/RenderOther/fades.h 2008-09-24 21:45:35.000000000 -0500
    @@ -39,7 +39,7 @@

    enum
    {
    - NUMBER_OF_GAMMA_LEVELS= 8,
    + NUMBER_OF_GAMMA_LEVELS= 9,
    DEFAULT_GAMMA_LEVEL= 2
    };
    --- AlephOne-20080913/Source_Files/RenderOther/fades.cpp 2008-05-11 08:19:30.000000000 -0500
    +++ AlephOne-20080913-changed/Source_Files/RenderOther/fades.cpp 2008-09-24 21:34:06.000000000 -0500
    @@ -219,7 +219,8 @@
    0.90F,
    0.85F,
    0.77F,
    - 0.70F
    + 0.70F,
    + 0.40F
    };

    /* ---------- private prototypes */
    --- AlephOne-20080913/Source_Files/Misc/preferences.cpp 2008-09-13 13:26:39.000000000 -0500
    +++ AlephOne-20080913-changed/Source_Files/Misc/preferences.cpp 2008-09-24 21:50:10.000000000 -0500
    @@ -697,8 +697,8 @@
    NULL
    };

    -static const char *gamma_labels[9] = {
    - "Darkest", "Darker", "Dark", "Normal", "Light", "Really Light", "Even Lighter", "Lightest", NULL
    +static const char *gamma_labels[NUMBER_OF_GAMMA_LEVELS + 1] = {
    + "Darkest", "Darker", "Dark", "Normal", "Light", "Really Light", "Even Lighter", "Lightest", "ActuallyLightEnough", NULL
    };

    static const char* renderer_labels[] = {

     
  • Gregory Smith

    Gregory Smith - 2008-09-30
    • labels: 103847 -->
    • milestone: 102183 -->
     
  • Jeremiah Morris

    Jeremiah Morris - 2015-06-28
    • summary: Expand Alpha Setting Options --> Expand Gamma Setting Options
     

Log in to post a comment.