#539 --disable-opengl compile still requires OpenGL headers

[Pickle136]

1. The software cannot be built without opengl (HaVE_OPENGL)
2. When the software is edited to build it does not crashed (may have been a mistake on my part)

Changes that are committed shouldnt break other features. Other platforms and devices do not support opengl.
Please consider asking the author of the additional opengl to test the changes without opengl.

[Pickle136]

[Pickle136]

I fixed up my changes and software render only (no opengl) now works.
Note there is a change switching HOME to PWD, just ignore it was only for the port im supporting.

[Gregory Smith]

I've committed your change. Thanks!

I'm leaving this open because this only OpenGL linking issues are fixed--I believe the OpenGL headers are still required to build. That should be cleaned up some day.

[aapoaapo]

svn-r4652
./configure --disable-opengl

First issue:
preferences.cpp:935: error: no matching function for call to 'w_static_text::w_static_text(std::string)'
(It is inside #ifndef HAVE_OPENGL)

Second issue:
/usr/include/SDL/SDL_opengl.h:44:60: error: GL/gl.h: No such file or directory
/usr/include/SDL/SDL_opengl.h:45:58: error: GL/glu.h: No such file or directory

I have /usr/include/SDL/SDL_gles.h, but seems it is not (drop-in-)replacement for SDL_opengl.h.

[Anonymous]

I'm currently porting Aleph One to the Wii and got this fixed. I could porvide a patch if needed.

[aapoaapo]

Patch, yes please.

[Gregory Smith]

The first issue should just be a matter of calling the c_str() member on the temporary string being passed. I'll fix that in SVN. Catching the OpenGL header dependencies will require setting up a VM with no OpenGL headers.

[mathieudel]

It seems I don"t have permissions to add attached files (I don't see any button). I could sent it by mail if you wish.
As a side note, the patch is meant to be applied on trunk's revision 4578, but it works on trunk's revision 4655 too.

[Anonymous]

Finally, I extracted it from my port's source, you can grab it here : http://code.google.com/p/aleph-wone/downloads/detail?name=remove_opengl_dependency.diff

[aapoaapo]

Thanks, I got it compiled.

svn co https://marathon.svn.sourceforge.net/svnroot/marathon marathon -r 4652
cd marathon/trunk
wget https://aleph-wone.googlecode.com/files/remove_opengl_dependency.diff
patch -p0 < remove_opengl_dependency.diff
#comment this row out
preferences.cpp:935: error: no matching function for call to 'w_static_text::w_static_text(std::string)'
NO_CONFIGURE=yes ./autogen.sh
./configure --disable-opengl
make

[aapoaapo]

I got it compiled without opengl, but I got some errors.

I downloaded data pack for Linux version, and when starting from terminal I get errors:
Error at line 2: element of type marathon has no child of type opengl
Error at line 6: element of type marathon has no child of type texture
Error at line 7: element of type marathon has no child of type texture
Error at line 8: element of type marathon has no child of type texture
Error at line 9: element of type marathon has no child of type texture
Error at line 10: element of type marathon has no child of type texture
There were parsing errors in configuration file monsters.mml

Game can still be started and seems to work.

[Anonymous]

I do have the exact same errors in my logs on the Wii, I did not look at them right now, but I guess this is due to scripts trying to use OpenGL while it's not available anymore.

We could patch the code even further to avoid those errors when OpenGL is not supported , or convert them to warnings, but I don't think it's a good idea : the truth is told as the files that feeds the patched engine references non available features.