Menu

#49 Improve “askmara-tcp” program

open
nobody
None
2020-02-04
2018-11-12
Anonymous
No

Originally created by: samboy

By replacing dig with askmara-tcp, both the sqa_tcp_buffering and the sqa_bigpacket tests
are not properly testing the Deadwood feature in question.

The issue starts with https://github.com/samboy/MaraDNS/issues/48 which was caused, by and large, because dig no longer works with Deadwood (probably because of changes on ISC’s part to this program). That in mind, I have opened up a ticket about the dig issue: https://github.com/samboy/MaraDNS/issues/47

In order to get the tests to pass, I have replaced any usage of dig in the TCP tests with askmara-tcp. This way, the tests passing do not depend on the ISC not making arbitrary changes to dig. While askmara-tcp is good enough for basic TCP testing in the majority of the TCP tests, looking at the test output in the sqa_tcp_buffering and the sqa_bigpacket tests, askmara-tcp appears to not be able to correctly test for the feature in question.

That in mind, I have opened up this ticket: Let’s improve askmara-tcp so it can handle DNS-over-TCP well enough to handle those tests (or, likewise, figure out some other way to run the tests w/o needing dig so we’re actually testing the feature).

Discussion

  • Anonymous

    Anonymous - 2019-10-25

    Originally posted by: samboy

    Marking “future”, i.e. post-MaraDNS 3.4

     
  • Anonymous

    Anonymous - 2020-02-04

    Originally posted by: samboy

    Since this is the only open bug, work on it.

     

Log in to post a comment.