Menu
▾
▴
Re: [Mapbuilder-devel] Proposal, give Dirk van den Elzen commit access
|
From: Cameron S. <cam...@gm...> - 2006-11-28 22:31:23
|
Dirk, There have been a number of positive and no negative responses to giving you commit access to Mapbuilder. Your access to subversion should now be setup. Welcome aboard. I suggest you test your subversion setup by doing a fresh checkout of Mapbuilder from subversion using your codehaus username, and then: 1. Commit your fix. (and then close the JIRA issue). 2. Insert your name in the mapbuilder/LICENSE.txt file. Dirk van den Elzen wrote: > Hi Cameron, > > I expect to be involved for some time with mapbuilder. My codehaus > username is dirk. > And I raised a JIRA issue for the multiple toolbars. > > Dirk > > > On 11/25/06, *Cameron Shorter* <cam...@gm... > <mailto:cam...@gm...>> wrote: > > This is a formal proposal to give Dirk van den Elzen commit access to > Subversion. > > Based on my review of Dirk's code I consider Dirk a competent developer > who would be a benefit to Mapbuilder. > > > Could all developers with commit access please vote: +1=yes. -1=no > (please give a reason). 0=don't care. > > Dirk, > Do you plan to continue to use Mapbuilder for the medium to long term? > > Could you please create a codehaus username for yourself in accordance > with http://docs.codehaus.org/display/MAP/SVN+Repository and let us know > your username. > > Also, let's try and get your issue into JIRA when you are online next. > > Dirk van den Elzen wrote: > > Hi Cameron, > > > > I just raised an JIRA issue( but I don't see any matching issues.) > > I also send you my tested changes to the head version. > > > > Dirk > > > > On 11/23/06, *Cameron Shorter* <cam...@gm... > <mailto:cam...@gm...> > > <mailto: cam...@gm... > <mailto:cam...@gm...>>> wrote: > > > > Dirk, > > Have you raised a JIRA issue for this? We are going through the > > Mapbuilder bug tracker now looking at what should be fixed > for the next > > build. > > > > Dirk van den Elzen wrote: > > > Hi Cameron, > > > > > > Answers to your questions: > > > > > > 1. Yes it is backwardly compateble. > > > 2. I did update the relaese version of Mapbuilder. I still > have > > to test > > > my updates on the head version. > > > 3. I didn't do that yet. > > > > > > > > > On 10/5/06, *Cameron Shorter* <cam...@gm... > <mailto:cam...@gm...> > > <mailto:cam...@gm... > <mailto:cam...@gm...> > > > > <mailto: cam...@gm... > <mailto:cam...@gm...> > > <mailto:cam...@gm... > <mailto:cam...@gm...>>>> wrote: > > > > > > Hello Dirk, > > > > > > This sounds like a good improvement and something we > should > > include in > > > the codebase. A few questions/comments: > > > > > > 1. Is it backwardly compatable? Ie, if we include this > patch > > will old > > > applications still work? We need to ensure we don't > break old > > > applications. > > > > > > 2. I had a quick look at your code (diffed against the > head > > > verions). It > > > seems that you make your updates to an older version, > maybe > > the release > > > version of mapbuilder. If possible, it would be good > if you > > could apply > > > your changes to the head version and test it to make > sure it > > works. > > > > > > 3. To keep track of our changes, and keep documentation we > > need to > > > update, could you please: > > > * Raise an issue in JIRA with your patch. (Ideally with > > changes to the > > > head version of mapbuilder). > > > * Update the schema documenting how the widget works. > > > (As per:) > > > > > http://communitymapbuilder.org/display/MAP/Add+Widget+Tutorial > > <http://communitymapbuilder.org/display/MAP/Add+Widget+Tutorial > > > > > > > > > > Dirk van den Elzen wrote: > > > > Hi, > > > > > > > > Current behaviour multiple toolbars: > > > > There can be more then one button enabled at the > same time. > > > > (one from each toolbar) > > > > > > > > Problem for example: > > > > When you using the EditPoint function the zoomOut > > function can be > > > > active at the same time. > > > > (see previous problem "multiple toolbars" in the > list) > > > > > > > > Solution: > > > > Use the htmlTagId property for a button: > > > > Before you can to this include the files in the > > > "mapbuilder\lib\widget" > > > > directory > > > > > > > > Example: > > > > ZoomIn and ZoomOut will be placed on different > places in the > > > webpage, > > > > but will act as a group(same buttonbar property) > > > > > > > > <ZoomOut id="zoomOut"> > > > > <buttonBar>mainButtonBar</buttonBar> > > > > </ZoomOut> > > > > <ZoomIn id="zoomIn"> > > > > <buttonBar>mainButtonBar</buttonBar> > > > > <htmlTagId>otherButtonbar</htmlTagId> > > > > </ZoomIn> > > > > > > > > > > > > buttonBar > > > > Equivalent to the htmlTagId property for placing > buttons in a > > > page. Buttons > > > > get appended to this HTML element in sequence. > > > > Buttons with the same buttonBar property will belong to > > the same > > > > buttonBar group. > > > > > > > > htmlTagId (optional) > > > > If set this property will be used for placing the > buttons > > in a page. > > > > Buttons > > > > get appended to this HTML element in sequence. > > > > Use this property if you want to place buttons with > the same > > > buttonBar > > > > property > > > > on a different place in the web page. > > > > Default(if this property is missing) the button's > > buttonBar property > > > > will be used. > > > > (if the buttons buttonBar's property is missing this > > property is > > > used > > > > instead) > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > Join SourceForge.net 's Techsay panel and you'll > get the > > chance to > > > share your > > > > opinions on IT & business topics through brief > surveys -- and > > > earn cash > > > > > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > <http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV> > > > <http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > <http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV>> > > > > > > <http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > <http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV> > > > <http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > <http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV>>> > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > > > > > > _______________________________________________ > > > > mapbuilder-devel mailing list > > > > map...@li... > <mailto:map...@li...> > > <mailto: map...@li... > <mailto:map...@li...>> > > > <mailto: map...@li... > <mailto:map...@li...> > > <mailto: map...@li... > <mailto:map...@li...>>> > > > > > https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel > > > > > > > > > -- > > > Cameron Shorter > > > http://cameron.shorter.net > > > > > > > > > > > > -- > > Cameron Shorter > > http://cameron.shorter.net <http://cameron.shorter.net> > > > > > > > -- > Cameron Shorter > http://cameron.shorter.net > > -- Cameron Shorter http://cameron.shorter.net |