From: Jeroen L. <jl...@ca...> - 2003-03-18 22:30:14
|
At 14:01 18-3-2003 -0800, you wrote: >As a "test", I have started to clean up the HTML produced by >view_all_bug_page.php. Attached is a patch which seriously reduces the >size of the produced output. After the cleanup, the document even >validated (using w3c.org's validator). > >The page is still a mix of old vs new css classes, ultimately I would take >the cleanup a little further to reduce the class mix. > >Some key points: >- De-generalize CSS classes (even if that causes some redundancy in the CSS) >- Remove unecessary class= assignments by relying on inheritance more >- Line breaks improve readability :) > >view_all_bug_page did involve a little more code changing to make it nice, >other files will not require logic changes like this - or at least less. I >also de-indented the PHP comments in the file to remove unecessary blank >lines in the HTML output. And honoring Julians comment I reduced the >number of times the code switches in and out of PHP mode on that page. > >Let me know if you guys want me to commit any of this and if you want me >to continue at all... I glanced over it. It all looks good, although I'm not so sure about some of the things are you doing. However, if the layout stays the same... Jeroen |