From: Julian F. <ju...@be...> - 2003-03-03 21:25:10
|
I didn't mean localizing it was bad. I meant storing the localized string in the db was bad (which is what I thought that code was doing). As it turns out Andre was apparently doing exactly what I was saying we should do. Julian Kenzaburo Ito wrote: > I think it's a good thing to localize history. If I'm Japanese and I see > "Assigned" it might mean nothing to me and that defeats the purpose of the > history. When you key it make sure it's keyed of the table column names. > > Thanks, > -Ken > > >>in...@us... wrote: >> >>>Update of /cvsroot/mantisbt/mantisbt/core >>>In directory sc8-pr-cvs1:/tmp/cvs-serv16033/core >>> >>>Modified Files: >>> history_api.php >>>Log Message: >>>* core/history_api.php: >>> (history_get_events_array): Added code to lookup field names in >>> language files. >>> >>>* doc/Changelog: >>> Added bug history enhacement. >> >> >>I don't think this change makes sense. It's a bit like >>internationalizing the prefix on docouments when they are saved. You're >>going to end up with a mixture of different languages history table >>depending on what user made the change. This is worse than having a >>consistent language in my opinion. >> >>To do this properly we need to store some token in the database and use >>that token to look up the localized string when we display the history. >> >>I would actually vote to revert this change for now, but I'm open to >>other opinions. >> >>Julian > > > > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Mantisbt-dev mailing list > Man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev -- ju...@be... Beta4 Productions (http://www.beta4.com) |