From: <gi...@ma...> - 2010-09-22 09:36:00
|
The branch, master-1.2.x has been updated via 922d605cddcc0ec8e646b62702d6446bdad34acb (commit) from d65402a4f61959cb088ae18c7364efcbda25164c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 922d605cddcc0ec8e646b62702d6446bdad34acb Author: David Hicks <hic...@op...> Date: Wed Sep 22 19:14:03 2010 +1000 Fix #9663: Roadmap underlines incorrect lengths The text underlines on the roadmap page are displayed with an incorrect length when the version name contains characters that are encodable via htmlspecialchars(). We need to use the length of the raw string instead of the length of the encoded string. Thanks to Roland Becker for the initial patch for this issue. ----------------------------------------------------------------------- Summary of changes: roadmap_page.php | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) ----------------------------------------------------------------------- commit 922d605cddcc0ec8e646b62702d6446bdad34acb Author: David Hicks <hic...@op...> Date: Wed Sep 22 19:14:03 2010 +1000 Fix #9663: Roadmap underlines incorrect lengths The text underlines on the roadmap page are displayed with an incorrect length when the version name contains characters that are encodable via htmlspecialchars(). We need to use the length of the raw string instead of the length of the encoded string. Thanks to Roland Becker for the initial patch for this issue. diff --git a/roadmap_page.php b/roadmap_page.php index 5ef5691..c0456b6 100644 --- a/roadmap_page.php +++ b/roadmap_page.php @@ -34,7 +34,6 @@ $t_version_name = $p_version_row['version']; $t_project_name = project_get_field( $t_project_id, 'name' ); - $t_release_title_without_hyperlinks = string_display_line( $t_project_name ) . ' - ' . string_display_line( $t_version_name ); $t_release_title = '<a href="roadmap_page.php?project_id=' . $t_project_id . '">' . string_display_line( $t_project_name ) . '</a> - <a href="roadmap_page.php?version_id=' . $t_version_id . '">' . string_display_line( $t_version_name ) . '</a>'; if ( config_get( 'show_roadmap_dates' ) ) { @@ -48,7 +47,7 @@ echo '<tt>'; echo '<br />', $t_release_title, $t_scheduled_release_date, lang_get( 'word_separator' ), print_bracket_link( 'view_all_set.php?type=1&temporary=y&' . FILTER_PROPERTY_PROJECT_ID . '=' . $t_project_id . '&' . filter_encode_field_and_value( FILTER_PROPERTY_TARGET_VERSION, $t_version_name ), lang_get( 'view_bugs_link' ) ), '<br />'; - $t_release_title_without_hyperlinks .= $t_scheduled_release_date; + $t_release_title_without_hyperlinks = $t_project_name . ' - ' . $t_version_name . $t_scheduled_release_date; echo utf8_str_pad( '', utf8_strlen( $t_release_title_without_hyperlinks ), '=' ), '<br />'; } ----------------------------------------------------------------------- -- Mantis Bug Tracker |