I think for 3rd party libraries we should report upstream.  If the bug is important and needs to be addressed sooner than the likelihood of getting the upstream fix, then I believe we should fix it in our codebase.  However, we should make sure that we can discover these fixes and re-apply the appropriate ones when we apply a new version of the library (in this case ADODB).

My suggestion is to consider doing that through git sub-modules.  In such case, we will do the following:

1. Fork the ADODB git repository if available, otherwise, create one on github.
2. Apply our fixes there on a branch (e.g. mantisbt-1.2.x, mantisbt-1.1x, etc).
3. Link our ADODB repository into our mantisbt repository.

This will allow us to get the flexibility we need, be able to easily enumerate our changes, have different changes per major branch, and will also allow other teams to potentially use our version of ADODB if that makes sense to them.  It will also allow us to easily send pull-requests for those who support it.

Just my 2c. 

On Tue, Oct 25, 2011 at 10:26 AM, Damien Regad <damien.regad@merckgroup.com> wrote:
Hi all,

While working on the oracle branch, I stumbled upon what I think is a
bug in ADOdb [1]. I have submitted a bug report upstream on the ADOdb
forums (no feedback so far).

Moving forward as this is blocking for getting oracle to work, I wanted
to know if it is OK on principle to commit Mantis-specific changes to
the ADOdb library.

Thanks in advance for your reply.

[1] http://www.mantisbt.org/bugs/view.php?id=13438

The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
mantisbt-dev mailing list