If I recall correctly, in 2.x i've removed this function completely - there's no reason a script can't have an additional account an just send a password.

Might be worth applying the same behaviour to 1.3 rather then confusing things later on.

Paul


On Sun, Jun 30, 2013 at 9:07 PM, Robert Munteanu <robert.munteanu@gmail.com> wrote:
Hi,

I'm looking at an enhancement request + patch

15869: API call mc_login with valid LDAP user which is not in mantis
DB -> result: login failed
http://www.mantisbt.org/bugs/view.php?id=15869

The proposed patch starts to make auth_attempt_script_login look more
like auth_attempt_login. However, I started wondering why we have two
versions of the function call.

The are many differences between the two, but the only ones that I
think should remain are:

1. Do not increment login count with the script variant
2. The cookie settings must be different

Notably, user auto-creation and incrementing failed login counts
should work for both functions IMO.

As such, I'm considering unifying the two functions, making them call
a utility function which takes the parameters needed to change it
behaviour ( e.g. $p_is_script );

Thoughts?

Robert

--
http://robert.muntea.nu/

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
mantisbt-dev mailing list
mantisbt-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev