On 26/10/11 08:45, David Hicks wrote:I think that horse is not dead yet...
> I wouldn't expect a new release of ADOdb any time soon. It's legacy
> software and doesn't get used as much as it used to.
According to the sourceforge download page  a new version 5.14 was
released on Sept 8th, and that's the 4th release since the version we
have bundled with Mantis (5.10, dated Nov 2009)
> The problem arises with distro packaging of MantisBT where bundled
> libraries such as ADOdb, PHPMailer, etc are removed from the MantisBT
> package and replaced with separate system-wide packages. This is the
> correct thing to do and it should be our aim to assist distros by
> continually trying to remove bundled libraries.
> trying to avoid branching our bundled libraries from upstreamI don't think we comply with this today. According to
> because it makes it very difficult to know which patches need reapplying
> when it comes time to updating the bundled libraries to match new
> upstream releases. At one point I think I was also committing the
> patches as well, just to make the update process easier.
./library/adodb/readme_mantis.txt, there have already been some changes
made to the library. This is confirmed by comparing downloaded 5.10
library from sourceforge with 1.2.x HEAD:
$ diff -qrwB adodb5.10 ~/dev/mantisbt/library/adodb |grep -v ^Only
Files adodb5.10/adodb-datadict.inc.php and
Files adodb5.10/adodb.inc.php and
Files adodb5.10/datadict/datadict-mssql.inc.php and
Files adodb5.10/datadict/datadict-mssqlnative.inc.php and
Files adodb5.10/datadict/datadict-postgres.inc.php and
Files adodb5.10/drivers/adodb-db2.inc.php and
Files adodb5.10/drivers/adodb-mysqli.inc.php and
Files adodb5.10/drivers/adodb-odbc.inc.php and
Files adodb5.10/drivers/adodb-odbc_mssql.inc.php and
Files adodb5.10/drivers/adodb-pdo.inc.php and
Files adodb5.10/drivers/adodb-postgres64.inc.php and
Files adodb5.10/drivers/adodb-sapdb.inc.php and
I haven't looked into full detail for all these differences, but I'm
quite sure that if distros use a "vanilla" version of ADOdb Mantis will
break considering the amount of changes made (added function params,
lots of added code for DB-specific drivers...)
So if patching a bundled lib is not possible, is there anything else
other than reporting upstream (which is already done), that I can do to
resolve the issue ?
Victor's idea of using git submodules for traceability sounds good as it
would offer traceability, but
- I did not find an "official" source repository of ADOdb (the CVS on
sourceforge is completely out-of-date), there is a slightly outdated one
on github  but it seems specific to the owner's project
- Is it worth the effort of building this, considering the intent of
moving away from ADOdb, as mentioned by David ? If we are not likely to
upgrade to a later version of ADOdb, then I would say no.
Bottomline is, based on the fact that ADOdb library is already
customized, I am not sure one more change would be a huge issue, keeping
in mind that without this fix, it will not be possible to implement
support for oracle as the generation of schema upgrade SQL script fails.
Let me know your thoughts.
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
mantisbt-dev mailing list