Hi Robert,

The changes look good.  Here are some comments:

1. In the search parameters, shouldn't the project id be an integer array?  This is to be able to support advanced filters, similar to you using IntegerArray for properties like priority and severity.

2. You have a TODO to filter the data based on user access? Shouldn't this happen automatically by the filter api since you are logged in as the user?

3. I can see there is a way to specify the number of issues per page, but there is no way to specify the page number.

4. Should we have an upper limit for these methods relating to the issues per page to avoid failures due to memory issues?

5. Why mc_filter_search_issue_headers() rather than mc_filter_search()?

On Sun, Feb 20, 2011 at 6:28 AM, Robert Munteanu <robert.munteanu@gmail.com> wrote:
Hi,

I have started implementing the changes required to support custom
filters in the SOAP API. My current changes, rebased on top of the
master branch are found at https://github.com/rombert/mantisbt .
Comments are most welcome.

Thanks,

Robert

--
Sent from my (old) computer

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
mantisbt-dev mailing list
mantisbt-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev