Fixes for errors Static code analysis. strdup memleaks and fd check after fopen

make a small dumpfile of kdump

Brought to you by: k-hagio

This project can now be found here.

#7 Fixes for errors Static code analysis. strdup memleaks and fd check after fopen

Milestone: Next_Release_(example)

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2019-02-12

Created: 2019-02-05

Creator: Nisha Parrakat

Private: No

cleaning up makedumpfile for possible memory leaks that were found in cppcheck and codesonar.
Fixing a typo in check of a file pointer for NULL after attempted fopen.

2 Attachments

fix_file_open_fail_ptr_check.patch

fix_memory_leaks_from_cppcheck.patch

Discussion

Kazuhito Hagio - 2019-02-05

Thanks for your patches.
But we don't use the sourceforge ticket facility now.
Patches should be normally posted to the kexec mailing list for general review.
http://lists.infradead.org/mailman/listinfo/kexec

Could you post them to the mailling list?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kazuhito Hagio - 2019-02-11

If you don't subscribe to the kexec ML, can I post your patches to it on behalf of you?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nisha Parrakat - 2019-02-12

Hi Kazuhito,
I did subscribe to the list but couldn't get any email back. Yes please go ahead and post my patches.
I will be thankful.
Regards,
Ms Nisha Parrakat
KPIT Technologies GmbH

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nisha Parrakat - 2019-02-12

HI Kazu,
Finally I could post the patches to the kexec mailing list.

regards
Nisha Parrakat

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kazuhito Hagio - 2019-02-12

Hi Nisha,

Thank you for posting.
But I don't see your patches on the kexec mailing list yet.
They might be held by the list system, which has a bit strict check.

If they are not sent after a while, I'll post them on behalf of you.

Thanks,
Kazu

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.