The patch seems good except if SMTP_USE_TLS is set True in mm_cfg.py, the patch references mm_cfg.SMTP_HELO_HOST which is neither defined nor documented in the patch.
Perhaps the patch to Defaults.py.in should include something like
SMTP_HELO_HOST = DEFAULT_EMAIL_HOST
or even
SMTP_HELO_HOST = ''
and some comments describing what all the new variables are.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=1123998
Originator: NO
The patch seems good except if SMTP_USE_TLS is set True in mm_cfg.py, the patch references mm_cfg.SMTP_HELO_HOST which is neither defined nor documented in the patch.
Perhaps the patch to Defaults.py.in should include something like
SMTP_HELO_HOST = DEFAULT_EMAIL_HOST
or even
SMTP_HELO_HOST = ''
and some comments describing what all the new variables are.
SMTP and TLS support for Mailman 2; new patch
Logged In: YES
user_id=1869522
Originator: YES
You're right, I forgot to define SMTP_HELO_HOST. I'm uploading the updated patch.
File Added: mailman-smtpauth.patch