Menu

#1210 admlogin.html puts "MailmanLogo" *after* the </body></html>

open
nobody
None
5
2008-01-03
2008-01-03
Trent Mick
No

Mailman version: 2.1.9

The admlogin.html page puts the MailmanLogo() generated footer content *after* the close of the "body" and "html" tags. E.g.:

http://mail.python.org/mailman/admin/mailman-users

----------------------------
...
</FORM> </body> </html>

<hr><address><a
href="http://mail.python.org/mailman/listinfo/mailman-users">Mailman-Users</a>
list run by <a href="mailto:mailman-users-owner@python.org">barry at list.org,
brad at python.org</a><br><a
href="http://mail.python.org/mailman/admin/mailman-users">Mailman-Users
administrative interface</a> (requires authorization)<br><a
href="http://mail.python.org/mailman/listinfo">Overview of all python.org
mailing lists</a><p>
<table WIDTH="100%" BORDER="0">
<tr>
<td><img src="/icons/mailman.jpg" alt="Delivered by Mailman"
border=0><br>version 2.1.9</td>

<td><img src="/icons/PythonPowered.png" alt="Python Powered" border=0></td>
<td><img src="/icons/gnu-head-tiny.jpg" alt="GNU's Not Unix" border=0></td>
</tr>
</table>
</address>
----------------------------

Although browsers tend to handle this broken HTML, it foils attempts to use Apache mod_layout to add a footer (because it looks for </body> and insert footer content there.

See this bug for more details:
http://bugs.activestate.com/show_bug.cgi?id=73613
(It is a bug documenting the broken result attempting to use Apache mod_layout with this on a mailman installation for openkomodo.com.)

From that bug:
--------------------------
...
The right answer would be to use the "<mm-mailman-footer>" template marker in
the "admlogin.html" template **however**, that won't work because
"admlogin.html" is using a different template mechanism than some of the other
".html" files in there. "<mm-mailman-footer>" will get replaced in, e.g.,
"listinfo.html", but not in "admlogin.html"
...
--------------------------

Discussion


Log in to post a comment.