[Madwifi-devel] ath_rate in DadWifi - broken or unneeded?

[Pavel R. <pr...@gn...>]

Hi, David!

As you probably have noticed, I have unified the build system across the
MadWifi branches.  I marked ath_rate as "broken" in dadwifi and
dadwifi-openhal (in patches/2.6/Kconfig), but I think I was wrong.  It
looks like the rate control algorithms belong to the 802.11 stack, not
to the driver.  If the rate control algorithms from MadWifi are to be
ported to to the kernel it would be a separate effort, not part of
DadWifi.

Is that correct?  Then I would simply exclude all references to ath_rate
from the build system.

By the way, I'll appreciate if you check ar5k_ar5212_set_bssid_mask() in
dadwifi-openhal.  The function tries to write a pointer to the
registers.  That's wrong.  Generally, PCI devices should get bus
addresses for DMA, whereas kernel pointers are virtual addresses.  And
in this particular case, we should probably write the data pointed to by
the pointer.

-- 
Regards,
Pavel Roskin