Thread: [Madwifi-devel] [PATCH] fix type warning message in madwifi/ath/if_ath_pci.c
Status: Beta
Brought to you by:
otaku
From: Lukas R. <ru...@ra...> - 2006-01-24 10:09:54
Attachments:
pm_message_t.diff
|
Dear all, please find attached a minor patch that fixes a compile-time type error message in madwifi/ath/if_ath_pci.c for 2.6.15. wbr, Lukas -- Lukas Ruf <http://www.lpr.ch> | Ad Personam rbacs <http://wiki.lpr.ch> | Restaurants, Bars and Clubs Raw IP <http://www.rawip.org> | Low Level Network Programming Style <http://email.rawip.org> | How to write emails |
From: Kel M. <ke...@tp...> - 2006-01-25 04:50:54
|
Lukas Ruf wrote: >Dear all, > >please find attached a minor patch that fixes a compile-time type >error message in madwifi/ath/if_ath_pci.c for 2.6.15. > >wbr, >Lukas > > > > Hi Lukas, I notice this has also been done in a few other out of kernels modules recently. >------------------------------------------------------------------------ > >Index: madwifi/ath/if_ath_pci.c >=================================================================== >--- madwifi/ath/if_ath_pci.c (revision 1412) >+++ madwifi/ath/if_ath_pci.c (working copy) >@@ -55,6 +55,10 @@ > > #include <linux/pci.h> > >+#ifdef CONFIG_PM >+#include <linux/pm.h> >+#endif >+ > #include <asm/uaccess.h> > > #include "if_media.h" >@@ -253,7 +257,7 @@ > > #ifdef CONFIG_PM > static int >-ath_pci_suspend(struct pci_dev *pdev, u32 state) >+ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) > { > struct net_device *dev = pci_get_drvdata(pdev); > > > Maybe you need to do similar to:- #ifdef CONFIG_PM #include <linux/pm.h> #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) #ifndef pm_message_t #define pm_message_t u32 #endif #endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) */ #endif for compatibility with 2.4 kernels? (just a thought from looking at what the rt2x00 devs just did for rt2500) For inclusion of your patch in MadWifi, you'd have to "Sign-off" to signify that you agree to the terms/license that MadWifi is distributed under. A simple reply or comment along with your patch would suffice. Please see the following page for a brief description of why this is required:- http://madwifi.org/wiki/DevDocs/SigningPatches Thanks, Kel. |
From: Lukas R. <ru...@ra...> - 2006-01-25 14:58:19
|
Hi Kel, > Kel Modderman <ke...@tp...> [2006-01-25 05:51]: > > > Maybe you need to do similar to:- > > #ifdef CONFIG_PM > #include <linux/pm.h> > #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) > #ifndef pm_message_t > #define pm_message_t u32 > #endif > #endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) */ > #endif > > for compatibility with 2.4 kernels? (just a thought from looking at what > the rt2x00 devs just did for rt2500) > > For inclusion of your patch in MadWifi, you'd have to "Sign-off" to > signify that you agree to the terms/license that MadWifi is distributed > under. A simple reply or comment along with your patch would suffice. > Please see the following page for a brief description of why this is > required:- > > http://madwifi.org/wiki/DevDocs/SigningPatches > Thanks. For the hints! I will re-send the patch with the required statements and your suggested extension. wbr, Lukas -- Lukas Ruf <http://www.lpr.ch> | Ad Personam rbacs <http://wiki.lpr.ch> | Restaurants, Bars and Clubs Raw IP <http://www.rawip.org> | Low Level Network Programming Style <http://email.rawip.org> | How to write emails |
From: Lukas R. <ru...@ra...> - 2006-01-25 15:02:29
Attachments:
pm_message_t.diff
|
Dear all, > Lukas Ruf <ru...@ra...> [2006-01-24 11:10]: > > please find attached a minor patch that fixes a compile-time type > error message in madwifi/ath/if_ath_pci.c for 2.6.15. > The attached path fixes a compile-time type-warning message in madwifi/ath/if_ath_pci.c. For compatibility with Linux 2.4 kernels, it adds the appropriate defines as suggested by Kel Modderman. Signed-off-by: Lukas Ruf <ru...@ra...> -- Lukas Ruf <http://www.lpr.ch> | Ad Personam rbacs <http://wiki.lpr.ch> | Restaurants, Bars and Clubs Raw IP <http://www.rawip.org> | Low Level Network Programming Style <http://email.rawip.org> | How to write emails |
From: Kel M. <ke...@tp...> - 2006-01-26 04:52:14
|
Lukas Ruf wrote: >Dear all, > > > >>Lukas Ruf <ru...@ra...> [2006-01-24 11:10]: >> >>please find attached a minor patch that fixes a compile-time type >>error message in madwifi/ath/if_ath_pci.c for 2.6.15. >> >> >> > >The attached path fixes a compile-time type-warning message >in madwifi/ath/if_ath_pci.c. For compatibility with Linux 2.4 >kernels, it adds the appropriate defines as suggested by Kel >Modderman. > >Signed-off-by: Lukas Ruf <ru...@ra...> > > > >------------------------------------------------------------------------ > >Index: madwifi/ath/if_ath_pci.c >=================================================================== >--- madwifi/ath/if_ath_pci.c (revision 1415) >+++ madwifi/ath/if_ath_pci.c (working copy) >@@ -55,6 +55,16 @@ > > #include <linux/pci.h> > >+#ifdef CONFIG_PM >+#include <linux/pm.h> >+#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) >+#ifndef pm_message_t >+#define pm_message_t u32 >+#endif /* pm_message_t */ >+#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) */ >+#endif /* CONFIG_PM */ >+ >+ > #include <asm/uaccess.h> > > #include "if_media.h" >@@ -253,7 +263,7 @@ > > #ifdef CONFIG_PM > static int >-ath_pci_suspend(struct pci_dev *pdev, u32 state) >+ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) > { > struct net_device *dev = pci_get_drvdata(pdev); > > > Just as soon as I had replied, the rt2x00 devs just removed the check for (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) which makes sense because: #ifndef pm_message_t #define pm_message_t u32 #endif /* pm_message_t */ should be sufficient to catch the lack of pm_message_t, no? I thought it looked a bit crowded when i sent that advise to you . . . Thanks, Kel. |
From: Kel M. <ke...@tp...> - 2006-01-26 05:06:04
|
Kel Modderman wrote: > Lukas Ruf wrote: > >> Dear all, >> >> >> >>> Lukas Ruf <ru...@ra...> [2006-01-24 11:10]: >>> >>> please find attached a minor patch that fixes a compile-time type >>> error message in madwifi/ath/if_ath_pci.c for 2.6.15. >>> >>> >> >> >> The attached path fixes a compile-time type-warning message >> in madwifi/ath/if_ath_pci.c. For compatibility with Linux 2.4 >> kernels, it adds the appropriate defines as suggested by Kel >> Modderman. >> >> Signed-off-by: Lukas Ruf <ru...@ra...> >> >> >> >> ------------------------------------------------------------------------ >> >> Index: madwifi/ath/if_ath_pci.c >> =================================================================== >> --- madwifi/ath/if_ath_pci.c (revision 1415) >> +++ madwifi/ath/if_ath_pci.c (working copy) >> @@ -55,6 +55,16 @@ >> >> #include <linux/pci.h> >> >> +#ifdef CONFIG_PM >> +#include <linux/pm.h> >> +#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) >> +#ifndef pm_message_t >> +#define pm_message_t u32 >> +#endif /* pm_message_t */ >> +#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) */ >> +#endif /* CONFIG_PM */ >> + >> + >> #include <asm/uaccess.h> >> >> #include "if_media.h" >> @@ -253,7 +263,7 @@ >> >> #ifdef CONFIG_PM >> static int >> -ath_pci_suspend(struct pci_dev *pdev, u32 state) >> +ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) >> { >> struct net_device *dev = pci_get_drvdata(pdev); >> >> >> > Just as soon as I had replied, the rt2x00 devs just removed the check > for (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) which makes sense > because: > > #ifndef pm_message_t > #define pm_message_t u32 > #endif /* pm_message_t */ > > should be sufficient to catch the lack of pm_message_t, no? I thought > it looked a bit crowded when i sent that advise to you . . . > > Thanks, Kel. > > . . . and it makes it even worse advice that ath/if_ath_pci.h already has: #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) #define pm_message_t u32 #endif Sorry for the stuff around. Kel |
From: Kel M. <ke...@tp...> - 2006-01-26 05:10:51
|
Kel Modderman wrote: > Kel Modderman wrote: > >> Lukas Ruf wrote: >> >>> Dear all, >>> >>> >>> >>>> Lukas Ruf <ru...@ra...> [2006-01-24 11:10]: >>>> >>>> please find attached a minor patch that fixes a compile-time type >>>> error message in madwifi/ath/if_ath_pci.c for 2.6.15. >>>> >>>> >>> >>> >>> >>> The attached path fixes a compile-time type-warning message >>> in madwifi/ath/if_ath_pci.c. For compatibility with Linux 2.4 >>> kernels, it adds the appropriate defines as suggested by Kel >>> Modderman. >>> >>> Signed-off-by: Lukas Ruf <ru...@ra...> >>> >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> Index: madwifi/ath/if_ath_pci.c >>> =================================================================== >>> --- madwifi/ath/if_ath_pci.c (revision 1415) >>> +++ madwifi/ath/if_ath_pci.c (working copy) >>> @@ -55,6 +55,16 @@ >>> >>> #include <linux/pci.h> >>> >>> +#ifdef CONFIG_PM >>> +#include <linux/pm.h> >>> +#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) >>> +#ifndef pm_message_t >>> +#define pm_message_t u32 >>> +#endif /* pm_message_t */ >>> +#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) */ >>> +#endif /* CONFIG_PM */ >>> + >>> + >>> #include <asm/uaccess.h> >>> >>> #include "if_media.h" >>> @@ -253,7 +263,7 @@ >>> >>> #ifdef CONFIG_PM >>> static int >>> -ath_pci_suspend(struct pci_dev *pdev, u32 state) >>> +ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) >>> { >>> struct net_device *dev = pci_get_drvdata(pdev); >>> >>> >>> >> Just as soon as I had replied, the rt2x00 devs just removed the check >> for (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) which makes sense >> because: >> >> #ifndef pm_message_t >> #define pm_message_t u32 >> #endif /* pm_message_t */ >> >> should be sufficient to catch the lack of pm_message_t, no? I thought >> it looked a bit crowded when i sent that advise to you . . . >> >> Thanks, Kel. >> >> > > . . . and it makes it even worse advice that ath/if_ath_pci.h already > has: > > #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) > #define pm_message_t u32 > #endif > > Sorry for the stuff around. > > Kel I think maybe we are looking at different branches of svn! You must be looking at madwifi-old, in which case i can see how your patch works :-) I assumed the patch was targeted at madwifi svn trunk . . . Kel. |
From: Kel M. <ke...@tp...> - 2006-01-26 05:36:59
|
So, after the initial confusion, the following patch works and is basically the same as in madwifi svn trunk:- diff -Nru madwifi.orig/ath/if_ath_pci.c madwifi/ath/if_ath_pci.c --- madwifi.orig/ath/if_ath_pci.c 2006-01-26 15:32:22.459575800 +1000 +++ madwifi/ath/if_ath_pci.c 2006-01-26 15:31:49.306615816 +1000 @@ -253,7 +253,7 @@ #ifdef CONFIG_PM static int -ath_pci_suspend(struct pci_dev *pdev, u32 state) +ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) { struct net_device *dev = pci_get_drvdata(pdev); diff -Nru madwifi.orig/ath/if_ath_pci.h madwifi/ath/if_ath_pci.h --- madwifi.orig/ath/if_ath_pci.h 2006-01-26 15:32:22.470574128 +1000 +++ madwifi/ath/if_ath_pci.h 2006-01-26 15:29:28.832971056 +1000 @@ -60,4 +60,8 @@ #define BUS_DMA_FROMDEVICE PCI_DMA_FROMDEVICE #define BUS_DMA_TODEVICE PCI_DMA_TODEVICE +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) +#define pm_message_t u32 +#endif + #endif /* _DEV_ATH_PCI_H_ */ If that looks okay we can look at getting that into the mawifi-old branch. Lukas, apologies for the excessive noise about this issue. Thanks, Kel. |
From: Lukas R. <ru...@ra...> - 2006-01-26 07:54:25
|
Kel, > Kel Modderman <ke...@tp...> [2006-01-26 06:37]: > > So, after the initial confusion, the following patch works and is > basically the same as in madwifi svn trunk:- > > diff -Nru madwifi.orig/ath/if_ath_pci.c madwifi/ath/if_ath_pci.c > --- madwifi.orig/ath/if_ath_pci.c 2006-01-26 15:32:22.459575800 +1000 > +++ madwifi/ath/if_ath_pci.c 2006-01-26 15:31:49.306615816 +1000 > @@ -253,7 +253,7 @@ > > #ifdef CONFIG_PM > static int > -ath_pci_suspend(struct pci_dev *pdev, u32 state) > +ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) > { > struct net_device *dev = pci_get_drvdata(pdev); > > diff -Nru madwifi.orig/ath/if_ath_pci.h madwifi/ath/if_ath_pci.h > --- madwifi.orig/ath/if_ath_pci.h 2006-01-26 15:32:22.470574128 +1000 > +++ madwifi/ath/if_ath_pci.h 2006-01-26 15:29:28.832971056 +1000 > @@ -60,4 +60,8 @@ > #define BUS_DMA_FROMDEVICE PCI_DMA_FROMDEVICE > #define BUS_DMA_TODEVICE PCI_DMA_TODEVICE > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) > +#define pm_message_t u32 > +#endif > + > #endif /* _DEV_ATH_PCI_H_ */ > > If that looks okay we can look at getting that into the mawifi-old branch. > yup. > Lukas, apologies for the excessive noise about this issue. > no problem. Thanks. wbr, Lukas -- Lukas Ruf <http://www.lpr.ch> | Ad Personam rbacs <http://wiki.lpr.ch> | Restaurants, Bars and Clubs Raw IP <http://www.rawip.org> | Low Level Network Programming Style <http://email.rawip.org> | How to write emails |
From: Kel M. <ke...@tp...> - 2006-01-27 13:46:40
|
Lukas Ruf wrote: >Kel, > > > >>Kel Modderman <ke...@tp...> [2006-01-26 06:37]: >> >>So, after the initial confusion, the following patch works and is >>basically the same as in madwifi svn trunk:- >> >>diff -Nru madwifi.orig/ath/if_ath_pci.c madwifi/ath/if_ath_pci.c >>--- madwifi.orig/ath/if_ath_pci.c 2006-01-26 15:32:22.459575800 +1000 >>+++ madwifi/ath/if_ath_pci.c 2006-01-26 15:31:49.306615816 +1000 >>@@ -253,7 +253,7 @@ >> >>#ifdef CONFIG_PM >>static int >>-ath_pci_suspend(struct pci_dev *pdev, u32 state) >>+ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) >>{ >> struct net_device *dev = pci_get_drvdata(pdev); >> >>diff -Nru madwifi.orig/ath/if_ath_pci.h madwifi/ath/if_ath_pci.h >>--- madwifi.orig/ath/if_ath_pci.h 2006-01-26 15:32:22.470574128 +1000 >>+++ madwifi/ath/if_ath_pci.h 2006-01-26 15:29:28.832971056 +1000 >>@@ -60,4 +60,8 @@ >>#define BUS_DMA_FROMDEVICE PCI_DMA_FROMDEVICE >>#define BUS_DMA_TODEVICE PCI_DMA_TODEVICE >> >>+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) >>+#define pm_message_t u32 >>+#endif >>+ >>#endif /* _DEV_ATH_PCI_H_ */ >> >>If that looks okay we can look at getting that into the mawifi-old branch. >> >> >> > >yup. > > > >>Lukas, apologies for the excessive noise about this issue. >> >> >> > >no problem. Thanks. > > >wbr, >Lukas > > Lukas, Patch applied to branches/madwifi-old of madwifi.org svn. Thanks, Kel. |
From: <mig...@ya...> - 2006-01-30 10:59:24
|
Kel Modderman escribi=F3: > Lukas Ruf wrote: > >> Kel, >> >> =20 >> >>> Kel Modderman <ke...@tp...> [2006-01-26 06:37]: >>> >>> So, after the initial confusion, the following patch works and is >>> basically the same as in madwifi svn trunk:- >>> >>> diff -Nru madwifi.orig/ath/if_ath_pci.c madwifi/ath/if_ath_pci.c >>> --- madwifi.orig/ath/if_ath_pci.c 2006-01-26 15:32:22.45957580= 0=20 >>> +1000 >>> +++ madwifi/ath/if_ath_pci.c 2006-01-26 15:31:49.306615816 +10= 00 >>> @@ -253,7 +253,7 @@ >>> >>> #ifdef CONFIG_PM >>> static int >>> -ath_pci_suspend(struct pci_dev *pdev, u32 state) >>> +ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) >>> { >>> struct net_device *dev =3D pci_get_drvdata(pdev); >>> >>> diff -Nru madwifi.orig/ath/if_ath_pci.h madwifi/ath/if_ath_pci.h >>> --- madwifi.orig/ath/if_ath_pci.h 2006-01-26 15:32:22.47057412= 8=20 >>> +1000 >>> +++ madwifi/ath/if_ath_pci.h 2006-01-26 15:29:28.832971056 +10= 00 >>> @@ -60,4 +60,8 @@ >>> #define BUS_DMA_FROMDEVICE PCI_DMA_FROMDEVICE >>> #define BUS_DMA_TODEVICE PCI_DMA_TODEVICE >>> >>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) >>> +#define pm_message_t u32 >>> +#endif >>> + >>> #endif /* _DEV_ATH_PCI_H_ */ >>> >>> If that looks okay we can look at getting that into the mawifi-ol= d=20 >>> branch. >>> >>> =20 >> >> >> yup. >> >> =20 >> >>> Lukas, apologies for the excessive noise about this issue. >>> >>> =20 >> >> >> no problem. Thanks. >> >> >> wbr, >> Lukas >> =20 >> > Lukas, > > Patch applied to branches/madwifi-old of madwifi.org svn. > > Thanks, Kel. > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through = log=20 > files > for problems? Stop! Download the new AJAX search engine that make= s > searching your log files as easy as surfing the web. DOWNLOAD SPL= UNK! > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D103432&bid=3D230486= &dat=3D121642 > _______________________________________________ > Madwifi-devel mailing list > Mad...@li... > https://lists.sourceforge.net/lists/listinfo/madwifi-devel > Is this patch meant to solve this issue? : if_ath.c:45:20: opt_ah.h: File or directory does not exist If so, I have tried with kernel source 2.4.32 and patched using modul= es=20 and not modules support and I always the message before. My dmesg is the following: ath_hal: 0.9.14.9 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413) ath_rate_onoe: 1.0 ath_pci: 0.9.6.0 (EXPERIMENTAL) Build date: Jan 23 2006 Debugging version (IEEE80211) ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps= =20 24Mbps 36Mbps 48Mbps 54Mbps ath0: H/W encryption support: WEP AES AES_CCM TKIP ath0: mac 7.8 phy 4.5 radio 5.6 ath0: Use hw queue 1 for WME_AC_BE traffic ath0: Use hw queue 0 for WME_AC_BK traffic ath0: Use hw queue 2 for WME_AC_VI traffic ath0: Use hw queue 3 for WME_AC_VO traffic ath0: Use hw queue 8 for CAB traffic ath0: Use hw queue 9 for beacons Debugging version (ATH) ath0: Atheros 5212: mem=3D0xebfd0000, irq=3D9 wlan: 0.8.6.0 (EXPERIMENTAL) wlan: mac acl policy registered Any hint that you can give me? I can set my SMCWPCI-G card to 802.11b= =20 modes, not g modes in master mode, I am using madwifi-old driver. In= =20 ad-hoc mode I keep on loosing packets. I would like to help in testing whatever you think I should test with= my=20 card for helping in this project :) Best Regards, Miguel |
From: Kel M. <ke...@tp...> - 2006-01-30 11:11:55
|
Miguel Gonz=E1lez Casta=F1os wrote: > Kel Modderman escribi=F3: > >> Lukas Ruf wrote: >> >>> Kel, >>> >>> =20 >>> >>>> Kel Modderman <ke...@tp...> [2006-01-26 06:37]: >>>> >>>> So, after the initial confusion, the following patch works and is >>>> basically the same as in madwifi svn trunk:- >>>> >>>> diff -Nru madwifi.orig/ath/if_ath_pci.c madwifi/ath/if_ath_pci.c >>>> --- madwifi.orig/ath/if_ath_pci.c 2006-01-26 15:32:22.459575800=20 >>>> +1000 >>>> +++ madwifi/ath/if_ath_pci.c 2006-01-26 15:31:49.306615816 +1000 >>>> @@ -253,7 +253,7 @@ >>>> >>>> #ifdef CONFIG_PM >>>> static int >>>> -ath_pci_suspend(struct pci_dev *pdev, u32 state) >>>> +ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) >>>> { >>>> struct net_device *dev =3D pci_get_drvdata(pdev); >>>> >>>> diff -Nru madwifi.orig/ath/if_ath_pci.h madwifi/ath/if_ath_pci.h >>>> --- madwifi.orig/ath/if_ath_pci.h 2006-01-26 15:32:22.470574128=20 >>>> +1000 >>>> +++ madwifi/ath/if_ath_pci.h 2006-01-26 15:29:28.832971056 +1000 >>>> @@ -60,4 +60,8 @@ >>>> #define BUS_DMA_FROMDEVICE PCI_DMA_FROMDEVICE >>>> #define BUS_DMA_TODEVICE PCI_DMA_TODEVICE >>>> >>>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) >>>> +#define pm_message_t u32 >>>> +#endif >>>> + >>>> #endif /* _DEV_ATH_PCI_H_ */ >>>> >>>> If that looks okay we can look at getting that into the mawifi-old=20 >>>> branch. >>>> >>>> =20 >>> >>> >>> >>> yup. >>> >>> =20 >>> >>>> Lukas, apologies for the excessive noise about this issue. >>>> >>>> =20 >>> >>> >>> >>> no problem. Thanks. >>> >>> >>> wbr, >>> Lukas >>> =20 >>> >> Lukas, >> >> Patch applied to branches/madwifi-old of madwifi.org svn. >> >> Thanks, Kel. >> >> >> ------------------------------------------------------- >> This SF.net email is sponsored by: Splunk Inc. Do you grep through=20 >> log files >> for problems? Stop! Download the new AJAX search engine that makes >> searching your log files as easy as surfing the web. DOWNLOAD SPLUNK= ! >> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D103432&bid=3D230486&da= t=3D121642 >> _______________________________________________ >> Madwifi-devel mailing list >> Mad...@li... >> https://lists.sourceforge.net/lists/listinfo/madwifi-devel >> > Is this patch meant to solve this issue? : > > if_ath.c:45:20: opt_ah.h: File or directory does not exist > No, that patch solves the following issue:- http://madwifi.org/ticket/340 > If so, I have tried with kernel source 2.4.32 and patched using=20 > modules and not modules support and I always the message before. > > My dmesg is the following: > > ath_hal: 0.9.14.9 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413) > ath_rate_onoe: 1.0 > ath_pci: 0.9.6.0 (EXPERIMENTAL) > Build date: Jan 23 2006 > Debugging version (IEEE80211) > ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps > ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps=20 > 24Mbps 36Mbps 48Mbps 54Mbps > ath0: H/W encryption support: WEP AES AES_CCM TKIP > ath0: mac 7.8 phy 4.5 radio 5.6 > ath0: Use hw queue 1 for WME_AC_BE traffic > ath0: Use hw queue 0 for WME_AC_BK traffic > ath0: Use hw queue 2 for WME_AC_VI traffic > ath0: Use hw queue 3 for WME_AC_VO traffic > ath0: Use hw queue 8 for CAB traffic > ath0: Use hw queue 9 for beacons > Debugging version (ATH) > ath0: Atheros 5212: mem=3D0xebfd0000, irq=3D9 > wlan: 0.8.6.0 (EXPERIMENTAL) > wlan: mac acl policy registered > > Any hint that you can give me? I can set my SMCWPCI-G card to 802.11b=20 > modes, not g modes in master mode, I am using madwifi-old driver. In=20 > ad-hoc mode I keep on loosing packets. > > I would like to help in testing whatever you think I should test with=20 > my card for helping in this project :) > > Best Regards, > > Miguel No, unfortunately I have no idea what your problem is. Thanks, Kel. |
From: Lukas R. <ru...@ra...> - 2006-01-26 07:51:46
|
Kel, > Kel Modderman <ke...@tp...> [2006-01-26 06:11]: > [...] > > > I think maybe we are looking at different branches of svn! You must > be looking at madwifi-old, in which case i can see how your patch > works :-) > > I assumed the patch was targeted at madwifi svn trunk . . . > ok, I see. in my understanding, my madwifi corresponds with your madwifi old while my madwifi ng corresponds with your madwifi trunk Sorry for the confusion. wbr, Lukas -- Lukas Ruf <http://www.lpr.ch> | Ad Personam rbacs <http://wiki.lpr.ch> | Restaurants, Bars and Clubs Raw IP <http://www.rawip.org> | Low Level Network Programming Style <http://email.rawip.org> | How to write emails |
From: <mig...@ya...> - 2006-01-30 11:19:55
|
Kel Modderman escribi=F3: > Miguel Gonz=E1lez Casta=F1os wrote: > >> Kel Modderman escribi=F3: >> >>> Lukas Ruf wrote: >>> >>>> Kel, >>>> >>>> =20 >>>> >>>>> Kel Modderman <ke...@tp...> [2006-01-26 06:37]: >>>>> >>>>> So, after the initial confusion, the following patch works and = is >>>>> basically the same as in madwifi svn trunk:- >>>>> >>>>> diff -Nru madwifi.orig/ath/if_ath_pci.c madwifi/ath/if_ath_pci.= c >>>>> --- madwifi.orig/ath/if_ath_pci.c 2006-01-26 15:32:22.459575= 800=20 >>>>> +1000 >>>>> +++ madwifi/ath/if_ath_pci.c 2006-01-26 15:31:49.306615816 += 1000 >>>>> @@ -253,7 +253,7 @@ >>>>> >>>>> #ifdef CONFIG_PM >>>>> static int >>>>> -ath_pci_suspend(struct pci_dev *pdev, u32 state) >>>>> +ath_pci_suspend(struct pci_dev *pdev, pm_message_t state) >>>>> { >>>>> struct net_device *dev =3D pci_get_drvdata(pdev); >>>>> >>>>> diff -Nru madwifi.orig/ath/if_ath_pci.h madwifi/ath/if_ath_pci.= h >>>>> --- madwifi.orig/ath/if_ath_pci.h 2006-01-26 15:32:22.470574= 128=20 >>>>> +1000 >>>>> +++ madwifi/ath/if_ath_pci.h 2006-01-26 15:29:28.832971056 += 1000 >>>>> @@ -60,4 +60,8 @@ >>>>> #define BUS_DMA_FROMDEVICE PCI_DMA_FROMDEVICE >>>>> #define BUS_DMA_TODEVICE PCI_DMA_TODEVICE >>>>> >>>>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,11) >>>>> +#define pm_message_t u32 >>>>> +#endif >>>>> + >>>>> #endif /* _DEV_ATH_PCI_H_ */ >>>>> >>>>> If that looks okay we can look at getting that into the mawifi-= old=20 >>>>> branch. >>>>> >>>>> =20 >>>> >>>> >>>> >>>> >>>> yup. >>>> >>>> =20 >>>> >>>>> Lukas, apologies for the excessive noise about this issue. >>>>> >>>>> =20 >>>> >>>> >>>> >>>> >>>> no problem. Thanks. >>>> >>>> >>>> wbr, >>>> Lukas >>>> =20 >>>> >>> Lukas, >>> >>> Patch applied to branches/madwifi-old of madwifi.org svn. >>> >>> Thanks, Kel. >>> >>> >>> ------------------------------------------------------- >>> This SF.net email is sponsored by: Splunk Inc. Do you grep throug= h=20 >>> log files >>> for problems? Stop! Download the new AJAX search engine that ma= kes >>> searching your log files as easy as surfing the web. DOWNLOAD S= PLUNK! >>> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D103432&bid=3D2304= 86&dat=3D121642=20 >>> >>> _______________________________________________ >>> Madwifi-devel mailing list >>> Mad...@li... >>> https://lists.sourceforge.net/lists/listinfo/madwifi-devel >>> >> Is this patch meant to solve this issue? : >> >> if_ath.c:45:20: opt_ah.h: File or directory does not exist >> > > No, that patch solves the following issue:- > > http://madwifi.org/ticket/340 > >> If so, I have tried with kernel source 2.4.32 and patched using= =20 >> modules and not modules support and I always the message before. >> >> My dmesg is the following: >> >> ath_hal: 0.9.14.9 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413) >> ath_rate_onoe: 1.0 >> ath_pci: 0.9.6.0 (EXPERIMENTAL) >> Build date: Jan 23 2006 >> Debugging version (IEEE80211) >> ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps >> ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18M= bps=20 >> 24Mbps 36Mbps 48Mbps 54Mbps >> ath0: H/W encryption support: WEP AES AES_CCM TKIP >> ath0: mac 7.8 phy 4.5 radio 5.6 >> ath0: Use hw queue 1 for WME_AC_BE traffic >> ath0: Use hw queue 0 for WME_AC_BK traffic >> ath0: Use hw queue 2 for WME_AC_VI traffic >> ath0: Use hw queue 3 for WME_AC_VO traffic >> ath0: Use hw queue 8 for CAB traffic >> ath0: Use hw queue 9 for beacons >> Debugging version (ATH) >> ath0: Atheros 5212: mem=3D0xebfd0000, irq=3D9 >> wlan: 0.8.6.0 (EXPERIMENTAL) >> wlan: mac acl policy registered >> >> Any hint that you can give me? I can set my SMCWPCI-G card to 802.= 11b=20 >> modes, not g modes in master mode, I am using madwifi-old driver. = In=20 >> ad-hoc mode I keep on loosing packets. >> >> I would like to help in testing whatever you think I should test w= ith=20 >> my card for helping in this project :) >> >> Best Regards, >> >> Miguel > > > > No, unfortunately I have no idea what your problem is. > > Thanks, Kel.=20 Thank you very much for your prompt reply. Do you need any other extr= a=20 information to help me out to solve this issue? Is it mainly a=20 compilation issue as you can see, in madwifi-old it compiles, but I j= ust=20 can set 802.11b modes, besides I can=B4t compile madwifi-ng in the so= urce=20 kernel tree 2.4.32 with modules support or not modules support=20 (monolithic kernel). Best Regards, Miguel |
From: <mig...@ya...> - 2006-01-30 15:35:45
|
Dear all, Sorry for the cross posting. I am trying to solve the issue that I mentioned in several post about compiling madwifi-ng patching the kernel sources 2.4.32. Ok, I got an error compiling if_ath_pci and getting that the target if_ath_phyerr.o cannot be built because there is no rule for building this target. I checked where this file resides, and I found it under drivers/net/wireless/Makefile changing the line: obj-$(CONFIG_ATHEROS) := if_ath.o if_ath_phyerr.o if_ath_${BUSNAME}.o to: obj-$(CONFIG_ATHEROS) := if_ath.o if_ath_${BUSNAME}.o then I got an error of not found if_osdep.h, I checked where it is refered and I commented out the include under wireless/drivers/net/if_athproto.h then I succesfully compiled the linux kernel, BUT dmesg reports: ath_hal: 0.9.14.9 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413) ath_rate_onoe: 1.0 ath_pci: 0.9.4.5 (Atheros/multi-bss) wifi%d: HAL ABI mismatch; driver expects 0x5120700, HAL reports 0x4112900 wlan: 0.8.4.2 (Atheros/multi-bss) wlan: mac acl policy registered And obviously the ath0 interface is not running. What am I doing wrong? Best Regards, Miguel |
From: <mig...@ya...> - 2006-01-30 18:20:21
|
Miguel Gonz=E1lez Casta=F1os escribi=F3: > Dear all, > > Sorry for the cross posting. I am trying to solve the issue that I= =20 > mentioned in several post about compiling madwifi-ng patching the= =20 > kernel sources 2.4.32. > > Ok, I got an error compiling if_ath_pci and getting that the target= =20 > if_ath_phyerr.o cannot be built because there is no rule for buildi= ng=20 > this target. I checked where this file resides, and I found it unde= r=20 > drivers/net/wireless/Makefile changing the line: > > obj-$(CONFIG_ATHEROS) :=3D if_ath.o if_ath_phyerr.o if_ath_${BUSNA= ME}.o > > to: > > obj-$(CONFIG_ATHEROS) :=3D if_ath.o if_ath_${BUSNAME}.o > > then I got an error of not found if_osdep.h, I checked where it is= =20 > refered and I commented out the include under=20 > wireless/drivers/net/if_athproto.h > > then I succesfully compiled the linux kernel, BUT dmesg reports: > > ath_hal: 0.9.14.9 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413) > ath_rate_onoe: 1.0 > ath_pci: 0.9.4.5 (Atheros/multi-bss) > wifi%d: HAL ABI mismatch; driver expects 0x5120700, HAL reports 0x4= 112900 > wlan: 0.8.4.2 (Atheros/multi-bss) > wlan: mac acl policy registered > > And obviously the ath0 interface is not running. > > What am I doing wrong? > > Best Regards, > > Miguel=20 I am answering myself :) After checking this link: http://www.mail-archive.com/mad...@li.../ms= g01306.html I realized that I got code from madwifi-old since I patched the kern= el.=20 Using a clean source kernel tree got me to the original problem: make[5]: *** There is no rule for building targert=20 `../hal/public/i386-elf.opt_ah.h', needed for `opt_ah.h'. Stop. Since I am a bit curious and I would like to know if I can solve it = by=20 myself I have checked it: [root@ordesa linux-2.4.32]# grep -R opt_ah.h * drivers/net/wireless/ath/if_ath_ahb.c:#include "opt_ah.h" drivers/net/wireless/ath/if_ath.c:#include "opt_ah.h" drivers/net/wireless/ath/if_ath_pci.c:#include "opt_ah.h" drivers/net/wireless/_ath_hal/Makefile:OPT_AH_H=3D =20 ${HAL}/public/${TARGET}.opt_ah.h drivers/net/wireless/_ath_hal/Makefile:OPT_AH_H=3D =20 ${HAL_OBJDIR}/opt_ah.h drivers/net/wireless/_ath_hal/Makefile:# XXX need opt_ah.h to do=20 dependencies so give this bogus dependency drivers/net/wireless/_ath_hal/Makefile:$(obj)/ah_osdep.c:=20 ${HAL}/linux/ah_osdep.c $(obj)/opt_ah.h drivers/net/wireless/_ath_hal/Makefile:$(obj)/opt_ah.h: ${OPT_AH_H} drivers/net/wireless/_ath_hal/Makefile: cp ${OPT_AH_H} $(obj)/opt_ah.= h drivers/net/wireless/hal/linux/ah_osdep.c:#include "opt_ah.h" Anyway I corrected manually the warnings that I got (mostly for=20 dependencies that are not met) and set modules enabled (although I am= =20 not using modules) and deselect modversions (there was a complain= =20 regarding modversion.h), then I got my kernel compiled :). I have wro= te=20 down the steps if anyone from the developer guys wants to check this. The issue now is that I got an extra wifi0 interface and the ath0= =20 interface now It cannot be set to master mode at any bitrate: either = G=20 or B modes. Here it is my dmesg: ath_hal: 0.9.16.13 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413,= =20 RF5413, DFS) ath_rate_onoe: 1.0 ath_pci: 0.9.4.5 (Atheros/multi-bss) wifi0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps wifi0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbp= s=20 24Mbps 36Mbps 48Mbps 54Mbps wifi0: H/W encryption support: WEP AES AES_CCM TKIP wifi0: mac 7.8 phy 4.5 radio 5.6 wifi0: Use hw queue 1 for WME_AC_BE traffic wifi0: Use hw queue 0 for WME_AC_BK traffic wifi0: Use hw queue 2 for WME_AC_VI traffic wifi0: Use hw queue 3 for WME_AC_VO traffic wifi0: Use hw queue 8 for CAB traffic wifi0: Use hw queue 9 for beacons kmod: failed to exec /sbin/modprobe -s -k wlan_scan_sta, errno =3D 2 unable to load wlan_scan_sta wifi0: Atheros 5212: mem=3D0xebfd0000, irq=3D9 wlan: 0.8.4.2 (Atheros/multi-bss) wlan: mac acl policy registered Best Regards, Miguel =20 =20 |