Thread: [Madwifi-devel] Use of DESTDIR and depmod in Makefile
Status: Beta
Brought to you by:
otaku
From: Kel M. <ke...@tp...> - 2005-09-23 08:33:57
|
Hi, The following patch removes a function (I fail to see the point of) when using DESTDIR and calling the install target of the Makeifle. The patch currently used in my debian packaging project to avoid running depmod in the DESTDIR target. diff -Nru madwifi.orig/Makefile madwifi/Makefile --- madwifi.orig/Makefile 2005-07-12 23:58:48.000000000 +1000 +++ madwifi/Makefile 2005-08-12 10:59:42.000000000 +1000 @@ -58,8 +58,6 @@ done @if [ -z $(DESTDIR) ]; then \ /sbin/depmod -ae ; \ - elif [ -f $(SYSTEMMAP) ]; then \ - /sbin/depmod -ae -b $(DESTDIR) -F $(SYSTEMMAP) $(KERNELRELEASE) ; \ else \ echo "Don't forget to run \"depmod -ae\" on the target system."; \ fi Thanks, Kel. |
From: Michael R. <ma...@no...> - 2005-10-04 05:48:19
|
Hi. Kel Modderman wrote: > The following patch removes a function (I fail to see the point of) when > using DESTDIR and calling the install target of the Makeifle. The purpose of this function is to update the module dependencies in cases where DESTDIR is used. Simply calling "depmod -ae" fails here, because the kernel as well as the modules will be installed in the hierarchie under DESTDIR, so looking in /lib/modules/<kernel> doesn't work for depmod. If you need a way to prevent depmod being run in/for DESTDIR, I'd rather suggest to introduce a new variable for this purpose. If set, the passage you removed in your patch will not be run, for example ... elif [ -f $(SYSTEMMAP) -a "$(DONT_RUN_DEPMOD)" -eq "0" ]; then ... Other opinions on that? Bye, Mike -- Sign EDRI petition against data retention: http://www.dataretentionisnosolution.com Use PGP/GPG! My key: http://keys.indymedia.org/cgi-bin/lookup?op=get&search=62C29B94 Fingerprint: BC2E 79BF 0C8F 0282 864B 9CEC 8343 5169 62C2 9B94 |
From: Kel M. <ke...@tp...> - 2005-10-04 07:08:28
|
Hi Mike, Michael Renzmann wrote: >Hi. > >Kel Modderman wrote: > > >>The following patch removes a function (I fail to see the point of) when >>using DESTDIR and calling the install target of the Makeifle. >> >> > >The purpose of this function is to update the module dependencies in >cases where DESTDIR is used. Simply calling "depmod -ae" fails here, >because the kernel as well as the modules will be installed in the >hierarchie under DESTDIR, so looking in /lib/modules/<kernel> doesn't >work for depmod. > >If you need a way to prevent depmod being run in/for DESTDIR, I'd rather >suggest to introduce a new variable for this purpose. If set, the >passage you removed in your patch will not be run, for example >... >elif [ -f $(SYSTEMMAP) -a "$(DONT_RUN_DEPMOD)" -eq "0" ]; then >... > >Other opinions on that? > >Bye, Mike > > Better would be:- diff -Nru madwifi-orig/Makefile madwifi-nodepmod/Makefile --- madwifi-orig/Makefile 2005-10-04 17:06:12.000000000 +1000 +++ madwifi-nodepmod/Makefile 2005-10-04 16:57:33.000000000 +1000 @@ -58,7 +58,7 @@ done @if [ -z $(DESTDIR) ]; then \ /sbin/depmod -ae ; \ - elif [ -f $(SYSTEMMAP) ]; then \ + elif [ -f $(SYSTEMMAP) -a -z "$(NO_DEPMOD)" ]; then \ /sbin/depmod -ae -b $(DESTDIR) -F $(SYSTEMMAP) $(KERNELRELEASE) ; \ else \ echo "Don't forget to run \"depmod -ae\" on the target system."; \ Then you would only have to set NO_DEPMOD to avoid that behaviour, and the default behaviour would be preserved when not set. Thanks, Kel. |
From: Bruno R. <bru...@4g...> - 2005-10-18 09:38:38
|
ok, it added the NO_DEPMOD solution. thanks! bruno On Tuesday 04 October 2005 09:10, Kel Modderman wrote: > Hi Mike, > > Michael Renzmann wrote: > >Hi. > > > >Kel Modderman wrote: > >>The following patch removes a function (I fail to see the point of) when > >>using DESTDIR and calling the install target of the Makeifle. > > > >The purpose of this function is to update the module dependencies in > >cases where DESTDIR is used. Simply calling "depmod -ae" fails here, > >because the kernel as well as the modules will be installed in the > >hierarchie under DESTDIR, so looking in /lib/modules/<kernel> doesn't > >work for depmod. > > > >If you need a way to prevent depmod being run in/for DESTDIR, I'd rather > >suggest to introduce a new variable for this purpose. If set, the > >passage you removed in your patch will not be run, for example > >... > >elif [ -f $(SYSTEMMAP) -a "$(DONT_RUN_DEPMOD)" -eq "0" ]; then > >... > > > >Other opinions on that? > > > >Bye, Mike > > Better would be:- > > diff -Nru madwifi-orig/Makefile madwifi-nodepmod/Makefile > --- madwifi-orig/Makefile 2005-10-04 17:06:12.000000000 +1000 > +++ madwifi-nodepmod/Makefile 2005-10-04 16:57:33.000000000 +1000 > @@ -58,7 +58,7 @@ > done > @if [ -z $(DESTDIR) ]; then \ > /sbin/depmod -ae ; \ > - elif [ -f $(SYSTEMMAP) ]; then \ > + elif [ -f $(SYSTEMMAP) -a -z "$(NO_DEPMOD)" ]; then \ > /sbin/depmod -ae -b $(DESTDIR) -F $(SYSTEMMAP) $(KERNELRELEASE) ; > \ else \ > echo "Don't forget to run \"depmod -ae\" on the target system."; \ > > Then you would only have to set NO_DEPMOD to avoid that behaviour, and > the default behaviour would be preserved when not set. > > Thanks, Kel. > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Power Architecture Resource Center: Free content, downloads, discussions, > and more. http://solutions.newsforge.com/ibmarch.tmpl > _______________________________________________ > Madwifi-devel mailing list > Mad...@li... > https://lists.sourceforge.net/lists/listinfo/madwifi-devel |