Re: [Mactel-linux-devel] Failed sensor reads

[Sven A. <an...@an...>]

Nicolas Boichat schrieb:
> Hello,
> 
> Even the Mac OS X driver seems to do strange things to try to "unstuck"
> the device.
> 
> A proper way to fix the problem would be to fix the userspace
> application to retry a few milliseconds later.

It will try again, but in the GNOME sensors applet you will see "ERROR"
for a fraction of a second.

And now we have a problem. I've contacted the author of the applet before
and he says it's an error in the kernel driver. You say, it's an error of
the program. What should we do?

I think, it's not really an error of the driver, but as any user-space tool
assume to get valid values every time, solve it in the kernel driver.

> There are 2 ways to fix the problem in kernel too:
>  - Store the values, ok, but what should we return if it's the first
> time we read it? It would be relatively complicated, and would use some
> kernel memory.

If it failed the first time, return an error.
And yes, it will use some memory, but it must be only allocated once at init,
right?!

>  - Wait and retry, but sometimes it can take a long time (I would say
> something like up to a second to get a value), and we don't want to
> block the application while it could do something better in the mean-time...

Did you currently try only once? Maybe we should try 3 times before giving up???


Regards
 Sven

-- 
 Sven Anders <an...@an...>                 () Ascii Ribbon Campaign
                                                 /\ Support plain text e-mail
 ANDURAS service solutions AG
 Innstraße 71 - 94036 Passau - Germany
 Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55

Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker
Vorsitzender des Aufsichtsrats: Dipl. Kfm. Thomas Träger