Re: [Mactel-linux-devel] Cleaned up patches for 2.6.20

[Soeren S. <mac...@nn...>]

On Sun, 2007-03-18 at 03:03 +0800, Nicolas Boichat wrote:
> Guillaume Pujol wrote:
> > Hi,
> > 
> > Attached to this mail you'll can find clean mactel patches for linux
> > kernel 2.6.20.
> > They apply against linux 2.6.20 + gentoo patchset + suspend2 without
> > offset nor fuzz (should apply to unpatched official kernel as well).
> 
> Ok cool. Personally, when I did this job, I edited the patchfiles
> manually... Then it was easier for me to do a diff between the files,
> and check I didn't remove a part of the patch, or modify something...
> With your patchset it's hard for me to compare...

if this patchset is against gentoo it is useful for gentoo users but not
that match for mactel-svn. also I don't see the need to even patch the
kernel with suspend2 ... ususpend, i.e. s2ram/s2disk/s2both work nicely
enough - no ?

> > Also:
> > - rewritten usbhid.patch which was partly applied to official 2.6.20,
> > and added HID_QUIRK_IGNORE_MOUSE everywhere it was useful.
> 
> Just beware of this in include/linux/hid.h:
> +#define HID_QUIRK_IGNORE_MOUSE			0x00010000
>  #define HID_QUIRK_BAD_RELATIVE_KEYS		0x00010000
> 
> These two constants should have a different values.

indeed IIRC the patch that is now in 2.6.21-rcX has

 #define HID_QUIRK_IGNORE_MOUSE			0x00020000

and while we are at it the mouse button emulation code is now also in
2.6.20.3  ...

Soeren