Re: [Mactel-linux-devel] Missing keys in kernel/mactel-patches-2.6.24/hid-add-new-apple-keyboard.patch ?

[Jerome F. <jf...@gm...>]

>> > The way you're doing it:
>> >
>> >>  static struct hidinput_key_translation apple_fn_keys[] = {
>> >>         { KEY_BACKSPACE, KEY_DELETE },
>> >>         { KEY_F1,       KEY_BRIGHTNESSDOWN, APPLE_FLAG_FKEY },
>> >>         { KEY_F2,       KEY_BRIGHTNESSUP,   APPLE_FLAG_FKEY },
>> >>         { KEY_F3,       KEY_FN_F5,          APPLE_FLAG_FKEY }, /*
>> >> Exposé */
>> >>         { KEY_F4,       KEY_FN_F4,          APPLE_FLAG_FKEY }, /*
>> >> Dashboard */
>> >> +        { KEY_F5,      KEY_KBDILLUMDOWN,   APPLE_FLAG_FKEY },
>> >> +        { KEY_F6,      KEY_KBDILLUMUP,     APPLE_FLAG_FKEY },
>> >>         { KEY_F7,       KEY_PREVIOUSSONG,   APPLE_FLAG_FKEY },
>> >>         { KEY_F8,       KEY_PLAYPAUSE,      APPLE_FLAG_FKEY },
>> >>         { KEY_F9,       KEY_NEXTSONG,       APPLE_FLAG_FKEY },
>> >
>> > breaks keyboards without these special keys, e.g. external USB
>> > keyboards. Also, I think some MacBook Pros have/had a different layout
>> > of the special keys, though you may already account for that.
>> >
>> I had a quick look and on Google images, and the only similar layout
>> but different for these 2 keys that I can find is the one of the alu
>> wireless keyboard of Apple:
>> http://www.thomann.de/fr/prod_bdb_AR_119224.html?image=0&sid=c0c7390b59f0507d18fadbba8776c7b8
>
> Same for the USB aluminum keyboard.
>
>> But these two keys seem to be mapped to nothing in fact. So, imho,
>> mapping these two keys to keyboard brightness control, even if it's
>> not applicable to these keyboard, still makes sense to me : It keeps
>> the layout consistent (having to press Fn to get the Fx keys except
>> for F5 and F6 is weird), and should no other side effect on these
>> keyboards.
>
> I disagree; as there's no special function engraved on these keys, they
> should always generate F5/6.
>
So, we should prevent macbook users from using their keyboard
backlights to allow people using other apple keyboards to use F5/F6
with or without the Fn key ? I know you said that a better way of
making all these quirks is in process, but in the meantime, I still
think that enforcing consistency across all Apple keyboards is the
better solution. Moreover, people using external apple keyboards will
still be able to map Fn-F5 Fn-F6 to something else (including F5/F6),
but MacBook Pro users need these keys to be mapped to the control of
the keyboard backlights because these key codes are hard-coded in
pommed. Actually, even if they weren't, they would have to map F5/F6
to be coherent with the drawing on their keyboard, probably
conflicting with many other use of F5/F6.