Re: [Mactel-linux-devel] Missing keys in kernel/mactel-patches-2.6.24/hid-add-new-apple-keyboard.patch ?

[Jerome F. <jf...@gm...>]

>> Hello,
>>
>> In kernel/mactel-patches-2.6.24/hid-add-new-apple-keyboard.patch , two
>> keys seem to be missing in the array "apple_keyboard_fn_keys":
>>  { KEY_F5,       KEY_KBDILLUMDOWN,       POWERBOOK_FLAG_FKEY },
>>  { KEY_F6,       KEY_KBDILLUMUP,         POWERBOOK_FLAG_FKEY },
>>
>> Without these two lines, it's not possible for me on my macbook pro
>> 4.1 to adjust the light of the keyboard with pommed, but with them, it
>> works fine.
>
>
> It would be great if you could test if the problem still happens on
> 2.6.25.x, and port it if necessary (I quickly tried, but it is not trival,
> as some files changed quite importantly in the kernel)
>
Done. I had to port the patch for the 2.6.24 to the 2.6.25.4 (some
part of the 2.6.24 patch were already included mainstream ?). I've
joined the patch to this mail.

The problem with the two keys is confirmed and solved in this patch.

I prefered to not add another "#define APPLE_QUIRK" as done in the
2.6.24 patch because the 2.6.25 seems to include a lot more quirks and
almost all the bits of the 32bits integer contaning the list of quirk
to apply are used now. Moreover, the word "powerbook" has been
replaced in many places by "apple", so adding another quirk name using
the word "apple" would have been confusing :/
Instead, I did like it seems to be done in the mainstream 2.6.25.4 :
Look if the product ID is between 0x220 and 0x300 to know if it's a
powerbook keyboard or another apple keyboard. According to the list of
apple keyboards in drivers/hid/usbhid/hid-quirks.c, it should be fine.

Hm, just two other things:
- Why is there no 'apply' script in
mactel/kernel/mactel-patches-2.6.25 like in
mactel/kernel/mactel-patches-2.6.24 ? It makes these patches much
easier to use for non-dev people.
- Also, can you integrate my two-lines fix to the patch for the kernel
2.6.24 please? I had a problem with the kernel 2.6.25 older than the
2.6.25.4 (bug in the SATA driver), and I have the feeling that the
kernel 2.6.24 can still be useful for some people.