Re: [Mactel-linux-devel] Missing keys in kernel/mactel-patches-2.6.24/hid-add-new-apple-keyboard.patch ?

[Jerome F. <jf...@gm...>]

> Hi,
>
> Jerome Flesch wrote:
>>
>> Hello,
>>
>> In kernel/mactel-patches-2.6.24/hid-add-new-apple-keyboard.patch , two
>> keys seem to be missing in the array "apple_keyboard_fn_keys":
>>  { KEY_F5,       KEY_KBDILLUMDOWN,       POWERBOOK_FLAG_FKEY },
>>  { KEY_F6,       KEY_KBDILLUMUP,         POWERBOOK_FLAG_FKEY },
>>
>> Without these two lines, it's not possible for me on my macbook pro
>> 4.1 to adjust the light of the keyboard with pommed, but with them, it
>> works fine.
>
>
> It would be great if you could test if the problem still happens on
> 2.6.25.x, and port it if necessary (I quickly tried, but it is not trival,
> as some files changed quite importantly in the kernel)
>
Ok, I will try it as soon as I have time for it (probably tomorrow or Saturday).


>> I'm also wondering : Is there any plan to integrate your patches to
>> the mainstream linux kernel ?
>
> - applesmc*: My responsability, but I'm lacking time to get them integrated
> (and some need disk-protect*)
> - appletouch*: Sven Anders
> - disk-protect* + export-lookup_dev.patch: Elias Oltmanns (from hdaps) and
> me (some exports to be able to park the head from my driver)
>  - sigmatel_*: Maybe I should send them upstream, but to be honest I'm not
> sure these are absolutely necessary, or if you should set your model using a
> kernel parameters.
>
> So basically there are 2 patches I could send upstream relatively easily:
> applesmc-retry-when-accessing-keys.patch
> applesmc-remove-debugging-messages.patch
> (the 2nd one fixing a problem occuring when the 1st one is used IIRC)...
>
> I'll get that done, when I have time...
>
Actually, even if I don't know much about the process of development
of the kernel, I have a good knowledge in C programming (Unix and
embedded), so, if you feel I could help you, just ask :)


> Best regards,
>
> Nicolas
>