Menu
▾
▴
mactel-linux-devel
|
From: Sven A. <an...@an...> - 2007-09-26 19:18:13
|
Hello!
A few month ago I implemented palm-detection to the appletouch driver and
released a development version. Currently I'm trying to reimplement these
in a clean way and I'm planning to release it in parts, so I would be accepted
by the kernel developers.
Late in the develoment progress I found out, that the new Geyser 3/4 touchpad
have special status flags. This patch implements the usage of them and corrects
the calculation of the pressure (for later usage by the palm detection).
It was tested by some debian people (Johannes Berg, Michel Dänzer, Gaudenz
Steinlin) on the PowerBook and works there too.
Nicolas can you commit it to the MacTel-SVN? Did you send the last patches to
the kernel developers?
Regards
Sven
--
Sven Anders <an...@an...> () Ascii Ribbon Campaign
/\ Support plain text e-mail
ANDURAS service solutions AG
Innstraße 71 - 94036 Passau - Germany
Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker
Vorsitzender des Aufsichtsrats: Dipl. Kfm. Thomas Träger
|
|
From: Soeren S. <mac...@nn...> - 2007-09-26 19:33:29
|
Hi Sven,=20
On Wed, 2007-09-26 at 21:17 +0200, Sven Anders wrote:
> Hello!
>=20
> A few month ago I implemented palm-detection to the appletouch driver and
> released a development version. Currently I'm trying to reimplement these
> in a clean way and I'm planning to release it in parts, so I would be acc=
epted
> by the kernel developers.
>=20
> Late in the develoment progress I found out, that the new Geyser 3/4 touc=
hpad
> have special status flags. This patch implements the usage of them and co=
rrects
> the calculation of the pressure (for later usage by the palm detection).
>=20
> It was tested by some debian people (Johannes Berg, Michel D=E4nzer, Gaud=
enz
> Steinlin) on the PowerBook and works there too.
It would be great to see that feature in the main kernel...
> /* Structure to hold all of our device specific stuff */
> struct atp {
> char phys[64];
> struct usb_device * udev; /* usb device */
> struct urb * urb; /* usb request block */
> - signed char * data; /* transferred data */
> + u8 * data; /* transferred data */
> int open; /* non-zero if opened */
> struct input_dev *input; /* input dev */
> int valid; /* are the sensors valid =
? */
> int x_old; /* last reported x/y, */
> int y_old; /* used for smoothing */
> /* current value of the s=
ensors */
> - signed char xy_cur[ATP_XSENSORS + ATP_YSENSORS];
> + u16 xy_cur[ATP_XSENSORS + ATP_YSENSORS];
> /* last value of the sens=
ors */
> - signed char xy_old[ATP_XSENSORS + ATP_YSENSORS];
> + u16 xy_old[ATP_XSENSORS + ATP_YSENSORS];
> /* accumulated sensors */
> int xy_acc[ATP_XSENSORS + ATP_YSENSORS];
> int overflowwarn; /* overflow warning print=
ed? */
> int datalen; /* size of an USB urb tra=
nsfer */
> - int idlecount; /* number of empty packet=
s */
> - struct work_struct work;
> + int idle_counter; /* idle counter */
> + struct work_struct work; /* kernel workqueue entry=
(for re-init) */
> };
=20
Could you please point out why you need the u16 / u8 and signed char's
are not enough?=20
Thanks,
Soeren
|
|
From: Martin A. <au...@re...> - 2007-09-27 16:52:57
|
Hi Sven, your work sounds very promising. But against which version of appletouch.c = is=20 your patch? I tried 2.6.22, but there were quite some failed hunks. Thank you very much for your efforts, Martin On Wednesday 26 September 2007, Sven Anders wrote: > Hello! > > A few month ago I implemented palm-detection to the appletouch driver and > released a development version. Currently I'm trying to reimplement these > in a clean way and I'm planning to release it in parts, so I would be > accepted by the kernel developers. > > Late in the develoment progress I found out, that the new Geyser 3/4 > touchpad have special status flags. This patch implements the usage of th= em > and corrects the calculation of the pressure (for later usage by the palm > detection). > > It was tested by some debian people (Johannes Berg, Michel D=E4nzer, Gaud= enz > Steinlin) on the PowerBook and works there too. > > Nicolas can you commit it to the MacTel-SVN? Did you send the last patches > to the kernel developers? > > Regards > Sven |
|
From: Sven A. <an...@an...> - 2007-09-27 18:43:12
|
Martin Aumueller schrieb:
> Hi Sven,
>
> your work sounds very promising. But against which version of appletouch.c is
> your patch? I tried 2.6.22, but there were quite some failed hunks.
Oops, sorry. I used the wrong 'original' file.
Here come the working patches against:
- 2.6.22.3 (tested with 2.6.22.9 and it's identical)
- 2.6.23-rc8
Regards
Sven
--
Sven Anders <an...@an...> () Ascii Ribbon Campaign
/\ Support plain text e-mail
ANDURAS service solutions AG
Innstraße 71 - 94036 Passau - Germany
Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker
Vorsitzender des Aufsichtsrats: Dipl. Kfm. Thomas Träger
|
|
From: Sven A. <an...@an...> - 2007-11-29 21:09:36
Attachments:
signature.asc
anders.vcf
|
Nicolas Boichat schrieb:
> Hi Sven,
>
> I tried to apply your patch to 2.6.24-rc3, without sucess, it seems
> there is a lot of conflicts, and I don't want to break anything. It
> would be good if your good do it.
>
> Have you tried to send this patch upstream? I think with your
> modifications the driver is much more stable...
Not yet. I have some trouble with my current config (sometimes the pointer did not
stop and moves slowly to the upper left corner) and I want to be sure it's not a
problem of my modifications.
I think I have some time in the near future to track down (and correct) this problem.
Do you experience any problems with my or the standard driver?
Regards
Sven
--
Sven Anders <an...@an...> () Ascii Ribbon Campaign
/\ Support plain text e-mail
ANDURAS service solutions AG
Innstraße 71 - 94036 Passau - Germany
Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker
Vorsitzender des Aufsichtsrats: Dr. Thomas Träger
|
|
From: Sven A. <an...@an...> - 2008-02-05 00:46:34
Attachments:
anders.vcf
|
Nicolas Boichat schrieb:
> Sven Anders wrote:
>
> I quickly tried to update your patch to 2.6.23-rc8, it looks like there
> is some conflicts.
>
> I think it would be good if you could try to port your patch to the
> latest git, it's the easiest way of getting it in the kernel eventually.
Ok, I finally managed to update the patch.
This is the updated appletouch patch for 2.6.24.
Please test it and report any problems.
Regards
Sven
--
Sven Anders <an...@an...> () Ascii Ribbon Campaign
/\ Support plain text e-mail
ANDURAS service solutions AG
Innstraße 71 - 94036 Passau - Germany
Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker
Vorsitzender des Aufsichtsrats: Dr. Thomas Träger
|
|
From: Sven A. <an...@an...> - 2008-02-07 19:07:23
|
Nicolas Boichat schrieb:
> Hi,
>
>> This is the updated appletouch patch for 2.6.24.
>>
>> Please test it and report any problems.
>
> Erm, I think you forgot the attachment .-)
>
> Apart of that, thank you, the vanilla 2.6.24 appletouch driver is quite
> unreliable, yours was much better in 2.6.23.
Erm, yes....
Sorry, here it comes...
Regards
Sven
--
Sven Anders <an...@an...> () Ascii Ribbon Campaign
/\ Support plain text e-mail
ANDURAS service solutions AG
Innstraße 71 - 94036 Passau - Germany
Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker
Vorsitzender des Aufsichtsrats: Dr. Thomas Träger
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X