In -[PKController keyGenerate:], created controller is never
released; you should use a shared instance instead of creating
a new instance for each call.
BTW, there's not point to alloc/init/retain, as alloc already
performs a retain.
While testing code using a shared instance for the GenerateKeyController,
I discovered that the code for handling the GenerateKey Window is very
ugly and easy to break. So the GenerateKeyController is going to need a
lot of work to fix this leak, and is being postponed until after 0.7.0 is
released.
I don't think this leak is a show-stopper--It seems to me that the
overwhelming majority of users of graphical OpenPGP applications are
not generating large numbers of keys, so this leak will have a minor or
negligable effect on most users. This is not to say that it shouldn't be
fixed, just that fixing it will be postponed.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=97331
While testing code using a shared instance for the GenerateKeyController,
I discovered that the code for handling the GenerateKey Window is very
ugly and easy to break. So the GenerateKeyController is going to need a
lot of work to fix this leak, and is being postponed until after 0.7.0 is
released.
I don't think this leak is a show-stopper--It seems to me that the
overwhelming majority of users of graphical OpenPGP applications are
not generating large numbers of keys, so this leak will have a minor or
negligable effect on most users. This is not to say that it shouldn't be
fixed, just that fixing it will be postponed.