mac-on-linux-users

[Mac-on-linux-users] Compiling binaries failed

[Elimar R. <rie...@lx...>]

    Compiling    blk_dmg.o
In file included from ./include/blk_dmg.h:37,
                 from blk_dmg.c:30:
/usr/include/zlib.h:1366: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzseek64'
/usr/include/zlib.h:1367: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gztell64'
/usr/include/zlib.h:1368: error: expected declaration specifiers or '...' before 'off64_t'
/usr/include/zlib.h:1369: error: expected declaration specifiers or '...' before 'off64_t'
make[3]: *** [../../../obj-ppc/build/src/drivers/disk/blk_dmg.o] Error 1
make[2]: *** [sub-disk-all] Error 2
make[1]: *** [sub-drivers-all] Error 2
make: *** [sub-src-all] Error 2

Any hints?

Elimar


-- 
  Learned men are the cisterns of knowledge, 
  not the fountainheads ;-)

Re: [Mac-on-linux-users] Compiling binaries failed

[Joseph J. <jo...@ge...>]

Elimar Riesebieter wrote:
>     Compiling    blk_dmg.o
> In file included from ./include/blk_dmg.h:37,
>                  from blk_dmg.c:30:
> /usr/include/zlib.h:1366: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzseek64'
> /usr/include/zlib.h:1367: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gztell64'
> /usr/include/zlib.h:1368: error: expected declaration specifiers or '...' before 'off64_t'
> /usr/include/zlib.h:1369: error: expected declaration specifiers or '...' before 'off64_t'
> make[3]: *** [../../../obj-ppc/build/src/drivers/disk/blk_dmg.o] Error 1
> make[2]: *** [sub-disk-all] Error 2
> make[1]: *** [sub-drivers-all] Error 2
> make: *** [sub-src-all] Error 2
> 
> Any hints?
> 
> Elimar
> 
> 

It's not a MOL issue.  Your zlib headers are broken when 
-D_LARGE_FILES is enabled.  You can either turn off -D_LARGE_FILES 
in the MOL Makefile, or fix your headers.

-Joe

Re: [Mac-on-linux-users] Compiling binaries failed

[Elimar R. <rie...@lx...>]

On Sun, 29 Jul 2007 the mental interface of
Joseph Jezak told:

> Elimar Riesebieter wrote:
> >     Compiling    blk_dmg.o
> > In file included from ./include/blk_dmg.h:37,
> >                  from blk_dmg.c:30:
> > /usr/include/zlib.h:1366: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzseek64'
> > /usr/include/zlib.h:1367: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gztell64'
> > /usr/include/zlib.h:1368: error: expected declaration specifiers or '...' before 'off64_t'
> > /usr/include/zlib.h:1369: error: expected declaration specifiers or '...' before 'off64_t'
> > make[3]: *** [../../../obj-ppc/build/src/drivers/disk/blk_dmg.o] Error 1
> > make[2]: *** [sub-disk-all] Error 2
> > make[1]: *** [sub-drivers-all] Error 2
> > make: *** [sub-src-all] Error 2
> > 
> > Any hints?
> > 
> > Elimar
> > 
> > 
> 
> It's not a MOL issue.  Your zlib headers are broken when 
> -D_LARGE_FILES is enabled.  You can either turn off -D_LARGE_FILES 
> in the MOL Makefile, or fix your headers.

The following patch did the trick!


diff -ur a/src/drivers/disk/blk_dmg.c b/src/drivers/disk/blk_dmg.c
--- a/src/drivers/disk/blk_dmg.c	2007-07-29 17:42:08.000000000 +0200
+++ b/src/drivers/disk/blk_dmg.c	2007-07-29 17:42:33.000000000 +0200
@@ -26,7 +26,6 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
-#include <stdio.h>
 #include "blk_dmg.h"
 
 /* Read 64 bit value */


-- 
  "Talking much about oneself can also 
   be a means to conceal oneself."
         -Friedrich Nietzsche

Re: [Mac-on-linux-users] Compiling binaries failed

[Joseph J. <jo...@ge...>]

> The following patch did the trick!
> 
> 
> diff -ur a/src/drivers/disk/blk_dmg.c b/src/drivers/disk/blk_dmg.c
> --- a/src/drivers/disk/blk_dmg.c	2007-07-29 17:42:08.000000000 +0200
> +++ b/src/drivers/disk/blk_dmg.c	2007-07-29 17:42:33.000000000 +0200
> @@ -26,7 +26,6 @@
>   * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
>   * THE SOFTWARE.
>   */
> -#include <stdio.h>
>  #include "blk_dmg.h"
>  
>  /* Read 64 bit value */
> 
> 

Well, that's wicked annoying.  I added that to fix build errors on 
FC7.  I've reverted that change, can someone running FC7 see if it 
still builds and if not, please post the whole error.

Thanks!
-Joe

Re: [Mac-on-linux-users] Bug#435136: Compiling binaries failed

[Mark B. <br...@de...>]

On Sun, Jul 29, 2007 at 12:18:15PM -0400, Joseph Jezak wrote:

>> -#include <stdio.h>
>>  #include "blk_dmg.h"

> Well, that's wicked annoying.  I added that to fix build errors on FC7. =
=20
> I've reverted that change, can someone running FC7 see if it still builds=
=20
> and if not, please post the whole error.

Whatever is going on there is no way that including stdio.h prior to
zlib.h should break anything (or be required for that matter).  I've
just had a brief look and as far as I can tell it works perfectly well
with either _LARGEFILE64_SOURCE or _FILE_OFFSET_BITS set with both 1.2.3
and 1.2.3.3 (the latter is what's in Debian unstable but is a
pre-release so most people are at 1.2.3).  If there *are* problems with
the zlib headers it would be best to work out what they are and try to
resolve them prior to the next zlib release.

The only thing I can think that might break is if blk_dmg.h tries to set
one or the other of those defines after stdio.h has been included.

Note that I've no idea what version of Mac on Linux Elimar was
experiencing trouble with and have been entirely unable to reproduce the
problem he is reporting.  If someone could provide reproduction
instructions or (better yet) a cut down test case I could have a look.

Note also that the gzio API in zlib prior to 1.2.3.mumble prereleases
doesn't cope with large files at all, though you don't seem to be using
it so that shouldn't be an issue.

--=20
"You grabbed my hand and we fell into it, like a daydream - or a fever."

Re: [Mac-on-linux-users] Bug#435136: Compiling binaries failed

[Joseph J. <jo...@ge...>]

> Whatever is going on there is no way that including stdio.h prior to
> zlib.h should break anything (or be required for that matter).  I've
> just had a brief look and as far as I can tell it works perfectly well
> with either _LARGEFILE64_SOURCE or _FILE_OFFSET_BITS set with both 1.2.3
> and 1.2.3.3 (the latter is what's in Debian unstable but is a
> pre-release so most people are at 1.2.3).  If there *are* problems with
> the zlib headers it would be best to work out what they are and try to
> resolve them prior to the next zlib release.
> 
> The only thing I can think that might break is if blk_dmg.h tries to set
> one or the other of those defines after stdio.h has been included.
> 
> Note that I've no idea what version of Mac on Linux Elimar was
> experiencing trouble with and have been entirely unable to reproduce the
> problem he is reporting.  If someone could provide reproduction
> instructions or (better yet) a cut down test case I could have a look.
> 
> Note also that the gzio API in zlib prior to 1.2.3.mumble prereleases
> doesn't cope with large files at all, though you don't seem to be using
> it so that shouldn't be an issue.
> 

I've also been unable to reproduce it here on Gentoo.  To be honest, 
I don't see how including/not including stdio.h should make a 
difference either way, which is why I just removed it.  Again, if a 
FC7 user would like to test the current SVN for me, I'd appreciate it.

Thanks,
-Joe

Re: [Mac-on-linux-users] [Mac-on-linux-devel] Bug#435136: Compiling binaries failed

[Elimar R. <rie...@lx...>]

On Sun, 29 Jul 2007 the mental interface of
Mark Brown told:

[...]
> Note that I've no idea what version of Mac on Linux Elimar was
> experiencing trouble with and have been entirely unable to reproduce the
> problem he is reporting.  If someone could provide reproduction
> instructions or (better yet) a cut down test case I could have a look.

zlib1g  1.2.3.3
libc6   2.6
linux   2.6.23-rc1

Elimar


-- 
  Numeric stability is probably not all that 
  important when you're guessing;-)

Re: [Mac-on-linux-users] [Mac-on-linux-devel] Bug#435136: Compiling binaries failed

[didier <di...@gm...>]

I'm seeing the same on Ubuntu Gutsy for me the pb is with
#define _LARGEFILE64_SOURCE
in drivers/disk/include/blk_dmg.h

it compiles without it and seems to work but I don't have compressed images.
Didier

Re: [Mac-on-linux-users] [Mac-on-linux-devel] Bug#435136: Compiling binaries failed

[Andreas S. <sc...@su...>]

didier <di...@gm...> writes:

> I'm seeing the same on Ubuntu Gutsy for me the pb is with
> #define _LARGEFILE64_SOURCE
> in drivers/disk/include/blk_dmg.h

Feature test macros must be defined _before_ any standard header has
been included.

Andreas.

-- 
Andreas Schwab, SuSE Labs, sc...@su...
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."