From: Elimar R. <rie...@lx...> - 2007-05-26 12:39:03
|
Hi, I tried to compile mol on linux-2.6.23. Please notice following failures/errors: /usr/src/modules/mol/kmod/_dev.c: In function 'find_physical_rom': /usr/src/modules/mol/kmod/_dev.c:76: warning: implicit declaration of function 'find_devices' /usr/src/modules/mol/kmod/_dev.c:76: warning: assignment makes pointer from integer without a cast /usr/src/modules/mol/kmod/_dev.c:76: warning: implicit declaration of function 'find_type_devices' /usr/src/modules/mol/kmod/_dev.c:76: warning: assignment makes pointer from integer without a cast /usr/src/modules/mol/kmod/_hostirq.c: In function 'grab_host_irq': /usr/src/modules/mol/kmod/_hostirq.c:70: warning: 'deprecated_irq_flag' is deprecated (declared at include/linux/interrupt.h:66) /usr/src/modules/mol/kmod/_hostirq.c:70: warning: 'deprecated_irq_flag' is deprecated (declared at include/linux/interrupt.h:66) WARNING: "find_type_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! WARNING: "find_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! /usr/src/modules/mol/netdriver/sheep.c: In function 'demasquerade': /usr/src/modules/mol/netdriver/sheep.c:122: error: 'struct sk_buff' has no member named 'mac' /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_receiver': /usr/src/modules/mol/netdriver/sheep.c:214: error: 'struct sk_buff' has no member named 'h' /usr/src/modules/mol/netdriver/sheep.c:239: error: 'struct sk_buff' has no member named 'mac' /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_aio_write': /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'nh' /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'h' /usr/src/modules/mol/netdriver/sheep.c:451: error: 'struct sk_buff' has no member named 'mac' make[5]: *** [/usr/src/modules/mol/netdriver/sheep.o] Error 1 make[4]: *** [_module_/usr/src/modules/mol/netdriver] Error 2 make[3]: [netdriver] Error 2 (ignored) WARNING: "find_type_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! WARNING: "find_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! /usr/src/modules/mol/netdriver/sheep.c: In function 'demasquerade': /usr/src/modules/mol/netdriver/sheep.c:122: error: 'struct sk_buff' has no member named 'mac' /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_receiver': /usr/src/modules/mol/netdriver/sheep.c:214: error: 'struct sk_buff' has no member named 'h' /usr/src/modules/mol/netdriver/sheep.c:239: error: 'struct sk_buff' has no member named 'mac' /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_aio_write': /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'nh' /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'h' /usr/src/modules/mol/netdriver/sheep.c:451: error: 'struct sk_buff' has no member named 'mac' make[5]: *** [/usr/src/modules/mol/netdriver/sheep.o] Error 1 make[4]: *** [_module_/usr/src/modules/mol/netdriver] Error 2 make[3]: [netdriver] Error 2 (ignored) WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_devices WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_type_devices cp: cannot stat `/usr/src/modules/mol/netdriver/kuname.ko': No such file or directory WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_devices WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_type_devices Any hints? Thanks Elimar -- You cannot propel yourself forward by patting yourself on the back. |
From: Joseph J. <jo...@ge...> - 2007-05-26 14:25:06
|
Elimar Riesebieter wrote: > Hi, > > I tried to compile mol on linux-2.6.23. Please notice following > failures/errors: > > /usr/src/modules/mol/kmod/_dev.c: In function 'find_physical_rom': > /usr/src/modules/mol/kmod/_dev.c:76: warning: implicit declaration of function 'find_devices' > /usr/src/modules/mol/kmod/_dev.c:76: warning: assignment makes pointer from integer without a cast > /usr/src/modules/mol/kmod/_dev.c:76: warning: implicit declaration of function 'find_type_devices' > /usr/src/modules/mol/kmod/_dev.c:76: warning: assignment makes pointer from integer without a cast > /usr/src/modules/mol/kmod/_hostirq.c: In function 'grab_host_irq': > /usr/src/modules/mol/kmod/_hostirq.c:70: warning: 'deprecated_irq_flag' is deprecated (declared at include/linux/interrupt.h:66) > /usr/src/modules/mol/kmod/_hostirq.c:70: warning: 'deprecated_irq_flag' is deprecated (declared at include/linux/interrupt.h:66) > WARNING: "find_type_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! > WARNING: "find_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! > /usr/src/modules/mol/netdriver/sheep.c: In function 'demasquerade': > /usr/src/modules/mol/netdriver/sheep.c:122: error: 'struct sk_buff' has no member named 'mac' > /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_receiver': > /usr/src/modules/mol/netdriver/sheep.c:214: error: 'struct sk_buff' has no member named 'h' > /usr/src/modules/mol/netdriver/sheep.c:239: error: 'struct sk_buff' has no member named 'mac' > /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_aio_write': > /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'nh' > /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'h' > /usr/src/modules/mol/netdriver/sheep.c:451: error: 'struct sk_buff' has no member named 'mac' > make[5]: *** [/usr/src/modules/mol/netdriver/sheep.o] Error 1 > make[4]: *** [_module_/usr/src/modules/mol/netdriver] Error 2 > make[3]: [netdriver] Error 2 (ignored) > WARNING: "find_type_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! > WARNING: "find_devices" [/usr/src/modules/mol/kmod/mol.ko] undefined! > /usr/src/modules/mol/netdriver/sheep.c: In function 'demasquerade': > /usr/src/modules/mol/netdriver/sheep.c:122: error: 'struct sk_buff' has no member named 'mac' > /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_receiver': > /usr/src/modules/mol/netdriver/sheep.c:214: error: 'struct sk_buff' has no member named 'h' > /usr/src/modules/mol/netdriver/sheep.c:239: error: 'struct sk_buff' has no member named 'mac' > /usr/src/modules/mol/netdriver/sheep.c: In function 'sheep_net_aio_write': > /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'nh' > /usr/src/modules/mol/netdriver/sheep.c:450: error: 'struct sk_buff' has no member named 'h' > /usr/src/modules/mol/netdriver/sheep.c:451: error: 'struct sk_buff' has no member named 'mac' > make[5]: *** [/usr/src/modules/mol/netdriver/sheep.o] Error 1 > make[4]: *** [_module_/usr/src/modules/mol/netdriver] Error 2 > make[3]: [netdriver] Error 2 (ignored) > WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_devices > WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_type_devices > cp: cannot stat `/usr/src/modules/mol/netdriver/kuname.ko': No such file or directory > WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_devices > WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_type_devices > > Any hints? > > Thanks > Elimar > > I've already fixed this in SVN. Please try that and let me know if it works for you. -Joe |
From: Andreas S. <sc...@su...> - 2007-05-26 16:19:26
|
Joseph Jezak <jo...@ge...> writes: > I've already fixed this in SVN. Please try that and let me know if > it works for you. The changes in find_physical_rom are not complete, AFAIK. I don't think you can use dn->next for finding the next node, instead you have to repeat of_find_by_name or of_find_by_name, resp. Also, there are calls to of_node_put missing. Andreas. --- dev.c +++ dev.c @@ -72,18 +72,27 @@ find_physical_rom( int *base, int *size #ifndef CONFIG_AMIGAONE struct device_node *dn; int len, *p; + int by_type = 0; - if( !(dn=find_devices("boot-rom")) && !(dn=find_type_devices("rom")) ) + dn = of_find_node_by_name(NULL, "boot-rom"); + if (!dn) { + by_type = 1; + dn = of_find_node_by_type(NULL, "rom"); + } + if (!dn) return 0; do { - if( !(p=(int*)get_property(dn, "reg", &len)) || len != sizeof(int[2]) ) + if( !(p=(int*)get_property(dn, "reg", &len)) || len != sizeof(int[2]) ) { + of_node_put(dn); return 0; + } if( (unsigned int)(0xfff00100 - p[0]) < (unsigned int)p[1] ) { *base = p[0]; *size = p[1]; + of_node_put(dn); return 1; } - dn = dn->next; + dn = by_type ? of_find_node_by_type(dn, "rom") : of_find_node_by_name(dn, "boot-rom"); } while( dn ); #endif -- Andreas Schwab, SuSE Labs, sc...@su... SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." |
From: Joseph J. <jo...@ge...> - 2007-06-25 14:30:34
|
Andreas Schwab wrote: > Joseph Jezak <jo...@ge...> writes: > >> I've already fixed this in SVN. Please try that and let me know if >> it works for you. > > The changes in find_physical_rom are not complete, AFAIK. I don't think > you can use dn->next for finding the next node, instead you have to > repeat of_find_by_name or of_find_by_name, resp. Also, there are calls > to of_node_put missing. > > Andreas. > > --- dev.c > +++ dev.c > @@ -72,18 +72,27 @@ find_physical_rom( int *base, int *size > #ifndef CONFIG_AMIGAONE > struct device_node *dn; > int len, *p; > + int by_type = 0; > > - if( !(dn=find_devices("boot-rom")) && !(dn=find_type_devices("rom")) ) > + dn = of_find_node_by_name(NULL, "boot-rom"); > + if (!dn) { > + by_type = 1; > + dn = of_find_node_by_type(NULL, "rom"); > + } > + if (!dn) > return 0; > do { > - if( !(p=(int*)get_property(dn, "reg", &len)) || len != sizeof(int[2]) ) > + if( !(p=(int*)get_property(dn, "reg", &len)) || len != sizeof(int[2]) ) { > + of_node_put(dn); > return 0; > + } > if( (unsigned int)(0xfff00100 - p[0]) < (unsigned int)p[1] ) { > *base = p[0]; > *size = p[1]; > + of_node_put(dn); > return 1; > } > - dn = dn->next; > + dn = by_type ? of_find_node_by_type(dn, "rom") : of_find_node_by_name(dn, "boot-rom"); > } while( dn ); > #endif > > Sorry about not getting back to you sooner, I've added your suggestion to SVN, thanks! -Joe |
From: Elimar R. <rie...@lx...> - 2007-05-27 18:33:48
|
On Sat, 26 May 2007 the mental interface of Joseph Jezak told: > Elimar Riesebieter wrote: [...] > > WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_devices > > WARNING: /usr/src/modules/mol/debian/mol-modules-2.6.22-rc3-aragorn/lib/modules/2.6.22-rc3-aragorn/extra/mol.ko needs unknown symbol find_type_devices > > > > Any hints? > > I've already fixed this in SVN. Please try that and let me know if > it works for you. The module builds fine, but running startmol -X: >> ================================================== >> MacOS X Boot Loader 0.9.73-SVN >> Candidate boot volume: /mol-blk@0/disk@0:0 >> /mol-blk@0/disk@0:0,\mach_kernel (4347724 bytes) >> Old mkext timestamp (or safe-boot) >> Loading from /mol-blk@0/disk@0:0,\System\Library\ >> ================================================== <*> IRQ vectorCanBeShared 3 <*> IRQ vectorCanBeShared 4 <*> IRQ vectorCanBeShared 2 <*> Block Driver v1.1 <*> IRQ vectorCanBeShared 5 <*> Ethernet driver 1.1 <*> IRQ vectorCanBeShared 24 <*> MolAudio 1.2 <*> IRQ vectorCanBeShared 1 cleaning up... Terminating threads... DONE Elimar -- Numeric stability is probably not all that important when you're guessing;-) |
From: Elimar R. <rie...@lx...> - 2007-05-28 07:28:16
|
On Sun, 27 May 2007 the mental interface of Elimar Riesebieter told: [...] > <*> IRQ vectorCanBeShared 3 > <*> IRQ vectorCanBeShared 4 > <*> IRQ vectorCanBeShared 2 > <*> Block Driver v1.1 > <*> IRQ vectorCanBeShared 5 > <*> Ethernet driver 1.1 > <*> IRQ vectorCanBeShared 24 > <*> MolAudio 1.2 > <*> IRQ vectorCanBeShared 1 > cleaning up... > Terminating threads... > DONE IP_NAT wasn't configured. Now it works perfect. Thanks Elimar -- Numeric stability is probably not all that important when you're guessing;-) |